From patchwork Fri Jan 7 04:49:25 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aman Karmani X-Patchwork-Id: 33141 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a6b:cd86:0:0:0:0:0 with SMTP id d128csp79559iog; Thu, 6 Jan 2022 20:50:09 -0800 (PST) X-Google-Smtp-Source: ABdhPJwaMB12Huhv/BXvbenmU7e1kRXLXl/j9pVnhJKWk5mnQ30YfNHcuhncWOChxUipAJWdpZiN X-Received: by 2002:a05:6402:27ca:: with SMTP id c10mr14379445ede.67.1641531009325; Thu, 06 Jan 2022 20:50:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1641531009; cv=none; d=google.com; s=arc-20160816; b=mA4I0XC/7vT7m+Z4iotBfR+u66JrG23y5TSWslWLbq0DZZCX6fvKJggTdpq6oLms58 CuFkL3CxSkXQdUklkQxaGZ13g8ga+pfnpb1odwa0UWkk2Jk7YvGvyIvGGtFVihMAyVCo IKl8Jef/fetRaCmptW8lt+nuDcIrhp3hZc0HnXhM94mOOiubAQ05xb2+jJfQVU7gNCi1 VWW9OT5e5YRibDjGeSM2Hgzwo5h//Bp+GHtkIxfP8WPHwdF9BrTuyS2s4NI08T9nTDd/ Xi8Vc9nRgRfriJeRZGhQafrAuMC6sspTDU5+sodIvqgRZg3aI9ErzXrxcnQUe9ec4w8V xqYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:to:mime-version:fcc:date:from:references :in-reply-to:message-id:dkim-signature:delivered-to; bh=6XxgHhTyoP+5+U2V7xUPcLLjeGITeBBWbiXxqxjH4WE=; b=wWq8ytJI4nLcIWrzoJNS6rzzOPxyDtI3LHXYmclUgHfgrsk0ZNaFs/H2LHsj+k6q1x cUOY+FIQK03qNLy9qPf6PSH7cPvRu74IxBiO6BZy2LMnDcOv65fk1DoF01PeTk4CH2BS /F6lymYX4gHUjp/wEX+6LchQEIpfVieVko9Cl4N3E1m1HCWaC5/RLB0qCT2xHLF3S9jy NOaQx2PCA96A6L542dqJ1nYnSkFn2mxX9F7mpbPfte601ImImH0tgXg/snpg4+L5APoL lwf+2NHYH2uzgy7k9f5OfaSreptog2JFgiFevseb1OXtAZuBeQEvPp4KaZ7WsORlHTKA yRKw== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20210112 header.b="pNS7jB3/"; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id d13si1953495edz.303.2022.01.06.20.50.08; Thu, 06 Jan 2022 20:50:09 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20210112 header.b="pNS7jB3/"; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E8C2568073D; Fri, 7 Jan 2022 06:49:39 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-pg1-f171.google.com (mail-pg1-f171.google.com [209.85.215.171]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 3EBC268ACB6 for ; Fri, 7 Jan 2022 06:49:31 +0200 (EET) Received: by mail-pg1-f171.google.com with SMTP id a22so91497pgd.6 for ; Thu, 06 Jan 2022 20:49:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:in-reply-to:references:from:date:subject:fcc :content-transfer-encoding:mime-version:to:cc; bh=+ZtgBZ+33Qd/8+crVGUMYGpnUwkfIUhGP51jQVsOgYE=; b=pNS7jB3/q16LOdGfnbQzbKKWGVklsPGs0W9RENQ+tnHiSFRCiJGfvDl8MUQCV2OGAf De4D7v6QIMCte8TN0MMBqGvw80Rgjl6d8k0oOURJxiOgNRksAnSq9eDneaM2n4nYjO8N ZKgpSWcDBabONwbBMCwBUwhLRVReMOl03jvS2zqqatmkTL+xWZqb77cHFlaqvJBwCMP6 VCJXE3fkKRP/E7qRd7i/L1VolToaxOFLANUfAx5qmGKD82ph5/zQBJZ0noOa+L9WCGTH N7/vEMAYvSC9/Uc46j2MQqMFljMTyTGK284kxPA8rWHeGXVkmdmD70cWSJSN/XCBbrkX XdTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:in-reply-to:references:from:date :subject:fcc:content-transfer-encoding:mime-version:to:cc; bh=+ZtgBZ+33Qd/8+crVGUMYGpnUwkfIUhGP51jQVsOgYE=; b=kK7gogxpeja0okdkGlwiM734XpnsygEs4hKJ+OGxRxlyO6dosEbBtUkmhTr/yeliRk iLez1iVPdLcPZ5R4kRvhTffWer9WmsCUPdRatba2/A+UY5tXBVkZnn19sT2vN+SR8cV4 JadCw8qYX2ISh6hJJpF4W+618ErbwO/ALBC+eIPQNLSypITlBRkUiUCR3nrJXYeAMVeM t22mUcMmZyKW4LegQSqJTA047LZFYSO3z4qr458HQRgHxWckC6FUmlIPJ4wc9RNnqPc4 FiiG/mnaArxXSFChscKqVn2ZxQG+yFvjDDV+2q8dPcR9fvkjblYvLkIOPMDcAimzAqg0 Izcg== X-Gm-Message-State: AOAM532UDJTlK1nPN9h+HpEtaZ+YWJ+fErlcLcGyFLiBujh6VWdp75FS e0OAYS06NDHUWOhFdD6lyYOQ3mZFoshGIQ== X-Received: by 2002:a62:6501:0:b0:4bc:9bc9:5231 with SMTP id z1-20020a626501000000b004bc9bc95231mr23653667pfb.0.1641530969677; Thu, 06 Jan 2022 20:49:29 -0800 (PST) Received: from [127.0.0.1] (master.gitmailbox.com. [34.83.118.50]) by smtp.gmail.com with ESMTPSA id s35sm3913097pfw.193.2022.01.06.20.49.29 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 06 Jan 2022 20:49:29 -0800 (PST) Message-Id: <9186ff48ec44e93fa268d743d9cb37b57c2f3301.1641530966.git.ffmpegagent@gmail.com> In-Reply-To: References: From: ffmpegagent Date: Fri, 07 Jan 2022 04:49:25 +0000 Fcc: Sent MIME-Version: 1.0 To: ffmpeg-devel@ffmpeg.org Subject: [FFmpeg-devel] [PATCH 3/4] avcodec/dvdsubdec: don't dump images to disk based on DEBUG define X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: softworkz Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: 4mEyBebZAA8x From: softworkz It's been a regular annoyance. Introduce a debug-only parameter for this. Signed-off-by: softworkz --- libavcodec/dvdsubdec.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/libavcodec/dvdsubdec.c b/libavcodec/dvdsubdec.c index 52259f0730..c0f796068e 100644 --- a/libavcodec/dvdsubdec.c +++ b/libavcodec/dvdsubdec.c @@ -44,6 +44,7 @@ typedef struct DVDSubContext uint8_t used_color[256]; #ifdef DEBUG int sub_id; + int dump_imgs; #endif } DVDSubContext; @@ -597,8 +598,9 @@ static int dvdsub_decode(AVCodecContext *avctx, ff_dlog(NULL, "start=%d ms end =%d ms\n", sub->start_display_time, sub->end_display_time); - ppm_save(ppm_name, sub->rects[0]->data[0], - sub->rects[0]->w, sub->rects[0]->h, (uint32_t*) sub->rects[0]->data[1]); + if (ctx->dump_imgs) + ppm_save(ppm_name, sub->rects[0]->data[0], + sub->rects[0]->w, sub->rects[0]->h, (uint32_t*) sub->rects[0]->data[1]); } #endif @@ -745,6 +747,9 @@ static const AVOption options[] = { { "palette", "set the global palette", OFFSET(palette_str), AV_OPT_TYPE_STRING, { .str = NULL }, 0, 0, SD }, { "ifo_palette", "obtain the global palette from .IFO file", OFFSET(ifo_str), AV_OPT_TYPE_STRING, { .str = NULL }, 0, 0, SD }, { "forced_subs_only", "Only show forced subtitles", OFFSET(forced_subs_only), AV_OPT_TYPE_BOOL, {.i64 = 0}, 0, 1, SD}, +#ifdef DEBUG + { "dump_imgs", "Dump subtitle images to disk", OFFSET(dump_imgs), AV_OPT_TYPE_BOOL, {.i64 = 0}, 0, 1, SD}, +#endif { NULL } }; static const AVClass dvdsub_class = {