From patchwork Tue Nov 9 18:01:53 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andreas Rheinhardt X-Patchwork-Id: 31342 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a6b:d206:0:0:0:0:0 with SMTP id q6csp1496011iob; Tue, 9 Nov 2021 10:05:01 -0800 (PST) X-Google-Smtp-Source: ABdhPJzGwkOE2i90JixWuVqCP2kmjHTdDbzMChMLkcYgyXufFzMsBbamMvpHoa+6N9cQ+g5s29Es X-Received: by 2002:a05:6402:206c:: with SMTP id bd12mr12644408edb.283.1636481101685; Tue, 09 Nov 2021 10:05:01 -0800 (PST) Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id dp9si39493301ejc.773.2021.11.09.10.05.00; Tue, 09 Nov 2021 10:05:01 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@outlook.com header.s=selector1 header.b="doaIavp/"; arc=fail (body hash mismatch); spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=outlook.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 55B0668AE70; Tue, 9 Nov 2021 20:03:06 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-oln040092067086.outbound.protection.outlook.com [40.92.67.86]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 6D9FE68AE68 for ; Tue, 9 Nov 2021 20:03:03 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lD4094VZJGx+eVl/BpWLGeznvzo3NaKBhKwAYgMkMg+mmDu1p8z4Kzw/LD/EV4AWl0On27OfqE0BfBCFV5DIqsneyhbyxF6jB44FTF+wxPsu4q36kFKc3yLtCJwM5Q466fzhYxw6kfjHyIMYnxBHpB4ieF/4r5DC7NJkPugStqTSRyl2K3VO2lEwZyHbhjMMVNsgHs196XCXoWT0SEVc6moFmuF/bV/Ly7SwozhafZdiRT6dUwtT33o0L3hu3vC5qrtmPglD0i1o6rnF8KWn/DvRmbGa49uftZKbiyA1EumtZkbBtU5keZ1UY3b4iMBa9WVjRNDZjcGIuWuPP70eQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bWD5f7KqYpB5BoxAhzGJBucKJwDq65v7v62P36N49bs=; b=kCybjqwE8F1EKGEjOsX/UnTG1ygXTs0eDQDTsMFg5heIU4moorfb4ZZrjDtaXCWAwu0oOjBXoyhwYK88v2FxB5lT9+l217oXWn4cETH+azQZQsHwDlGDIDJww8H0Wy12ASXZdA8IGjdr/b73DiiTe8fGu78IXlYs2enAapeOUCDJ6rsUJhwxe5m9VYWcfnnWUIyFhWlHT+TPhJlQoaXsBKsuokYNL9Zx8/7iyYWo+5E0FVDoyLdRl2cWgizzQbjD9/ENljpkz85WVw8aicGHhsRz6uGI/62+2d4dpwrdESRC8Zqv/rj1uURsOR23r13KDOPCEtLDcfygDKSoD8xXNQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bWD5f7KqYpB5BoxAhzGJBucKJwDq65v7v62P36N49bs=; b=doaIavp/4escXdVKC8h3d9uyKzT7gSZBGX3N2fsKLZj1WsExqaBYzVIHOtK5kr1ksTr0uJWXgmVxJZuCehmGGR0gjETOUA35riGAHIkffPz+nTru6Z4dBqH8a3dt0LPvm39d0dzb/210Udxi6cH+aeDBc4GncZcHgghmrPacso4v8U4bYestMfeM9Zor2uJQEZG7T8TVt2+j3CsotMrlYM/I8Qg/y5g4IWt4bMYAKwK0cgM25UzrDqKlIQLpe18xWxWHMgzZ/0id7dD+LP5Wc4+lO49ErTIk1SYQ16rqx4BS2nhuEdvVel0wR6dZyTa2Zlf/aXOQOZiQM/9b+sTQMg== Received: from AM7PR03MB6660.eurprd03.prod.outlook.com (2603:10a6:20b:1c1::22) by AM6PR03MB3959.eurprd03.prod.outlook.com (2603:10a6:20b:20::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.16; Tue, 9 Nov 2021 18:03:01 +0000 Received: from AM7PR03MB6660.eurprd03.prod.outlook.com ([fe80::700f:d70b:3bb8:4d51]) by AM7PR03MB6660.eurprd03.prod.outlook.com ([fe80::700f:d70b:3bb8:4d51%8]) with mapi id 15.20.4669.016; Tue, 9 Nov 2021 18:03:01 +0000 From: Andreas Rheinhardt To: ffmpeg-devel@ffmpeg.org Date: Tue, 9 Nov 2021 19:01:53 +0100 Message-ID: X-Mailer: git-send-email 2.30.2 In-Reply-To: References: X-TMN: [3cZQQGwbgjcBJzgC+zkE9xFehfwIowK6] X-ClientProxiedBy: FR0P281CA0081.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1e::7) To AM7PR03MB6660.eurprd03.prod.outlook.com (2603:10a6:20b:1c1::22) X-Microsoft-Original-Message-ID: <20211109180155.881111-14-andreas.rheinhardt@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from sblaptop.fritz.box (188.193.171.90) by FR0P281CA0081.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1e::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4690.5 via Frontend Transport; Tue, 9 Nov 2021 18:02:59 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 96a4149b-7d38-43a7-eea2-08d9a3ab2bac X-MS-Exchange-SLBlob-MailProps: q+fD6XS3/UK0N58+FL4vqTETnLi+orS+j062VCIeXW9VuFa92Sd+d71GUkKFy/xoAMHKj54SjTiOjepccb/XPUvGEP19Jf3tiBsDgf8rjM9E3RRFIjqQUGQd3wmQa6NMSSPFg3LG43IT3qwV6ee9KR6x0BBr9pOc6mV3umiYkdJKXFw8hWizsJEjECIV4hZX5B5R/s0Vfxbjhlyt4p35rt3f1SU/d90RvpO9Tz4k8OmbQLi2hlWrHg+5fWYyOe/E1sEsyGMG0Sun/T8SSDG/aJKkgSCIoAZ6XOLnqt98BoNk1gAPh+LzL7VI/86BGJDoLR4gK2wSMUywJWw2ARYBuOrfre3dJzuBQw1MgBVW7Hu3AUJ+IWwImdgDrrEumWI+zXQeGodTeFSDaTOmppgs2NJyArQ6smlIDRXOMNNWUYBQXmbihfYyW3mRReb8178XYaRl9qOieO+xMm5bQjaNGD/xYg8M/NS8xuBg5VrUT2tipAz5qnoQBQBpEw/m1Oa4tqOv+v3bBx6OCDyQgcJ90jP6tzFr81xbnM4lanrofYOuGWhCnho0YQwGWhBbfBfjNDv0v2p6tOga/rU+Wu8jEyhP6ZR5RpwSZaVBLJqcj0tTPd2x/5gFeP+nvW5UkO1TC10DHOc5eoxd7Lre6BQUdTamS3x6Ba0kyGCO6E9LyjpwfbbmXT8b1yt6/vVRzOIvNSeoRbH81GpxqYYtTFEuUA== X-MS-TrafficTypeDiagnostic: AM6PR03MB3959: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6zlhwBZ4y/u3K7dEkWWTQwAIpGHyUCVWxmA5m/j8xEne5vXqvzQngZqn5vmhB9gDha/6FqIT9yhzvTA4+rCZlQSEYUHKV7hbiS03DlwBC3dFg2+yAcWeg29QtqScM+KA6LsJV5u2HMwq/6VsOJClDsNLv91hdToRqdJp4cbGnh4RQZB5O/SVNV8WeogYA5SwkCVxHzZ4WldRXYJmw1RysUg/sxZDedy4h16ZzY3g73Il9L3A2/YN+ozxXgphEsU+RDcKI2RXDVeVteunE9LV7cRzHWdJ2XO8GSa3+GdP/NGpTFS3ya+3Tsmse+5FD38OrnN44cNTuzfD3c5aTAksCoYWBzSreKxikGJx8JKDz6fZdMuodU6pBMg2FPdqgiTHWr4NJPbetxt8Q3RMlJCjMBYLHRle7eLAE1ugFObDRdDiW916RCDEekGXUMEnlsOFenfC6i6DuIuSrm3eFC3Fyr5pRUaKso1Qg3PpOODW9LPKwyU2ikZMnCBHKJTk4zhntAXhL9hkQklVKv8DAQNP+e3Q88f561rFlgpeqSzWEA4= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: mFo3+0+7mzxo+DTM1sKt1GKT7lvW+J1MfnZjJo8kSGCRCsHiHl4LOakuaCphrYVCih+K1vV74dFErcSp1Nf8/lmGz82WUE373Ak29oQv8G5JHRxHn3iCVRZ3wh7xaEDfK3iSz6TAqRyea7fSU+/BjiTg2dqyrKi68ySJ/OOj+0Bvje6JDfUvjreEJwdrHyciDuAjRKjiMuskjZKChA7Vx7VmQhZEEXtREniwZnY9fdeNp5TGipdJoMDZHg7pwBCyHOYrgSwmxbDS3rEUhQM/FSIkqKYib2hfECfrxWl/Ylw7ZnDtXg281iGTbcip1SH9qoaQ3cE3x8duBuVRGbkeplIfJN1QSYfFjRTBZ16BNvulrV4awOlz+fiZa/7QaP/sBR+cmHi9WC62XS7+sDmN7Pu+b7++l81YDNGr3ctYPqbCbujm76xWv3cdaYFlTBX12h+q8u1uJzlwucUzNSTSO7tlo5U+UAHYF2YiaZPiObWuHNmBXg4ipKyW73pFBvSf8g6xIntHK3WE7K9lJ3TdsAdpP+8+ggUBQNxfy3rb47jEtg2ANNbKBZaRFyOTfBdkFeVVmCs+/9GDJpXG8T6sMBRAJezL0y/C+MLNjmp8HDWsN1zUO9JwtBqhZExD0j2wXF6FEuVPH+rBCman7mzHq+ZdzEEIGXnUS67YkyVT8akm8DoYn+1olZGKVJZiwSFytIDJ/tlGBYYsb0EyPq+QKw== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 96a4149b-7d38-43a7-eea2-08d9a3ab2bac X-MS-Exchange-CrossTenant-AuthSource: AM7PR03MB6660.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Nov 2021 18:03:01.9135 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR03MB3959 Subject: [FFmpeg-devel] [PATCH 15/17] avformat/utils: Remove unused shorthand feature for auto-inserted BSF X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Andreas Rheinhardt Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: bWwXFhUvjnxe Besides being unused it should not be used at all: The order of options of bitstream filters is not guaranteed to be stable at all. Signed-off-by: Andreas Rheinhardt --- I wonder whether the undocumented and widely unknown shorthand stuff in bsf.c should be removed as well. libavformat/utils.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/libavformat/utils.c b/libavformat/utils.c index 509c0ecdce..b42f4d5ca0 100644 --- a/libavformat/utils.c +++ b/libavformat/utils.c @@ -1760,13 +1760,7 @@ int ff_stream_add_bitstream_filter(AVStream *st, const char *name, const char *a } if (args && bsfc->filter->priv_class) { - const AVOption *opt = av_opt_next(bsfc->priv_data, NULL); - const char * shorthand[2] = {NULL}; - - if (opt) - shorthand[0] = opt->name; - - if ((ret = av_opt_set_from_string(bsfc->priv_data, args, shorthand, "=", ":")) < 0) { + if ((ret = av_set_options_string(bsfc->priv_data, args, "=", ":")) < 0) { av_bsf_free(&bsfc); return ret; }