From patchwork Fri Oct 8 08:14:39 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andreas Rheinhardt X-Patchwork-Id: 30996 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6602:2084:0:0:0:0 with SMTP id a4csp625239ioa; Fri, 8 Oct 2021 01:15:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz+NlXOpvH14vtkKrI+zrHIxkftq8iHJ/n9m0hA9PwOjE7nS0REWU/VdUSeuQOKbTGwhMtY X-Received: by 2002:a17:906:1f49:: with SMTP id d9mr2454571ejk.150.1633680913040; Fri, 08 Oct 2021 01:15:13 -0700 (PDT) Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id m27si1400135ejd.83.2021.10.08.01.15.12; Fri, 08 Oct 2021 01:15:13 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@outlook.com header.s=selector1 header.b=mcnVWrYY; arc=fail (body hash mismatch); spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=outlook.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 65977680923; Fri, 8 Oct 2021 11:15:03 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-oln040092065060.outbound.protection.outlook.com [40.92.65.60]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 73D3A680923 for ; Fri, 8 Oct 2021 11:14:56 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WSaooCZ/CDOilEVqElzrkEn4C8q2gcGocJmnlwr386c3dn9UEYS81voiS5bn7dv87548jhJEHSuON+EeDCWXZ0CxQRyg5JuCiucNDpmdZklWOKFgFP8vaofA094JWi8549xT5ieDzjl5jLdvk/V7U4G23z3ijd/7rgkofd8qyrNberXD7m1muja5EQ9ngwG9eSzv7DpwDZprZ3Lq9dQ0Y9k+L9zO89louJl44DEvMpyCt8/c6bC8cpOi5MZyBwgEzCraBhfxTffsygOsFqQhK5oylB3SX8KSDE7fTSKFUhFlkpdHzCPhQUl9/Qkovdwzceliw+27UKq3dAPPl35vVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iqLfz1dbaQ6qO9YRpUudfDZxnFBGRsKpijVJfOz/sqA=; b=kxcotm1qt9VSvV25sOBZfxxuWybxCP2bjenZzD3Ty7fNlFxUMVsaYNCzyCEJenUWLDGCtGQHAbce23ZZwCiKhjXDb8h86Q63SOKm5wIniQ1/H5dBvEzW6Al3A4Gn7SLQxgcJdmstsCvQEK19KrnMDwTyaKi7KYGdLvf/+JN+NrhePjwyf7qhdtj5bx3DZf64FZjgLGz0lRkjjEL+Iu9l0gMT0n4aobcg3Cpuifk0nXci+A6g0GflpkMeJ8GxV8FCoqpi0a4eoClpW+VIbUF909wTAiDAqroRm27a27XdpoYYvyVaUNovKzS//8aoiAZc38ccLkSW3bTZ1BF34Zw6GA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iqLfz1dbaQ6qO9YRpUudfDZxnFBGRsKpijVJfOz/sqA=; b=mcnVWrYY+3SXQWCfVAuWaXzjgNfL0zuoF3Bac/jl7iKFeviy5cbIK1Xt96Gd8rl2xAf62s2KcMSJQnwWDkszcX9XD4RrCXyAo2oLc0D7Cbgasf/zEmtW7Zm+PB1rEe9n3GT8qT209oYtvenoyX0IByF7volADU0gOMATYGFdBXB4jY/1KRGczEzNzK04diHZsdRPVNCm/acILsaJBztfHOGw5gMGcse4CrvjaLtFL2zCRXA8MlpnWF3ozVLX1ivRNPfx/xXPqHyyRvpJEw9iwjGVH5NSMeNs/rHLSQwZ4BkOufVgLK/G0ghqvUvkKPq4T+ByU7zN0S2szbVZdiP6Ig== Received: from AM7PR03MB6660.eurprd03.prod.outlook.com (2603:10a6:20b:1c1::22) by AM6PR03MB4951.eurprd03.prod.outlook.com (2603:10a6:20b:82::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.22; Fri, 8 Oct 2021 08:14:51 +0000 Received: from AM7PR03MB6660.eurprd03.prod.outlook.com ([fe80::700f:d70b:3bb8:4d51]) by AM7PR03MB6660.eurprd03.prod.outlook.com ([fe80::700f:d70b:3bb8:4d51%7]) with mapi id 15.20.4566.022; Fri, 8 Oct 2021 08:14:51 +0000 From: Andreas Rheinhardt To: ffmpeg-devel@ffmpeg.org Date: Fri, 8 Oct 2021 10:14:39 +0200 Message-ID: X-Mailer: git-send-email 2.30.2 In-Reply-To: References: X-TMN: [fY96nPB63gEqpnJVXE6NvzmrGYKeuSKY] X-ClientProxiedBy: AM3PR07CA0076.eurprd07.prod.outlook.com (2603:10a6:207:4::34) To AM7PR03MB6660.eurprd03.prod.outlook.com (2603:10a6:20b:1c1::22) X-Microsoft-Original-Message-ID: <20211008081440.1156233-2-andreas.rheinhardt@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from sblaptop.fritz.box (188.193.170.49) by AM3PR07CA0076.eurprd07.prod.outlook.com (2603:10a6:207:4::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.4 via Frontend Transport; Fri, 8 Oct 2021 08:14:51 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a79ab9d8-0090-4d68-bab4-08d98a33b3c2 X-MS-Exchange-SLBlob-MailProps: S/btQ8cKWiQkYSKJ5lHLQC1UaOPRuftlGYWDteCuo3CpJjocq+8am/RRtD5AkO76s8xAsyYePYd6zqncErMY1v/Ji5wFALlYUk5Jm2sKmdxZeDJQ0u7637U5ofOyC13p+4IH9bO5TQC5BDQwoZQ36qM7dySTexSZdZLYCmKeo+zUxroauat5fEK5IcUVNciubYdN/sof78/3lWDFm8x9tmSb7nnAJdwWVEf/bv1Rc1v9vUCvS7/A5rJwry/V6igln3iNMZlRTVSJuKjt2jZG03NP0h60yN50EjkKogAiyKbI/9h3Sw4vcci6lWOB423DCf8WvNhCVMq0m3R36hvcVGsgGVWChJZPNx/06YUWOwe4bl8IbBMdh+jJqlkg7YRQSW3AXLSakaH7EXIvbCqk4/vl60KzKQsw3Bm3P5omgU2cJYJfyUl8L5gXGNco66eTdMZnq+4wUry82bghgekfZWWyaY4LRkO8FFGrTHUTPbLFQQzYnAZNApN+3l579NMJ/3ifvVJQfNMa6Bk0ApC1sg6c7pZH26yECCTDqyBgk9vB9HBl0P5s+Dv6eNJlltndNScj8QjvAR/1RY503y2gOlA1uFF81hZXtZiF5DAwg6vUSqjMaZdrqEc7srBiP3amGNREDcU7Vh7KVOsA6GD6xCGFxnhCCxs2V3xAyV4SR8IZAwUT4G+/tWMHbsZ/8VL5Z/tUiGnCnpvERaUAxeNCPtB65Cm2gl5WC0wOiAoCpxKY9TkxcseHBTTPbjQd2VZ1JqDKHr7P+Qo= X-MS-TrafficTypeDiagnostic: AM6PR03MB4951: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1vkBd6jwXHCbV+14Ue1oABaswyfm4mjCKl5oyj/uBqviMyEP/JKDwreseZqSAgHGuftVmpaUZAa0dP3hosOeuocJ8bjZfkE9Jmw3WYVsbJw7a9G5saEJOjSjA4zAYpXTvAnXq+lAPr7XD678sUbfxkrGQNi3hKn7NTvQKhT7k602Hbw1z/GoVGLy4kBQsKvoMqo/NT/oiBvqkfQLoI86vmvCyTWcyM+dJhqNQr7dDbjIcRxglCcz1U+OziBfSNQz793fjd1wQX8f8NAe8GsImjAhHb/0v5ykJ28IcBHxO0ATWIGhL25WR+8peaNKlyzl+HWZvqI7wVPFKfr+/mXf2DsjHfPTjSTKmW1up95L9LUHrjiTOj+j+Xpw8Jn0wWdu9LGyqU5eu1nauCiVCPJM8tieNphhTP/N+RV6o6A7EZj6zAaMhUECoPCBE9bf2bky X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: MgHAYWEuVJLzs3kbCy9HMNKPo0MZ5iWWITlDVnLJeicoJyg9bTFKrB890XDMsbZFk+m2fqPV2pytE5evj9Wl54y4UuVK42yno5F7bolUDoi3OBFV402X8BqhNCYBK362r3HjvoQNBBUN/l2GKQ2N3Q== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a79ab9d8-0090-4d68-bab4-08d98a33b3c2 X-MS-Exchange-CrossTenant-AuthSource: AM7PR03MB6660.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Oct 2021 08:14:51.6073 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR03MB4951 Subject: [FFmpeg-devel] [PATCH 3/4] fftools/ffmpeg: Fix crash when flushing non-fully setup output stream X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Andreas Rheinhardt Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: +NPz9IJlkquU The output stream's packet may not have been allocated at that point. This happens when quitting in the following command line: $ ./ffmpeg -lavfi abuffer=sample_fmt=u8:sample_rate=48000:channel_layout=stereo -f null - Signed-off-by: Andreas Rheinhardt --- Is there actually a reason that this packet is not allocated together with the input/output stream (instead checking every time in the non-init codepath)? fftools/ffmpeg.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c index bb29e3cec5..0e38d6d185 100644 --- a/fftools/ffmpeg.c +++ b/fftools/ffmpeg.c @@ -1981,6 +1981,9 @@ static void flush_encoders(void) AVPacket *pkt = ost->pkt; int pkt_size; + if (!pkt) + break; + switch (enc->codec_type) { case AVMEDIA_TYPE_AUDIO: desc = "audio";