From patchwork Sun Sep 12 10:53:28 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andreas Rheinhardt X-Patchwork-Id: 30184 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6602:2a4a:0:0:0:0 with SMTP id k10csp3084661iov; Sun, 12 Sep 2021 03:55:20 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwBuJgyZKttNi96kjCBAIo1hhcfYFn/qfyqyn2hxHoGPt9ytusGxWyODNTqiBMD8LjZy48R X-Received: by 2002:a17:906:8a46:: with SMTP id gx6mr6834520ejc.424.1631444120500; Sun, 12 Sep 2021 03:55:20 -0700 (PDT) Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id d10si4186355ejo.371.2021.09.12.03.55.20; Sun, 12 Sep 2021 03:55:20 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@outlook.com header.s=selector1 header.b=tG2tQLPg; arc=fail (body hash mismatch); spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=outlook.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C317668A9C8; Sun, 12 Sep 2021 13:54:46 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05olkn2033.outbound.protection.outlook.com [40.92.91.33]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7C05868A9C1 for ; Sun, 12 Sep 2021 13:54:44 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LxD+ZTgTt+qDL9yUkx/QOo4k5mjKreHSQftmaHrb3y95lrwgyAH2BwgBOHPKT3woMmvF1QBdMhwjpc5lokVm5OUaA4s/hZLZstszangVT1KHhsHtLo8vMzSSlx2wNfPbBd8hRmkNpt9D5/5E9S3gQ6kB4a4ViiJVAT5KM4BCuyGwgSuFALDOoC2p2sT7dTkJLJIj7KyAvIcWSlILrvBhT/npLYrg+5ZJzqWcTGG8HOHF2E2dg/v/Cdon2vRyeUyVjZSluK51Tye2XqmNbfoYNNT01cvNXhP8Uh3+4dGsAWw9fHMTcIHj0yfhemN94LBhhqPqgPVKBSx2UscnETFXmA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=oCJuC7APwnZEwtsg2G1xUrgAhXQEpXus/xmSIGrDcvw=; b=CCXbq/QOehJAjdkMB3Noa+xFztpoP/lpLfAQEDOdjmD9+Vc1IpfoBR3urq3CfsTSxv4qaFdI4FAxlmG8lwWOhOCJFQpg+1K5wRzsXwCk52zPf02VTiwyMhBoJ8XosRvExqLkQio4nNlxobDvXcb7ykC4cWrYZXNelBZScEak1WXFcerBj2EruddLxhNyBACipFfDIkiA7VVhBtzAT1GM9rv5FTnchI66KriSM00auYQWA5SfYPOdDDorakj5bly5CbaZxrvhKvTrRjvTNn4s6k8yz0yqgsWLMzGZ3vQxdkXvVXW0IhmkfLMT2R+NsU7zuSI5buiKd3Zr6zPu+AAn1g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oCJuC7APwnZEwtsg2G1xUrgAhXQEpXus/xmSIGrDcvw=; b=tG2tQLPgNDHCfZ6W6ED7V+Ch6w7PZFYTTpEK96zPkhVDU54jUXldN477Swm8aXdxPIg+Mb6gmnHVSeTVYCRUFbkI/jt+sIHsA3w3CG4RGgCAf+CiuesEIml3i5y/fyq5ZZA6snboiYZ00qSuVxlNFj2eNsZjlP7PFpMFl/t2TfzRH7zkjCFMIo8uTjCal8s7Dff5e5H7PGnQorwFTdtBGr58iF9q18GlBpqTjsmQr/+47rHS4ikdc+l8azq43Maj7vmDGH/1UBvgop5zs3m/XZgS94+V/1YeT8hWTNhNHa3V1gTxW0PD3crwPYckxUaJSb4wr3l0jawtNkNdLB99Ig== Received: from AM7PR03MB6660.eurprd03.prod.outlook.com (2603:10a6:20b:1c1::22) by AS8PR03MB7158.eurprd03.prod.outlook.com (2603:10a6:20b:2e9::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.16; Sun, 12 Sep 2021 10:54:43 +0000 Received: from AM7PR03MB6660.eurprd03.prod.outlook.com ([fe80::787b:2156:ca99:fe00]) by AM7PR03MB6660.eurprd03.prod.outlook.com ([fe80::787b:2156:ca99:fe00%4]) with mapi id 15.20.4500.018; Sun, 12 Sep 2021 10:54:43 +0000 From: Andreas Rheinhardt To: ffmpeg-devel@ffmpeg.org Date: Sun, 12 Sep 2021 12:53:28 +0200 Message-ID: X-Mailer: git-send-email 2.30.2 In-Reply-To: References: X-TMN: [+Yy73P2bZa8Fk+4+CwX+heuQsjmRTpi8] X-ClientProxiedBy: PR3P191CA0049.EURP191.PROD.OUTLOOK.COM (2603:10a6:102:55::24) To AM7PR03MB6660.eurprd03.prod.outlook.com (2603:10a6:20b:1c1::22) X-Microsoft-Original-Message-ID: <20210912105330.2310204-9-andreas.rheinhardt@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from sblaptop.fritz.box (188.192.142.38) by PR3P191CA0049.EURP191.PROD.OUTLOOK.COM (2603:10a6:102:55::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.15 via Frontend Transport; Sun, 12 Sep 2021 10:54:42 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 14676a92-66ed-4197-2ada-08d975dbba09 X-MS-Exchange-SLBlob-MailProps: IONHXCiRWANgiGNl30/Xz88Br5ZgdUZI2kJ6eyUh+ArIfNJOVA+eunm1QOY2FsJD4OTxoAXQiSCnojkMtlli1A1rnONI1R5d68GPcoBjkHEs/7Uq7lSvl4NWN9UHYRsHkye5DB8NKL+lt4+5cKdu9F9JG+j52SgT4wXrt6ZvOCcQsB5oC5OTszGdXk0FpnoC2bMtZOjl99YFD8wo6jIaN/hbj2oDzwlr9Es7mlyoMKJvSMPn8xM3wp+XY9MfNgarGgRdPKDHFn1YNQcZK4ZN+SpCWwVM+Pyz1cnwP6sGSWCnpGzNJ9oi37/s7AYJ/Wy8CoxK+9Q3XFfHbnf724gctxYCCCbBedHZOdo+2RRz+DP8dgXVzRpEX+NlLfV+8QJbNR51QEBi5X9lLlVXMEVKaN73Fg4Ec0uCkEWr5Q28fTq5ioNpQCURKHr07gf4Mh4Tiw3go3NygX+PwfcmonCiMlXLF5PF0hNeInkbR8rBNOL1+VRpPEAg8RDqtp8jJonJ93/sazl2+Ze2cIftcYuvow3ZIt/g3vHu6OwVTHT3Qd07tQAsctrTfKAUBCMFhqhSoDrlVNalxaeRR+Q9PlSmz2261YXOCJtVbqG0cfAk/YeoqFcanfZoHnG9hFQ6cp7doOd7LmiO9PDfz05fzFg44Dv4ahq0XULuReZ29HQsPb4YgHublcSsR+xATkD2GA74hnGekIsGJ2OXJFRSHKSoGUawYJDDo/SjLcUvtPsASDU= X-MS-TrafficTypeDiagnostic: AS8PR03MB7158: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3+6o85SXibarRfV4uYJ4PQUE5OjzHs8PO2tEuoJic1wO6r0chd2VamJReqNUgKz+Wlo9hDtCE5Tzx9u12yQSu+GaSr1xOd+S8ds5vIlDYM2NlsiN94qpZ/wrwpaHUOcv6qgBitYUq5KnGL3iaMtxq4PpF8z/H/G3dwouBCQTh1Fzw9Qu9RrYfuDln5EkPZc6nVS006CJu42o6J56avw690de3AeYMpSjE1B7LLFA3qHX8TEXapFL+W6m0hJPNBW7AZo1Lfxg1OKroq1sovKDMvLG8cfHc+P/UVab8WvFw0jZpAOh92ko74pHmSMMDCIbgrp7JppDDW/cqNzpeXUSB5wp/mZSI5aG1t59sTZbvjeBml2lSAGBIdOjsyOF+zGJkO6Arr46NqaVR02IrFwJ8DCi0xhE8H95kIRrUEOkre2Sv1JDlSSKDEl+Z1N46DzO X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: uIU8NNnnsKltbjJRDWqQdcfd5zkmMs/WZdWK5+ihZHSGi7vyyeogRy/NIjJbSHQ65y+No4IMvbxaWVgWHRV3jiESAB7aQ1IxM9KKAXCY16euc2pgTHLQ7/s/MwdsVD7hxuJlIY2xWiq9xOfh8NmczQ== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 14676a92-66ed-4197-2ada-08d975dbba09 X-MS-Exchange-CrossTenant-AuthSource: AM7PR03MB6660.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Sep 2021 10:54:43.2242 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR03MB7158 Subject: [FFmpeg-devel] [PATCH 30/38] avfilter/vf_hflip: Remove empty options and AVClass X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Andreas Rheinhardt Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: nj4grEKuPL3c This filter only had an AVClass and empty options because up until recently, avfilter_init_str() errored out when options were provided for a filter without an AVClass. But setting (generic) options is necessary to take advantage of timeline support. So with avfilter_init_str() fixed, the AVClass and the options can be removed. Signed-off-by: Andreas Rheinhardt --- libavfilter/hflip.h | 1 - libavfilter/vf_hflip.c | 8 -------- 2 files changed, 9 deletions(-) diff --git a/libavfilter/hflip.h b/libavfilter/hflip.h index a40b98470b..956eb982a1 100644 --- a/libavfilter/hflip.h +++ b/libavfilter/hflip.h @@ -25,7 +25,6 @@ #include "avfilter.h" typedef struct FlipContext { - const AVClass *class; int max_step[4]; ///< max pixel step for each plane, expressed as a number of bytes int bayer_plus1; ///< 1 .. not a Bayer input format, 2 .. Bayer input format int planewidth[4]; ///< width of each plane diff --git a/libavfilter/vf_hflip.c b/libavfilter/vf_hflip.c index 7b5650a821..bdff052b45 100644 --- a/libavfilter/vf_hflip.c +++ b/libavfilter/vf_hflip.c @@ -26,7 +26,6 @@ #include -#include "libavutil/opt.h" #include "avfilter.h" #include "formats.h" #include "hflip.h" @@ -37,12 +36,6 @@ #include "libavutil/intreadwrite.h" #include "libavutil/imgutils.h" -static const AVOption hflip_options[] = { - { NULL } -}; - -AVFILTER_DEFINE_CLASS(hflip); - static int query_formats(AVFilterContext *ctx) { AVFilterFormats *pix_fmts = NULL; @@ -248,7 +241,6 @@ const AVFilter ff_vf_hflip = { .name = "hflip", .description = NULL_IF_CONFIG_SMALL("Horizontally flip the input video."), .priv_size = sizeof(FlipContext), - .priv_class = &hflip_class, .query_formats = query_formats, FILTER_INPUTS(avfilter_vf_hflip_inputs), FILTER_OUTPUTS(avfilter_vf_hflip_outputs),