From patchwork Mon Sep 6 02:27:53 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andreas Rheinhardt X-Patchwork-Id: 30021 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6602:2a4a:0:0:0:0 with SMTP id k10csp3374338iov; Sun, 5 Sep 2021 19:30:48 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy+wR/EpWrln1Bosy6BZMP8CnbfOOMGaFVGFDyf7jQ8zaH2lGCnmUQntv+mQc47iZ60vxnf X-Received: by 2002:a17:906:3148:: with SMTP id e8mr11061430eje.240.1630895447908; Sun, 05 Sep 2021 19:30:47 -0700 (PDT) Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id j9si6641483ejo.629.2021.09.05.19.30.47; Sun, 05 Sep 2021 19:30:47 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@outlook.com header.s=selector1 header.b=rw5cxo53; arc=fail (body hash mismatch); spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=outlook.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E7A5A68A88C; Mon, 6 Sep 2021 05:28:51 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-oln040092066020.outbound.protection.outlook.com [40.92.66.20]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id B255168A7A1 for ; Mon, 6 Sep 2021 05:28:36 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dexpxoN2vN6XnoLspe/iTsddSsDTE1K/1poOlOxtpF2tYF4RWP/VGyDlLyH4VYvGcuzOu4IC3VHipUpM7Ru6vUBYTPzmgJ5DYmSWthq/PutzdQpEYalObJ323HN8jPgtKmsd4yCLKNxdABJYotN5feZrDZsnqDy/YPmPxEy0+74sHZm/sXVgOKF/20ky5cLOFIMfRdKbdhQLK+r8Fd1PnR0pbLXgJA4gL3gGbRICeRLd+izuVZ1EQVFfqufb5QZ2v/qopCYoAMsBtEs3vtKd+FgHTVEPFYpYzGCZSbIxZyVJ8ld1AC37QdF3PFEEwGP02rAH8CgUvM5mOTltnm1naw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=hT48tuRni4RPBct61/owcFdr8uBHwPGkGk1VYmLBdrk=; b=DcaUmB8lS456axVaDgT+xWU4lMQ+sLuLgq8JMH+tl58xRj6FJJOS0fWlREKqCHFwkfHi5FZc2No0OHwnMjK1Dh6gZcQkmNU91DoPoNe15X7fNpZgNhOKE7ftranRTrpxKmIZuHKPdJvSrSKAXBMfijvwgg2ygqtRSoKJypI8MRj4pCAbbSCNcObu/dqpjJbKmG82G62YyqLUG+LMGydbBcK0rdH1zSst4DGHD4F3qP4jnu3cJ3wzYdtYG0SMt10kZ7CwdK1vvoP7gSY+mAum87GkDX/LPU4EigEZYnhWw32jEtmptRS1u7N3vGyyeGzsUVcKpNPs+pHxgNj56Ay7FQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hT48tuRni4RPBct61/owcFdr8uBHwPGkGk1VYmLBdrk=; b=rw5cxo53BjnK+jO4+QINjrIPQ92pKzEbYVsRmbBG1xXfJZP4sK1xnEdeRTJk9jnDUle0WohmBR4t72YskfXjCk5KCtiwxzeJeeHPesmvp3XJWHNkG7zzVeFsZIvTh6S9L2GfaaMKPibXbHqHNcdZL2gDL0MTHYfjylBCHfgyFvn6jOwzOWfXJ7hzrleST53Q1EuAEpzx0u3Hi3wfuFPHEMnaepu+5bPl8bZoB0zyI9EfXSDIh5HByIcbYM+NgzPZvMgE+rd/J9jb8gW15u40nXRTUp+zMHWpmnVNrGcpg5pc9ZhdCf9ytYURw+KNp/2NWniZvIaAoCjS+HUj7nCmXw== Received: from AM7PR03MB6660.eurprd03.prod.outlook.com (2603:10a6:20b:1c1::22) by AM5PR03MB2850.eurprd03.prod.outlook.com (2603:10a6:206:20::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.24; Mon, 6 Sep 2021 02:28:28 +0000 Received: from AM7PR03MB6660.eurprd03.prod.outlook.com ([fe80::787b:2156:ca99:fe00]) by AM7PR03MB6660.eurprd03.prod.outlook.com ([fe80::787b:2156:ca99:fe00%3]) with mapi id 15.20.4478.025; Mon, 6 Sep 2021 02:28:28 +0000 From: Andreas Rheinhardt To: ffmpeg-devel@ffmpeg.org Date: Mon, 6 Sep 2021 04:27:53 +0200 Message-ID: X-Mailer: git-send-email 2.30.2 In-Reply-To: References: X-TMN: [7A1p8t+AvHMBnjnrHVIYRC4krINUdWB4] X-ClientProxiedBy: PR1PR01CA0033.eurprd01.prod.exchangelabs.com (2603:10a6:102::46) To AM7PR03MB6660.eurprd03.prod.outlook.com (2603:10a6:20b:1c1::22) X-Microsoft-Original-Message-ID: <20210906022802.4072793-14-andreas.rheinhardt@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from sblaptop.fritz.box (188.192.142.38) by PR1PR01CA0033.eurprd01.prod.exchangelabs.com (2603:10a6:102::46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19 via Frontend Transport; Mon, 6 Sep 2021 02:28:28 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b7aab50b-fc4a-4b7b-cc2e-08d970de02f1 X-MS-Exchange-SLBlob-MailProps: gjx25WM8ZNUZQ6GYRQPJKZ+OQ9+mOW9Ki4T0GMa/fZLhd3pn+5/2KN/Gtt05YfxLLCBG1gywQ6iMkS5KQdiuUgledzS4ZhFR2WFrEp0ihQb0UC45e8+jO9DDvDcpktnG4UHtckC5TJM4Jb8icGWILLXUfCZ9u97T3GAc+PVWbq+kFa8Ir7BQfC24v54IyuBvYnHb3BtM1xWHRuUnT3ee3GxfMznTR/xgPbccNvGdXnFlxktpD2R/9yEFsB1mXPhwnEZWwboeQmSCloT3jZwiKRXDl3MJmNR6V7ypmrnEKGTWzcfEUDNRnw2QgGqeuZYVi/v+gq+XowUrVoNoe7MjQcRtoFbPanPRhjNKpCvN+heYJYRi94KXA+wEtrCS6ybWWk+JqxqkmB/Xg9YprZBe/IxglT+22h/Gnexd6XQeHHwzJRrasz9k0nm5DqVFhm89TwtwBOUaKup2EmM33U+2msWNTHWXh3gwvED+UnHgaVQW08F7K4woPLn/pntdrwTQnstWHhzO0Gu2cDsZdYraUYcleOkRqGqdjQqdaCWy//IrzisqgJ5ZdhCLgXDs5sc6gSxHHIBFufa9GjxUqUQnXwd74qA1gUezvgpkVEwLtaZuxWp6QRa5uPdxbE/ADCxLCBmesClb/Ry2qDrDNoFLJH8kBJb3vI5qDCeOPyaRBzK1CzxmREwtV70yA0z9bI/VxFA8lIMc698pgj3ydeNa7VMeyXlPJCSgHnJPaXX01Fs= X-MS-TrafficTypeDiagnostic: AM5PR03MB2850: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: AcTakoklJJsfcYww2qf9akH6GgTkoEfgEiR8rzQDWhTLwkIe8wvGbPWJlFpSnaXkUhW4XkI4hbr4a5zNN6Afa3AbB8i1a1RJcow/PnBHi+1+Sdlu5mJHNwipuOjKHXYy72mTbHwAAGwyyrsnc+GWGUl9pOzo/NkpZZA/1mgNEf+u/eTQenR7fWC6oiiXN7zYpdYbgrRFXTU4liC7uZ4yblRz7hg5Rgf6kbe9WVoCHZfUnp+feQ66wl79/ZgZZY9qX16zGyFsVnWXgg2AUlMhP1dKfzaZLAUHYZkYOQ0xcuUdiquFXEu3Z0h4/s+Lxirk9y5hLQIzRi3GW4QJfIOvhzGpJrPRm+8IL6PXvOprDZ+IiqdNe9bxrWcPXOEjE310wBs6C6ijDnZHPhDarjNoqfKdHSl8XNnoDN1O7a6f4cPIUJwFnPwox7vis6e3o86b X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: /zlYGwVFP25YviXvFtrxtduF8h4leJsLyTaZMuOZrfTDOJ0EAR3u91Rlc1217moDBlZ4MqQglO7eLonUox6y5VQQZDtQObii0KvwcfVm8pmf/220YnkHKb9BjzHsLkE3VK8h4xXhr3jyQ+00Yl6vzA== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b7aab50b-fc4a-4b7b-cc2e-08d970de02f1 X-MS-Exchange-CrossTenant-AuthSource: AM7PR03MB6660.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2021 02:28:28.6546 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR03MB2850 Subject: [FFmpeg-devel] [PATCH 25/34] avformat/flacenc: Avoid stack packet X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Andreas Rheinhardt Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: dpEWorKxuZ90 Signed-off-by: Andreas Rheinhardt --- libavformat/flacenc.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavformat/flacenc.c b/libavformat/flacenc.c index 44c9341493..ab57a1e45a 100644 --- a/libavformat/flacenc.c +++ b/libavformat/flacenc.c @@ -299,7 +299,7 @@ static int flac_write_audio_packet(struct AVFormatContext *s, AVPacket *pkt) static int flac_queue_flush(AVFormatContext *s) { FlacMuxerContext *c = s->priv_data; - AVPacket pkt; + AVPacket *const pkt = s->internal->pkt; int ret, write = 1; ret = flac_finish_header(s); @@ -307,10 +307,10 @@ static int flac_queue_flush(AVFormatContext *s) write = 0; while (c->queue) { - avpriv_packet_list_get(&c->queue, &c->queue_end, &pkt); - if (write && (ret = flac_write_audio_packet(s, &pkt)) < 0) + avpriv_packet_list_get(&c->queue, &c->queue_end, pkt); + if (write && (ret = flac_write_audio_packet(s, pkt)) < 0) write = 0; - av_packet_unref(&pkt); + av_packet_unref(pkt); } return ret; }