From patchwork Sun Sep 26 06:40:26 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andreas Rheinhardt X-Patchwork-Id: 30584 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a6b:6506:0:0:0:0:0 with SMTP id z6csp3046647iob; Sat, 25 Sep 2021 23:41:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxoGQ1oJ/dH499X+h5vrsaBYratRqU1YxJtqXgaA6fl86+kY8KhU3ab+a0o311jeQnvcY2b X-Received: by 2002:aa7:c459:: with SMTP id n25mr15701500edr.29.1632638475802; Sat, 25 Sep 2021 23:41:15 -0700 (PDT) Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id u18si4510976edf.591.2021.09.25.23.41.15; Sat, 25 Sep 2021 23:41:15 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@outlook.com header.s=selector1 header.b=IPQdMjJC; arc=fail (body hash mismatch); spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=outlook.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id CF36368A97A; Sun, 26 Sep 2021 09:41:02 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-oln040092070041.outbound.protection.outlook.com [40.92.70.41]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id AC0E668A929 for ; Sun, 26 Sep 2021 09:40:55 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mtD73LchSrJhwGi2afMUgiQ8xGbaXLEgUhaemLqikKT8wyT5PZJx9SJGLPX+q7X4opFXtWNefoAHSpOjaZgan0WazxYFCNTpa3wmx7FX45MyEqun93rpbWRtJNtpeJePyeJ8HouLYn0rhfvv3//6nZ/xUe5tob4Xax/OaLXqZGikov406xjmh5EUG2H18pzsCVtNqJPUwczNUHZiWxRX5op9rIXNjRaUNf/2byU2+tJXAXSS4RieL5EKJpMWSadi/CyGEuEgZE6zQNA0pn890z/sJ1uD0fAmrPNo+0WkW+QfNU4QtepYEUIByS++vHO1BI5+e9XwuL66a5Kj5yJ7AA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=KCDZex2c0gPFxPVRnWFQlDBr9kectynNYP5o0wUAOv8=; b=ZCCOLtzrT6sCMgza/1f9WZxqcTHL8/NW2cQ4Bpml4u69NVw8bm/ZM2LkCxDNDMlGW9EMTAgUTMpYVuxWBboZU7CYJxl5hVv1lyVH+B9n67ZCPhA/3uFnZxZZsp6See5Hx2BQEkrkeWJ/ZWnOlrWi+MQoE9FxXF3lux9Xj5inbzBzUYiOkbDNG0MYdPYWgHJlMN1fil2tRLx75ewMc+SJ2GxCKlX3FuIVq+v7DugYH5kk7ApRiMJIuSY1u2BAiVC30nnLqvlmRWBoxRCeZ02RC02FCEPAmY1oFY5zkkLsvaHE4cnkPXn8kMeg+5d1RDFm4X9c/0Da7fAWcFT0ksIiCA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KCDZex2c0gPFxPVRnWFQlDBr9kectynNYP5o0wUAOv8=; b=IPQdMjJCHhsB30K6BF4AvGOA+RlCpD+CjF9T0m7gW/1md3njaJ2TAcHOpTSS0IiMEFIj/MGizXcll4dKUCAqfJBuaYRvNoqxahsu6RYPyNlm4C0HxRxhzo62d8Uh8WkuEA2IzNXqD2O/EguE02GnGcbhbf1B5Wmk/+94JdPox5vIT1/EFTJ8JnFuBkcKxMyNfwNnAIoYldUo3R6WXIGx4D+1+1tNUomfAJPko/hNMTHa67rfmMLRvx7yz2GXnlP1akqHxx3qxWBYodPEba7+T9tlm8m/rxEB+PzgxbPFwGAcRFjSxSyKEJYtZRM29atSUo5nyHn/cvNUbCROrnh43g== Received: from AM7PR03MB6660.eurprd03.prod.outlook.com (2603:10a6:20b:1c1::22) by AM6PR03MB3768.eurprd03.prod.outlook.com (2603:10a6:209:37::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.16; Sun, 26 Sep 2021 06:40:48 +0000 Received: from AM7PR03MB6660.eurprd03.prod.outlook.com ([fe80::787b:2156:ca99:fe00]) by AM7PR03MB6660.eurprd03.prod.outlook.com ([fe80::787b:2156:ca99:fe00%3]) with mapi id 15.20.4544.021; Sun, 26 Sep 2021 06:40:48 +0000 From: Andreas Rheinhardt To: ffmpeg-devel@ffmpeg.org Date: Sun, 26 Sep 2021 08:40:26 +0200 Message-ID: X-Mailer: git-send-email 2.30.2 In-Reply-To: References: X-TMN: [u//N/HIG342FX+32WZOCZXG+IkBmSPmp] X-ClientProxiedBy: AM4PR0302CA0010.eurprd03.prod.outlook.com (2603:10a6:205:2::23) To AM7PR03MB6660.eurprd03.prod.outlook.com (2603:10a6:20b:1c1::22) X-Microsoft-Original-Message-ID: <20210926064027.344398-4-andreas.rheinhardt@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from sblaptop.fritz.box (188.192.142.38) by AM4PR0302CA0010.eurprd03.prod.outlook.com (2603:10a6:205:2::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.14 via Frontend Transport; Sun, 26 Sep 2021 06:40:48 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: fd27ad7f-f4db-4436-6222-08d980b8937b X-MS-Exchange-SLBlob-MailProps: S/btQ8cKWiTijo6adWu98WfLBOWxl+RvHsOWP6mDguZ44Q0LEHUrj/j8lY7ld9+DsadQEaaUJpPxCWdelxXZ0USETuvVHxsnK03TIw4n49TmemFFmPbFSWqe4JkSUE95XA9HEmrGyAHAPCBkfN94NHed8efVSxGe367CUl30ewGK1c1klmWTs8qyU/sy4Oa3ZL0uSBDV6zdHVn17G5tyTMTwkp/mrwtvataHuLH5/ARIANA804Ku5LRAk3c8R4mLSljtlBZnvrpCfWnKiBj/+MR3GE4+7q10AFky/MYo+A+IiQKi8wv0wK+USDqs9OdlWDgOjhdIzhu0WMO0YbtB94+K6ytaJyurBp2eQT9kdHBdueIoZIBTjLAGTw5uM42JH3n9YRNrgRjOc7gDgwVGkd4SxV2yTD4K05ME5o4anJs4/2G/D80vxtChZebhOpomqlzd33y5qRdOBCN42yOVw/flwRhP7IrHL1gBwKqQOJsV8uU0vKoZ3GwISvoEDcYAszYvqaQorQ29hEKC3/w6V815HLL0iIedvCdx/wOARBkE5ASJSkw07UU7MSDz/bqSv8YMj9Hvm2tUctgjp/7cIwGCGv4vQjL+JQgmvuLrnsFjO89BhqlZ9pXAW2kJgtH/xNW5lNKfgRVdiDt+nJm/cvcRsgLlIoMdYd6gM+r5tpAvf/DBD3K4INVK/gb+AyBpWvS/tMhXGyL9cEGYbQvuYf3aMvN+XVEaubEe8E2qn9cmKNJv3ja8aR9J+7OZnkL/fYl1+5gcjVE= X-MS-TrafficTypeDiagnostic: AM6PR03MB3768: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 19pXTrsC5bXfj4HR38Q98OH2jr6Y7CCSXWEJme1ZWVIxJe2C2iZG2mhmsbRN0Xvtntz3tWcb4Zm0bNBFWYpR99YeEQPQ0Prevu1Dnk48nBqFg3nYe1ekr39U3NnVJ3062I5g5Efc0X9jt2HJRW8efuCEUUHUHGi0Ryx4W5v7H1dmnS9D3rCxT7vgRsFKedz8r3RKJl88rwit+pSJdWZ61fAI6aLgEeatnak0z/AFKPyAnKLI0H/50odV0BKa3x3WqAV9Yby+waQAA3lS6k6iqJnLfS8lQA51I6XwHNx/IYUyu1QfilioF6tRSq9hHWpbMSQ3UAPoodCTO/1ECO0x/0I0nnWTVcLR+Qet1DahP5dX2vUe1buAGbsVmi18R6y/aMfJyubm0n7dGyt5mjwfKJbPsHQ4P+WQ1wiv5CYZm1vIBgwL5B6nHzw5eLkJIAXr X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: XLV+Ygyaw/FRqP/FkItOOg6/bMh86hfjmzX9awAcX4UGNnIE+J5/ZEmTjT2pWqJNSZOHqjjbuHXG03hVFIAmaoENEtUHX9L4jg9a2KdeAtH6M35J42yJ2bANJ8qr2cfGMuFKAZ2WCEvRAAmZaoTMBg== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fd27ad7f-f4db-4436-6222-08d980b8937b X-MS-Exchange-CrossTenant-AuthSource: AM7PR03MB6660.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Sep 2021 06:40:48.8759 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR03MB3768 Subject: [FFmpeg-devel] [PATCH 5/6] avutil/hwcontext_qsv: Fix leak of AVBuffer and AVBufferRef X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Andreas Rheinhardt Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: +h8WV7bZ0suR This av_buffer_create() does nothing but leak an AVBuffer and an AVBufferRef (except on allocation error). Fixes Coverity issue 1491393. Signed-off-by: Andreas Rheinhardt --- libavutil/hwcontext_qsv.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/libavutil/hwcontext_qsv.c b/libavutil/hwcontext_qsv.c index c18747f7eb..4ed50a31a0 100644 --- a/libavutil/hwcontext_qsv.c +++ b/libavutil/hwcontext_qsv.c @@ -235,8 +235,6 @@ static AVBufferRef *qsv_pool_alloc(void *opaque, size_t size) if (s->nb_surfaces_used < hwctx->nb_surfaces) { s->nb_surfaces_used++; - av_buffer_create((uint8_t*)(s->handle_pairs_internal + s->nb_surfaces_used - 1), - sizeof(*s->handle_pairs_internal), qsv_pool_release_dummy, NULL, 0); return av_buffer_create((uint8_t*)(s->surfaces_internal + s->nb_surfaces_used - 1), sizeof(*hwctx->surfaces), qsv_pool_release_dummy, NULL, 0); }