From patchwork Wed Sep 1 06:51:58 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andreas Rheinhardt X-Patchwork-Id: 29934 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6602:2a4a:0:0:0:0 with SMTP id k10csp278690iov; Tue, 31 Aug 2021 23:52:20 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzPKoAHJBCsvyhmany5mGPIgo4IJ+cLB+kp6hiJdk/ojwfizzZRxs2SqfRwxegSmtkUzSaK X-Received: by 2002:a17:906:11cc:: with SMTP id o12mr33524047eja.277.1630479139724; Tue, 31 Aug 2021 23:52:19 -0700 (PDT) Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id k19si17243177ejv.662.2021.08.31.23.52.18; Tue, 31 Aug 2021 23:52:19 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@outlook.com header.s=selector1 header.b=Z9GLdVdw; arc=fail (body hash mismatch); spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=outlook.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9969D689FB4; Wed, 1 Sep 2021 09:52:14 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from EUR02-HE1-obe.outbound.protection.outlook.com (unknown [40.92.68.70]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 1986A68003A for ; Wed, 1 Sep 2021 09:52:08 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hCtTiMwdN6VOvojF/gJtN7cNTzVc5Dj1l//94b1iDucXCH8TJ/Y5DxsF2T3oAYVFpdnmBeNVI+yrskzLt0CofCE8k0uE8QcOCn+bPnHiKpk+NK0E5+3VT1uixXQSBoxY/HO3fPOq45AEVRe1J2kJAd6LBq3rTTaNMl4WJ8BZOd/CtOHDd5qAlU1FCLO86fcz2iPig8raqxuu9GlKjvc5qfLaryjftDovRZci4NWXHiDwVqs3P/CYhD/ngQPQLKV/DIH/Satxma2LBeKj78xkeYVh7uMQpre2lcs107XLr25G4kP6ddzkLUA1uPGwNUClt+t3snzfIBRInQjQImQ52w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=N4O4ZpWaGgrbA6GZeZJ7ivH4eGimA6IUwoE9MPT+A9o=; b=S/Ln7B2XzgfP9WVATKnpFcps9mB8jvR9xcOz3S1fFuFr3Pem19n7dpk323InYAVSZT18/7wyAwOtwODP0wf8wgV/B/YJljCqTMDl5u/uiUut4pzayfpbkblSDdGfQD0rrCb9+eYMcu5blOcwJs3jx7s7jzOlybE9x58F3IT3fs859JUrLOJiRpfwcutQ53XeWEsHXfIcz2iTKK3as74LTg7LOCOjRkU02GOMOe0WdOpuL0+bY4GDGVDUQEI4f35L1bL4HBm5CgchCZwfv5ZacdBkN8pPoDg5nKHCaSNuoCB6VXMYkT9/w7Ri3obDRFrn8UTXOVHhYy1iwRG2z9CNBQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=N4O4ZpWaGgrbA6GZeZJ7ivH4eGimA6IUwoE9MPT+A9o=; b=Z9GLdVdwPqOss1Q0KBq7hVtDT/T1apBXI8QPtjRFkwUcxxmaNy4O9qsyHSHV+LYJ4P5t4WO68nF4yZXIBS3aKtW+ed9L7jLIa9i2EHgJpx6FiNid/VyTsO72CelkyIvXaP0c79f5PHTLl03A92+yIc+xs5KkxJVAF5kjCwYQI0TrwcC9t9XgQBcRriiYhKoSK/pXpYQriRK7hBJNQTJem9hHYTUcdgjXClNYGRiIG3cYMkeEqZzQkT9T/pA6ueuoDHbOcSGgz6DZbikiWF6KSeGs4aJPpTs9+jVTMVh6w2Ej9zJLDQ+moux1r3XhkDduNkwV/P1VfEBfi3sGdoZOwg== Received: from AM7PR03MB6660.eurprd03.prod.outlook.com (2603:10a6:20b:1c1::22) by AM7PR03MB6166.eurprd03.prod.outlook.com (2603:10a6:20b:142::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19; Wed, 1 Sep 2021 06:52:06 +0000 Received: from AM7PR03MB6660.eurprd03.prod.outlook.com ([fe80::f8b5:1ef2:89b2:f8c5]) by AM7PR03MB6660.eurprd03.prod.outlook.com ([fe80::f8b5:1ef2:89b2:f8c5%7]) with mapi id 15.20.4457.024; Wed, 1 Sep 2021 06:52:06 +0000 From: Andreas Rheinhardt To: ffmpeg-devel@ffmpeg.org Date: Wed, 1 Sep 2021 08:51:58 +0200 Message-ID: X-Mailer: git-send-email 2.30.2 X-TMN: [rpR3OoQMYS8eBOFYQK53WTJ7g9iANbyE] X-ClientProxiedBy: AM0PR02CA0026.eurprd02.prod.outlook.com (2603:10a6:208:3e::39) To AM7PR03MB6660.eurprd03.prod.outlook.com (2603:10a6:20b:1c1::22) X-Microsoft-Original-Message-ID: <20210901065159.1879761-1-andreas.rheinhardt@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from sblaptop.fritz.box (188.192.142.38) by AM0PR02CA0026.eurprd02.prod.outlook.com (2603:10a6:208:3e::39) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.21 via Frontend Transport; Wed, 1 Sep 2021 06:52:06 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 12d964b3-ccd5-4d06-f8a2-08d96d150309 X-MS-Exchange-SLBlob-MailProps: S/btQ8cKWiR3ENj9J/qOYLA9aMooTslq7Wl0NuqQPTNXxsrRit289hXcvGYEhzICpfSqo2zRUTM5BZb0N+BJRkGgeWhOUeYKMxBMCjjoBBK9UVhhiskRvsXTonKAerGR123w8/S2X7xhXug49IBjJ6dr/aJMIViLFCh6BuVk0tmy5QKGxNh1zT/HJe86cGiD3deK5rJhcHBwdwRHQ+kL8uE0G+FXfR9Ag3J4gmda6MVzmUgyl5/DlBhhHZN1d5ImPgelwhQywKP2Dd7Dm7FgGR0zq3OhwAfuKGexUwwhBj/b8r4yfoY8lVNtf3yGTBf0c1tRRVRRUmqBErknG+C7YfLH0Ij/ZQ9ENHQCRdbpq1nCXScuiwpdH+Phj5eEEViRv/nzG68StdHvcm3dKo6NVknoPUWiU1jljlzKuNEy1c/nGzawsM/QC7jnqyIOoy0G4CUNb7cYBUoi/vW+171d3lz+sBrd73AoAdHDHlaYMjvWPlgJg2H93DF+00xhyHAhA3Npkao4V2Hlw3SbfMLl36EauA5hS26ivd8/x5HBUrv2xFkKSRe/GGdLlEyO06JJZrQqJE9kXWSMFpSXjpir00NhEef2XLfQcmAzFc4b42AX/hGFCpFo5Kt4NmzcHHjAAUdOS7cM/rMpiBKrsUkYdzCoKtWulmWi6QQwFn5p8/K+O9mVdHOTlZvN8Cf7zqXZMRlvPDAdzNPvu+cbW9WhpJMtWCLWjowY+P0I3auuJaNtcQRa+ezwOqWe8xmOquj3bUIZ0adex18= X-MS-TrafficTypeDiagnostic: AM7PR03MB6166: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: geRHGLkuUnJz5D1+uwYX5sOtTmY+0XpvjhVcVZ4NEfrPWebNNK3xKo4OevyJoupJUQYtV4fd7H2zVJs4o6tcBRauJ4f4jmHWdR5dDVUx3BHVspV5nkc/FWq7p9aP9wM3rR+jVNsmMIuHPA4K8wIgTgeaQugRhpsdDbMqm/KskxBM5VUO7nqMjzl8nBuaBNs/IcoE7HJja2L8QZ7VsgrIYcEJ/vHtUvID8nVmFr/Zt0xWj/KtBCZGvr4IdLmhKgPcUU6jt/btjZk0Zup9LY/rKLyjkbsCB+hp9zjPSQFHpy4JmZinDQ0B2dfsgqrJmjzSi0Ajv0Ais7X8oAHqKBnwPIxjuHe8Xjn1r+RYbnJPT4VB8AmdMm9pz6bJYMxK2zNR6GnAyLJwln3r/E9fAzB7OjAWYAq9Ivldog4ARjlCMAj4C1waKHfLuCKUSVfxHH2m X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: tHLmNhyE5HIrQWyc5GCgPsCQfQWQvuyzMIGbYUGCqaFgRsHSIoWzGMUJbG/QxCTHraPZmz2cIKaSyRAtzzBJPVxJnR9mzgEpeCEFMn0lcle9mcbBszctq5/xePJSNnMp018PTyq0JTQrWOoUWzSBTg== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 12d964b3-ccd5-4d06-f8a2-08d96d150309 X-MS-Exchange-CrossTenant-AuthSource: AM7PR03MB6660.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Sep 2021 06:52:06.5866 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR03MB6166 Subject: [FFmpeg-devel] [PATCH 1/2] fftools/cmdutils: Don't access AV(In|Out)putformat.get_device_list X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Andreas Rheinhardt Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: 2jCJH2Lupu0z It is not part of the public API. Signed-off-by: Andreas Rheinhardt --- fftools/cmdutils.c | 16 ++-------------- 1 file changed, 2 insertions(+), 14 deletions(-) diff --git a/fftools/cmdutils.c b/fftools/cmdutils.c index 2dd035a7cf..69c39479f5 100644 --- a/fftools/cmdutils.c +++ b/fftools/cmdutils.c @@ -2234,14 +2234,8 @@ static int print_device_sources(const AVInputFormat *fmt, AVDictionary *opts) return AVERROR(EINVAL); printf("Auto-detected sources for %s:\n", fmt->name); - if (!fmt->get_device_list) { - ret = AVERROR(ENOSYS); - printf("Cannot list sources. Not implemented.\n"); - goto fail; - } - if ((ret = avdevice_list_input_sources(fmt, NULL, opts, &device_list)) < 0) { - printf("Cannot list sources.\n"); + printf("Cannot list sources: %s\n", av_err2str(ret)); goto fail; } @@ -2264,14 +2258,8 @@ static int print_device_sinks(const AVOutputFormat *fmt, AVDictionary *opts) return AVERROR(EINVAL); printf("Auto-detected sinks for %s:\n", fmt->name); - if (!fmt->get_device_list) { - ret = AVERROR(ENOSYS); - printf("Cannot list sinks. Not implemented.\n"); - goto fail; - } - if ((ret = avdevice_list_output_sinks(fmt, NULL, opts, &device_list)) < 0) { - printf("Cannot list sinks.\n"); + printf("Cannot list sinks: %s\n", av_err2str(ret)); goto fail; }