From patchwork Sun Nov 7 07:57:32 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andreas Rheinhardt X-Patchwork-Id: 31316 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a5e:dc01:0:0:0:0:0 with SMTP id b1csp2261199iok; Sun, 7 Nov 2021 00:57:51 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzg9ISZJK56kpxVO0Q9RvW2OEMGjvdnEu8Hw1hFN0+YU/rxSfaEL/naGRNVDcPzazY7e6aF X-Received: by 2002:a17:906:9b8d:: with SMTP id dd13mr75754980ejc.531.1636271871205; Sun, 07 Nov 2021 00:57:51 -0700 (PDT) Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id fj2si25664282ejc.474.2021.11.07.00.57.50; Sun, 07 Nov 2021 00:57:51 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@outlook.com header.s=selector1 header.b="tRuw/vT8"; arc=fail (body hash mismatch); spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=outlook.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9AB5168A7D4; Sun, 7 Nov 2021 09:57:48 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05olkn2033.outbound.protection.outlook.com [40.92.89.33]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 0228E68A5E7 for ; Sun, 7 Nov 2021 09:57:42 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GZbPbDeOJ8qTqXAJ6XMchfwVTWj49nQ4EoSOHumfaUUo3ZUl4VBhM6D82mlSMjN/3qH0TDOoIkPAStVkAZT2fUla+Ek8c/eXUQk2Wr1fN6Euk9k469rxdokoNy/dnbj9D/4L03KJF99olfhohE0g5siP8/4RqJxeCK/U1EoVIYTLEGHUMr3jLKozdNysO5Mwk+r5R9USazReYiQTSKu/+tCl8nNU8Ho2FuCh7ZL0OIubpXTNecaESCOnm3wwSW3rVA85gkicLeYSx6ahcruza8MVS/Kwk162mkDGZx/ICAHbY2ARpw+iwmX8YbMU3g6KGgWDZGWKDNQJGBJaRHLsnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Je23GhhUsLjrnm2ZtnNebUgHfRHWw7mF++sSC3R0H70=; b=nJrweqQ5HkO4WncSwHn8dDjM7S3j5adub57MfTlnQ4oEXByKa6zO2Vw6U87yCDHB1R0dhhvS8xV4xVhxTk3JpT0PNCOG7D0mkZGjospUmPGFM0KlePe/nlSLJ8BEQFXEEAGkVZCRxIPMiK4ZRvcbieuM4WsS35H6ymtifhsy2w+foqxinCZfITcaGofHrsuc3hdkqsu2hvn3GDwuK4+i8fx1dRfdDAdgTXoz/dFAkIEFBKPwlVNsx6Y7HZadUr7+EdAHoai1uVKSLJCe+JCGXQf4jXJtNyVOKEEA82+gKIQTbudOUpFrh6oplUMizAO1wvh3Gz1PDrlcXWV5zY04kg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Je23GhhUsLjrnm2ZtnNebUgHfRHWw7mF++sSC3R0H70=; b=tRuw/vT840qh/63mtS+ElKAwvA67xN2LiGy4YKYAI4DGJjj/rItwc3Ors7wZXelV0DB/0WX4IKefKi4iZbgxykUtmIoVw57K/Hd4bf5/7RnzXPbQH0HBMKRV6qc1tRYaRTo+G08Gk13vA9J8eJuh1+KeILITOfC5ZKLdsjBsVq5fVHPwPeQcUGqFmr7DX/TobDUUssxzyvMsKwfV8VWttN6F4Za65vxeIxuTKoEin+UyEunfWcFQYucXAo63MPQ7yeV1dCktV2GcIEejoo7K90XBX9yvP3O0/wfm1HUtiKktulcLyNjsfNkSOKOXs+ArMRj3JP7BaA/XnYxoy1aJ4Q== Received: from AM7PR03MB6660.eurprd03.prod.outlook.com (2603:10a6:20b:1c1::22) by AM6PR03MB3829.eurprd03.prod.outlook.com (2603:10a6:20b:21::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.13; Sun, 7 Nov 2021 07:57:40 +0000 Received: from AM7PR03MB6660.eurprd03.prod.outlook.com ([fe80::700f:d70b:3bb8:4d51]) by AM7PR03MB6660.eurprd03.prod.outlook.com ([fe80::700f:d70b:3bb8:4d51%8]) with mapi id 15.20.4669.015; Sun, 7 Nov 2021 07:57:40 +0000 From: Andreas Rheinhardt To: ffmpeg-devel@ffmpeg.org Date: Sun, 7 Nov 2021 08:57:32 +0100 Message-ID: X-Mailer: git-send-email 2.30.2 X-TMN: [GLnsT4Ek1et+DMyUYIw+KMgnOJ8x6hVq] X-ClientProxiedBy: AM0PR05CA0074.eurprd05.prod.outlook.com (2603:10a6:208:136::14) To AM7PR03MB6660.eurprd03.prod.outlook.com (2603:10a6:20b:1c1::22) X-Microsoft-Original-Message-ID: <20211107075732.116848-1-andreas.rheinhardt@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from sblaptop.fritz.box (188.193.171.90) by AM0PR05CA0074.eurprd05.prod.outlook.com (2603:10a6:208:136::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.11 via Frontend Transport; Sun, 7 Nov 2021 07:57:39 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a32def8b-68de-41f6-ae14-08d9a1c44563 X-MS-Exchange-SLBlob-MailProps: dEG5jEBie8kwA6Kiguh6vxgZF+CnD+4bbTC2SheOC57OBh+qCM9jOIi+SLRsn1qmSK8e9v7MK0ZHHgbqIcPkONv9tZiWJ9Z8AK+K6/JLEKUx1erVnqFGJ/VzVHlX/XPaH92oX0+CmN/BoWespabhiX3fozxIPv9NQ99fWEorBhLmoGw9G3CkSGTzOuq1v2CW//2bqdIJIH0K4OYIeg9K1TEfEBpz92nvPB/Y8OcTdhRe7amaq+6wfUfkqmvUgxDfN0+/wK4TvP7Pw8Gmt2pOGSPN4f5AcpG+UqoawAlV+OLOL4y9e0+dJMEgcEtIgI8XYyu0WXHDBoKHKFhpy8A0ZSdP+gZcogrXYsrrNRNMBeNakt/gu4RifDXWAcxJsimLGS3/7uUJTgZLGEQiz3UyBTT9G4CkOlUi8h3XyX/YlRYUzDXtnTT+xwzOOzr60jBwrLlIwdlb52k/xuoWrsMxBkVV321w6pldhymUubWCKCq+888GXfjx1IKO0FBs8pOGCe8gZU8YgZ4oG1H3h7eOUqvWhQbAjQiPSa5xroILSwmCKtqGzsn4rguIGxvOSEsR2w1FHtt041KBwipMW0P49DUsyY+dtB4leGhvZ3VApDbK2orMHuIOd+SPKQsCcaBuRbNExwVz2WmSVPm/906wR3QCFGw4ZnGuWo6oHn69yCXAwmlPGCSPUg== X-MS-TrafficTypeDiagnostic: AM6PR03MB3829: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: f1qwFatjZXUYUBaLI4mxKjMGqUWm5fDKKCBqtfptJl7K46Q65dc2hDBCZZXmtBJUKwL6u/2bIJviSbrc6ypTGZl6qQqi55V/E+2KoW7eNRnZGq4CfH47KoHgY5f3jlOTWpZVKpcAYotRszsoSTuWCdzS7QulDVLRGV5mab90Ey7qrscV3keCmazcHu7/am2BO18hwq2ZJbZp9Wg0Rj3s5Gl5ZbvgVqJvaE119uG5m80FlNVUmCQh4pK2M/sfA2gDtGtrrg/jLgFvOMze8sU36ZXwPKUZBP8qBUKFbMCCVx49yy36phsNHkq4zyrlHqGqmDQzURrac0PYfq8qnpa3qxp9FM9bEPb7zMEENUHpt5hv5SPmiYB4AadLW+7VFRNFabnGHXUPK9joJsosBcUs3iej9BCkDZ2rwiIzN6xWA/eTlpmy6nddkF89MYIvHk646lH8Ay/wuNPjAsd+9jTnburzf+xBMJVZLUK2nVC9RaalDD6sxcrO+BP//Ww4JYg+rOEhV5ObSH8DDes4v7fzebVu+2HDmA7ePAzir/1bN8k= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: +SsXwDGKpWP3KUtYcmlfbUXYlxE2l74O1kSGlNadr2ZP2yZlJsqJKg/SiLOXWr/Dmslg2zjz+2AKYeAWBtnpBL09PZroDxS6RwXWv5n2/YRW9Q9kfBlAqrmeRN/BccOFcEtXIKddWEOTApzmSMUAaauxLQjTb4b4YoWnyc28hVvNRO5VYqvvTP4lM5aPIwOt4oCYgODVa7rG08cIuwblRABTxLGPyZNwYDgT2yYhTv712qnulPX0JrhOf3wtIY1ll4Zsh9I5oWtm+cQlSngit7dCji1VmRzYFnneClBlSIdDMWy7+YYEFRZItWZdcc4eSiH1yxXUSHZllA2Oy2rp+aFDgVATX7szymjg+k89FR7vdxEmNgKs4K2xR76WO4RkFQ91Lb7hK7siakYggExdYrv/+2dmaU4aOcrJ7uYP4rbgIosy0DMyhqsYALVUdTiVIHCgJNHqMYa0kPOFWtDcfsTERAhsxxY52TlLv/G/ChllOTS1dSGbXHZBacK/OwyY4lbLx0IGyXioaLIxTLiRuxwoaEJBREAwVkWIxUMDC3GNBmSMNVm8oj4OXMeOJmEUUTaEnRp5d/COr+0fZdFZhNbcCn1EMQZopLhZjeVlMQr7vpOfbRkBO/cgCdCxnHIeeScpjnc0TzP3bYRpHwr/j1hKWOwi7obK/rKvDe0ugdqNRIk1zjPRIABV/pBNUnzA3OKSJ/gLazVBtRTCoXVIMw== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a32def8b-68de-41f6-ae14-08d9a1c44563 X-MS-Exchange-CrossTenant-AuthSource: AM7PR03MB6660.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Nov 2021 07:57:40.1489 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR03MB3829 Subject: [FFmpeg-devel] [PATCH] avcodec/speexdec: Remove dead code X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Andreas Rheinhardt Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: 47ZZahS0237N Fixes Coverity issue #1492840. Signed-off-by: Andreas Rheinhardt --- libavcodec/speexdec.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/libavcodec/speexdec.c b/libavcodec/speexdec.c index 4c50f54f27..90e95f0785 100644 --- a/libavcodec/speexdec.c +++ b/libavcodec/speexdec.c @@ -1221,7 +1221,7 @@ static int sb_decode(AVCodecContext *avctx, void *ptr_st, float low_pi_gain[NB_NB_SUBFRAMES]; float low_exc_rms[NB_NB_SUBFRAMES]; float interp_qlsp[NB_ORDER]; - int ret, wideband, dtx = 0; + int ret, wideband; float *low_innov_alias; float qlsp[NB_ORDER]; float ak[NB_ORDER]; @@ -1254,11 +1254,6 @@ static int sb_decode(AVCodecContext *avctx, void *ptr_st, /* If null mode (no transmission), just set a couple things to zero */ if (st->submodes[st->submodeID] == NULL) { - if (dtx) { - //sb_decode_lost(st, out, 1); - return 0; - } - for (int i = 0; i < st->frame_size; i++) out[st->frame_size + i] = 1e-15f;