diff mbox series

[FFmpeg-devel,04/10] fftools/cmdutils: Don't report AV_CODEC_CAP_TRUNCATED after next bump

Message ID AM7PR03MB6660A60A8C05C7D70159AB488FD99@AM7PR03MB6660.eurprd03.prod.outlook.com
State Changes Requested
Headers show
Series [FFmpeg-devel,01/10] avcodec/mpegvideo: Move startcodes to mpeg12.h | expand

Checks

Context Check Description
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished
andriy/make_ppc success Make finished
andriy/make_fate_ppc success Make fate finished

Commit Message

Andreas Rheinhardt Sept. 13, 2021, 1:53 p.m. UTC 
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
---
Could also be removed now.

 fftools/cmdutils.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

James Almer Sept. 13, 2021, 2:08 p.m. UTC | #1 
On 9/13/2021 10:53 AM, Andreas Rheinhardt wrote:
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
> ---
> Could also be removed now.
> 
>   fftools/cmdutils.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/fftools/cmdutils.c b/fftools/cmdutils.c
> index ac172dbd65..6a61f7a5e4 100644
> --- a/fftools/cmdutils.c
> +++ b/fftools/cmdutils.c
> @@ -1399,8 +1399,10 @@ static void print_codec(const AVCodec *c)
>           printf("horizband ");
>       if (c->capabilities & AV_CODEC_CAP_DR1)
>           printf("dr1 ");
> +#if LIBAVCODEC_VERSION_MAJOR < 60

If for whatever reason the capability deprecation is postponed, this 
check will no longer be valid.

Since FF_API_* defines should not be used outside their libraries, i 
think it'd be better to just remove this now like you suggested above.

>       if (c->capabilities & AV_CODEC_CAP_TRUNCATED)
>           printf("trunc ");
> +#endif
>       if (c->capabilities & AV_CODEC_CAP_DELAY)
>           printf("delay ");
>       if (c->capabilities & AV_CODEC_CAP_SMALL_LAST_FRAME)
>
diff mbox series

Patch

diff --git a/fftools/cmdutils.c b/fftools/cmdutils.c
index ac172dbd65..6a61f7a5e4 100644
--- a/fftools/cmdutils.c
+++ b/fftools/cmdutils.c
@@ -1399,8 +1399,10 @@  static void print_codec(const AVCodec *c)
         printf("horizband ");
     if (c->capabilities & AV_CODEC_CAP_DR1)
         printf("dr1 ");
+#if LIBAVCODEC_VERSION_MAJOR < 60
     if (c->capabilities & AV_CODEC_CAP_TRUNCATED)
         printf("trunc ");
+#endif
     if (c->capabilities & AV_CODEC_CAP_DELAY)
         printf("delay ");
     if (c->capabilities & AV_CODEC_CAP_SMALL_LAST_FRAME)