diff mbox series

[FFmpeg-devel] avfilter/swapuv: Remove AVClass for filter without options

Message ID AM7PR03MB6660B8A9C93850EE95AC2F3B8FEE9@AM7PR03MB6660.eurprd03.prod.outlook.com
State Superseded
Headers show
Series [FFmpeg-devel] avfilter/swapuv: Remove AVClass for filter without options | expand

Checks

Context Check Description
andriy/x86_make success Make finished
andriy/x86_make_fate success Make fate finished
andriy/PPC64_make success Make finished
andriy/PPC64_make_fate success Make fate finished

Commit Message

Andreas Rheinhardt Aug. 1, 2021, 7:14 a.m. UTC
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
---
 libavfilter/vf_swapuv.c | 14 --------------
 1 file changed, 14 deletions(-)

Comments

Paul B Mahol Aug. 1, 2021, 7:20 a.m. UTC | #1
NACK

breaks timeline support

On Sun, Aug 1, 2021 at 9:15 AM Andreas Rheinhardt <
andreas.rheinhardt@outlook.com> wrote:

> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
> ---
>  libavfilter/vf_swapuv.c | 14 --------------
>  1 file changed, 14 deletions(-)
>
> diff --git a/libavfilter/vf_swapuv.c b/libavfilter/vf_swapuv.c
> index 34868eb0c9..29635b2003 100644
> --- a/libavfilter/vf_swapuv.c
> +++ b/libavfilter/vf_swapuv.c
> @@ -23,24 +23,12 @@
>   * swap UV filter
>   */
>
> -#include "libavutil/opt.h"
>  #include "libavutil/pixdesc.h"
> -#include "libavutil/version.h"
>  #include "avfilter.h"
>  #include "formats.h"
>  #include "internal.h"
>  #include "video.h"
>
> -typedef struct SwapUVContext {
> -    const AVClass *class;
> -} SwapUVContext;
> -
> -static const AVOption swapuv_options[] = {
> -    { NULL }
> -};
> -
> -AVFILTER_DEFINE_CLASS(swapuv);
> -
>  static void do_swap(AVFrame *frame)
>  {
>      FFSWAP(uint8_t*,     frame->data[1],     frame->data[2]);
> @@ -115,8 +103,6 @@ const AVFilter ff_vf_swapuv = {
>      .name          = "swapuv",
>      .description   = NULL_IF_CONFIG_SMALL("Swap U and V components."),
>      .query_formats = query_formats,
> -    .priv_size     = sizeof(SwapUVContext),
> -    .priv_class    = &swapuv_class,
>      .inputs        = swapuv_inputs,
>      .outputs       = swapuv_outputs,
>      .flags         = AVFILTER_FLAG_SUPPORT_TIMELINE_GENERIC,
> --
> 2.30.2
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
diff mbox series

Patch

diff --git a/libavfilter/vf_swapuv.c b/libavfilter/vf_swapuv.c
index 34868eb0c9..29635b2003 100644
--- a/libavfilter/vf_swapuv.c
+++ b/libavfilter/vf_swapuv.c
@@ -23,24 +23,12 @@ 
  * swap UV filter
  */
 
-#include "libavutil/opt.h"
 #include "libavutil/pixdesc.h"
-#include "libavutil/version.h"
 #include "avfilter.h"
 #include "formats.h"
 #include "internal.h"
 #include "video.h"
 
-typedef struct SwapUVContext {
-    const AVClass *class;
-} SwapUVContext;
-
-static const AVOption swapuv_options[] = {
-    { NULL }
-};
-
-AVFILTER_DEFINE_CLASS(swapuv);
-
 static void do_swap(AVFrame *frame)
 {
     FFSWAP(uint8_t*,     frame->data[1],     frame->data[2]);
@@ -115,8 +103,6 @@  const AVFilter ff_vf_swapuv = {
     .name          = "swapuv",
     .description   = NULL_IF_CONFIG_SMALL("Swap U and V components."),
     .query_formats = query_formats,
-    .priv_size     = sizeof(SwapUVContext),
-    .priv_class    = &swapuv_class,
     .inputs        = swapuv_inputs,
     .outputs       = swapuv_outputs,
     .flags         = AVFILTER_FLAG_SUPPORT_TIMELINE_GENERIC,