From patchwork Thu Nov 18 09:13:56 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andreas Rheinhardt X-Patchwork-Id: 31484 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a6b:d206:0:0:0:0:0 with SMTP id q6csp503625iob; Thu, 18 Nov 2021 01:14:27 -0800 (PST) X-Google-Smtp-Source: ABdhPJxTUEbSUglAE34ydEcmIXtdxAazDUdlZLVv6VYNEJ0pUUU1IGCEDGPNZ2wEdotqVKiSOtKV X-Received: by 2002:a05:6402:486:: with SMTP id k6mr9030361edv.315.1637226867103; Thu, 18 Nov 2021 01:14:27 -0800 (PST) Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id z2si6008897edb.580.2021.11.18.01.14.26; Thu, 18 Nov 2021 01:14:27 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@outlook.com header.s=selector1 header.b=aADDVSFu; arc=fail (body hash mismatch); spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=outlook.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 68DDC68AF33; Thu, 18 Nov 2021 11:14:18 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05olkn2057.outbound.protection.outlook.com [40.92.90.57]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A19DC68AECA for ; Thu, 18 Nov 2021 11:14:11 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aE1BHb0+vSZsXFx6xn8e9cGAxCczTIHfUE8Rb1SZ1OhT7oJssY2B9D1gDEHgBCAggWkqw8a8EPYU+OfJXWKTQzQyCuoRtwUMsg1edFFvkBU/7QDuOfDj7z6SbDHBAP3GOcaYzSMUXowjdYoBntq0A5A+qSweq4iWXJFRWARjZcjfEnpg+ODCfaEA3nw6G2xeMW173D45FlZ6NA3NjTSJUWvHuPdtwkhY07E1RGu9a9bkvkNOtQhEuwn26Tqe1xZiMCy7VBqF4cINvFq2h5iDsA6lQ0R1PLS/GydTqXOW1F4mzyh2Quu2y9+riTilt8hk1+fjtYtrD/6zj45kQUF69g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QEJY2MxvGOvU2y+PcTBMCVR6Ezj7OgN1HRG/Wuy12Zo=; b=mUFCgle+w9OXPUnhFp0s+/IdeHkMZcwmqw6G39P1/BVd4HC9nLGUNSdgELPoQjzKW+HQFaygy4roDt+apjPs4gRs1xQSunN7TNX1d6feiqCMNdMWPheE/WvN/83PtzNmQQRctp8O4z3pp6hm6qfuUNzMjLZm0PXyHXqygx9CSTbAK0fgKgjbcw026FIXC9x2tIap8SkF6RAurZUFOJZOk97KUuDKyJ+mY2jkzMj8PBU3fMHFUyR/qBj3qSqu93LX9nmZA3LQ+sW/aFWRy1bd+7+hgnyicwjgroId+YN8joXrGDDK4ShBFIZBaFU0Lp8gih04vsAqOkRNgB3Nm96IMQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QEJY2MxvGOvU2y+PcTBMCVR6Ezj7OgN1HRG/Wuy12Zo=; b=aADDVSFuiISlFWhfe7vnuSr84QWMkWgVhdpywch4b10wboMhMlzlVcLpP0iMeKufgbbkhrMwB6easyFp8mKjsl8PvkWqeD7V8/bRY2U88xVOabtumdZr2NAxqgJK18FIhyb4utH8P5ITc0WuE9w4fAO3aBiKYZVq/APhmCgWBfgizbjenzLWw22VrrUFyA4mjPjISg5uS8+gWWkCss773ZfRIr1Lld/k/FiSOd/bZSi3MkkOjTv/dqrC1ag5ocBmcQiz16keFka+9fOlpYNqHlcWxAWAcBNvB2TJ+QUGKdy+anZvLCXvTXU+DoDitTjYrKOIiGzLQQbYqBsyoRByFg== Received: from AM7PR03MB6660.eurprd03.prod.outlook.com (2603:10a6:20b:1c1::22) by AM6PR03MB3862.eurprd03.prod.outlook.com (2603:10a6:20b:17::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4690.26; Thu, 18 Nov 2021 09:14:10 +0000 Received: from AM7PR03MB6660.eurprd03.prod.outlook.com ([fe80::700f:d70b:3bb8:4d51]) by AM7PR03MB6660.eurprd03.prod.outlook.com ([fe80::700f:d70b:3bb8:4d51%9]) with mapi id 15.20.4713.021; Thu, 18 Nov 2021 09:14:10 +0000 From: Andreas Rheinhardt To: ffmpeg-devel@ffmpeg.org Date: Thu, 18 Nov 2021 10:13:56 +0100 Message-ID: X-Mailer: git-send-email 2.30.2 In-Reply-To: References: X-TMN: [pE+TcLOoPWhngFEByfo4+e8SqQHAaDUw] X-ClientProxiedBy: AM4PR0302CA0004.eurprd03.prod.outlook.com (2603:10a6:205:2::17) To AM7PR03MB6660.eurprd03.prod.outlook.com (2603:10a6:20b:1c1::22) X-Microsoft-Original-Message-ID: <20211118091357.223580-2-andreas.rheinhardt@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from sblaptop.fritz.box (188.192.137.12) by AM4PR0302CA0004.eurprd03.prod.outlook.com (2603:10a6:205:2::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.19 via Frontend Transport; Thu, 18 Nov 2021 09:14:10 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: df2a9f8b-a623-4040-3c31-08d9aa73c815 X-MS-Exchange-SLBlob-MailProps: gjx25WM8ZNVakJMqjhoref1ozWknkbK7lZEMteS7uBALGUjX79hMpxcYJ7hHEN0uQcHhiiRe19zGMaezx69IdRUTbxpLLNd2PwVfQBMAMtzbasEe3RYEQ5+WWoyMMcjsAZEe6B7ykSBRwGxE13tdMyVYY1XeoYc+4YRAMqFzdAXfz/IkkO+ziTuAJCqOi8+G1PsVfnjNss34CRvI+uCqdB741mJqHnx+PTjOTzlvTC5kqSC0WhCIljg8BNFifxEmb+VDFLN+XBRMNxe1jw7vjMxusBHtH+YJWQHLl9pEPQWOcpCbup2cC65rRTjPWpWjNYBQFFU4Ghy6zaCUrm0J4OBjsQyO4q1IK9d/WdVkFj5V18GA1FpYtcWSRKwg6ih5/KPBSZr2PPZmIy6pEIL/7+c1bIIFSQ+Bh/Z/4NbfxD2OEsgguCgG5VgGevSC4fOB8VYkAEKeFipliKMZwdzah/iD+dnSSxx+dtmV3bagb24Vtdf5GeKQSueaVXwxbbKb3CrxEis5OG+wbnLgxpzhEN+SqQSH4PMvkNTD8W6KtYjSt5zp+SBeG7VwTXVVqcJRE6Vnta34kiPES5m1kqrv3gbVZFLcbHAuxpCy9z2c/Sq32Xd0Osf1qQ3YEFv/APKrWi6SA8EjMr48+6NBVi5S/i7Ul/QOm0+2lQT/T4yJLG98zE4O/EQcNiJe1WqTh3S/Fe0fjRh2cPVcO4NETGqvc6g6vBMlJhH5f+zZg6guHqs= X-MS-TrafficTypeDiagnostic: AM6PR03MB3862: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: n4dnU8USk6IzAL4Qh1+sEeLkQHn5cPP3+TmIdPMTcshGme4a2KMoAOGmq4VxlYNiKaxTN7l37KGZo3Cz7BetC8d1R3kMdq5QiWRGjuUeCBlTZdR4S0cHmTmkdipdu7qYmON6qNwSzE9TM9pSmr2IAg380QsVb19M49DfTOzRaedQeSR4IlN/uIRHsmIZ8WBhDlsK2g+MQa+mzLTzWOTihXrUUwj7lF9uHFU5MJQM0EmKxk48nCZ1L9CShBUlvLhG+wLIkd8/EyXBsDELHa+kmLxSwkzNPc6hzi2f0pJPTV9MPnVCpBnSBKKy36F8ObVewE8bSyi45g52SSzk5HIQMFF0VsvQH7D6ffNtHstfoHLeaxm0YPvtmLmlz7sBaKOmCGw7Adpql9IKmr99rdwPtiaFICqR2C47gZdue3s4/3NV1pFjQ9919RtD2kb4W1m6f10yRnkeJNR5YkVMcWL7iJlr0RgBdMwSwl5E+Jv5XqvaYN+buZD210/HfZMr4x9K3W0FvtQbiuCJeonp+e2q5Q8XpOOiyL72dDYlaqN4YT0= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: gBzJgh07baoAqRBKIqBXulUlMxfOciiXCF71mY7Lx3BfzSk5Z98neoGXeLKlhsfgqp1VFvt/tHnSIduP7K9xynYLjGdKywcgrgxn9N3qq1G0G2uyO1o4Fz2+1LAwTAPzyZLG5jKMW1TzM/cSjhgIzVJnoU/3reI/y7TGO0MuAymzB5muMBhhQVpRt67lSQ+9kn7duCoczuWYyiemYcdjksKRkeh5QfIHnB8A2HmRoRCF8ZUwYOsLKrs1VVDOa5aJY3MZbJ20JXVpkUQAZcjlKo/pf9PkU1vEPisQEfh7CmpogthynAEnoSd8NNl+DbZ1tmmHjsenVfn1v2kscml52re86ICcFvNR2Vgyllk37WD7m/dIhLyNusDYqyvsCFYbpPrjXZEDp60pTPyaGoxHR7mzczwyY1CtJlvKDbwVZoqtD8eIO1DwMYMGPd3Yg8jIVRPkRkHgrAJzF0qh4pSZdKqAoCHlBC8THM4dxuq4icRn+9VF2TR/+q2/1Nk7jW6BtpuG150ATTIURXJ7bGVnb/c9N8Gf+PbE1USr9e3wOsGDEZXGEkqyNV9dLrcij177InveY6hL9yD1BR7zX2FpPd0UWrViMvcoL6K7EoGt85zwbFqaCtLzZu9ju+9Z/ZjwsZLfqwyVXHBwJHT9o6bzWBLkxIQOPHqiMy+ysQi2hTlFuMo1U8NJoiMpAyGgMTGk17cFMFvzTlysdf4QgN4aAw== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: df2a9f8b-a623-4040-3c31-08d9aa73c815 X-MS-Exchange-CrossTenant-AuthSource: AM7PR03MB6660.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Nov 2021 09:14:10.6582 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR03MB3862 Subject: [FFmpeg-devel] [PATCH 3/4] avfilter/vf_huesaturation: Remove dead store X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Andreas Rheinhardt Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: pzE2J2si9ID+ Fixes Coverity issue #1493345. Signed-off-by: Andreas Rheinhardt --- The x = y also looks strange. Why does the parameter x exist at all if it is immediately overwritten in the function? libavfilter/vf_huesaturation.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavfilter/vf_huesaturation.c b/libavfilter/vf_huesaturation.c index af7ea33b9e..d4e3fea1c5 100644 --- a/libavfilter/vf_huesaturation.c +++ b/libavfilter/vf_huesaturation.c @@ -297,7 +297,6 @@ static void transform_point(float matrix[4][4], float *tx, float *ty, float *tz) { x = y; - *tx = x; *tx = x * matrix[0][0] + y * matrix[1][0] + z * matrix[2][0] + matrix[3][0]; *ty = x * matrix[0][1] + y * matrix[1][1] + z * matrix[2][1] + matrix[3][1]; *tz = x * matrix[0][2] + y * matrix[1][2] + z * matrix[2][2] + matrix[3][2];