From patchwork Sun Aug 1 21:15:33 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andreas Rheinhardt X-Patchwork-Id: 29176 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a6b:6c0f:0:0:0:0:0 with SMTP id a15csp1050368ioh; Sun, 1 Aug 2021 14:16:31 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy3JNKZGQux4oKo2er2VWOkEIOor19u3zDtQ0igInsNLVePXG3prLQbAQwYGVL32tiVi5qG X-Received: by 2002:a17:907:2ce7:: with SMTP id hz7mr5924709ejc.35.1627852591034; Sun, 01 Aug 2021 14:16:31 -0700 (PDT) Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id s16si7962077edq.234.2021.08.01.14.16.30; Sun, 01 Aug 2021 14:16:31 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@outlook.com header.s=selector1 header.b=LXsF6RyF; arc=fail (body hash mismatch); spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=outlook.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id A3D6468A76A; Mon, 2 Aug 2021 00:16:07 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05olkn2039.outbound.protection.outlook.com [40.92.90.39]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id C4B5868A74F for ; Mon, 2 Aug 2021 00:16:04 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aOvPXI7AMqSh1AVdTJWQ3iL3krYMvNmgnGwIh64WgRQs52eH+HCNbi5JFcnu02SLGELXoZsbnzuW0lHzvzwLIVOVVMxNWdBQ53Ns9sQmqbs3Zk3dkpa82X4j9IeP2f9EajvIHztpJ5LuijHKSLuFqZb7nsKd0wjYeKblLG7roFJNVT71sDQNFRyGh+Bojqffr26nErupmSFr0+/CPM86uwT92UogZAjGRbEDCe3JrW4F49noez0mUF0eplaIBC1w5Tw8RIbDeiUTzGt0+3X4YI8MWG5vfd3+wRx+dYBJBm6EOTH9E5p+QawBLIoqH+X3FS0O/Fh0t1c92H8vNu+9kA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Rmd0Xyf9YZiJHoPx4N6jyyDPA/ySReuQJzbN4g6xhIQ=; b=L75ST5Frxn/lxhK0AIuFXDYCzB9pUXuNYNw6s7LhCIiqGGo2UxBioPJ/EOuviG2Bw2HIxXUuS08MaxR0/5j/bnM53E1E3RASFkYITwpOll1WXWglZizV1qOlhp+YBCz+8PYkKPkUdZBBYMJytobnbSBhAm8oE7TuFhz/2HfjsX3nIhzqkluJjlytumkxmP09hohKmFRrEyR6ZwcZoVEfAOXu+jAM5lfNgA+5xfx8h/H/uyHBsI0WETptyzSrRfXTH6fCtPQjsNzk0AcBHnXdax+nVpPe3AQ2HRyA7jhaFNjRXxquOZDQBX1dNijp0SjIUtawgmLg5epKQHamiw6jcw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Rmd0Xyf9YZiJHoPx4N6jyyDPA/ySReuQJzbN4g6xhIQ=; b=LXsF6RyFSNuZTxJ91fLyC3/eON0bbZ3qY7dQd3yPPvBBmzgA6oREFgXcKeQBIz304miHx2854XPkYxLhOyEYNdgd4an3p3AR19zAX4+nfXCNtDyGmDDBiaCMylNXsWTs7M0VdUe+mjRreVkfNB9kZ8QtqZxQ5c6FAWuLtcpRLTxhaB971csPiCbnVZ7pZLO7XpBYx/jU5KLGteFVgbCpVIGyPkFVSBF5+r8S4ECwwRe+6xCDkl8it5jZ36j3S2ZtO+cMkZaiN0QCvqU1RYYgG5prS3flXVWy7tTTpoC35Ne8tpC+leMuIzS1pPXOFpuHpQHK0YieqPo7IYZO3yhwbw== Received: from AM7PR03MB6660.eurprd03.prod.outlook.com (2603:10a6:20b:1c1::22) by AS8PR03MB7301.eurprd03.prod.outlook.com (2603:10a6:20b:2eb::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4373.21; Sun, 1 Aug 2021 21:15:50 +0000 Received: from AM7PR03MB6660.eurprd03.prod.outlook.com ([fe80::c9b2:14f8:d555:6f2d]) by AM7PR03MB6660.eurprd03.prod.outlook.com ([fe80::c9b2:14f8:d555:6f2d%8]) with mapi id 15.20.4373.026; Sun, 1 Aug 2021 21:15:50 +0000 From: Andreas Rheinhardt To: ffmpeg-devel@ffmpeg.org Date: Sun, 1 Aug 2021 23:15:33 +0200 Message-ID: X-Mailer: git-send-email 2.30.2 In-Reply-To: References: X-TMN: [nNAlnNgmsyeb/lk9oiCEhP6l2kVQLTw3] X-ClientProxiedBy: AM4PR0902CA0022.eurprd09.prod.outlook.com (2603:10a6:200:9b::32) To AM7PR03MB6660.eurprd03.prod.outlook.com (2603:10a6:20b:1c1::22) X-Microsoft-Original-Message-ID: <20210801211533.1005556-5-andreas.rheinhardt@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from sblaptop.fritz.box (188.192.94.230) by AM4PR0902CA0022.eurprd09.prod.outlook.com (2603:10a6:200:9b::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4373.18 via Frontend Transport; Sun, 1 Aug 2021 21:15:50 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 84d864ba-6a4f-4411-212d-08d9553189c6 X-MS-Exchange-SLBlob-MailProps: gjx25WM8ZNWHNkBoEz0Th5/wkvf3BA3yoQ4ZvDohVSgUyFn87vzp21lE4iDsV+DDglMkMbI2C6JDot2bSy1MFzi+9BgG4EwUEzZKcv644aQ93VtZGFKIAyXPuDW6/QWCRoaK4GnXMeRMdi1dP2gQxvQ/5CvBc12JoLBeFk4+A17tnCYfMKmmjPUEsw+bbvfrsH8YO8I+VRc/y3RserP6sxEv1p7KyOM5kTb+ytZLUBAV18zOnjlUTld3MtZ8MQpDsBqedjlLnUZLZcalosZ28h45bFThT3YI8sLAI4F9rMTsG+G5L+/rZw7UMn+GR7qX1K7c8YQ2ee8JCwUeAZ8Fr52gG8vnIpnz+0QByden9w3ymGA9ds8vQRuvN//UDc26Ee4p1P9/HBxS2u9tSv3ErxAkxzYWZmicSWs7jJZ1S77p7VCxZ1+2eR7+jhMPyZYT3N+MzfDPqaJYv5QI29JOiA9cNR4STOr/tmi6luXFQt+fW5lRdhxSH/u1bCnXUltOvc3lzrcubKoxjZxnVso1khsh4m5XdinWSrO8Ga2XJ2Iw3RSe8rIZr56HI36jB85U+juHzHSm8GbxuSvOA/XFLY74Zan6y9+57zeZPqXU34xW2RYz4N22Q1Le7Q4y/SNmkXCGiT6PEvJTKf17AueaMtO9NTPEFeFtdHxvZY9971vIUSH8mHzrllGT3Hc9+ow1GVRdFC2RclHJh1L8zesMkaD55Ihu7LbvAmV/5Aa5vB8= X-MS-TrafficTypeDiagnostic: AS8PR03MB7301: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: pCzRB1pJHm3LNQqL5W7nbHqfpjcv+xI1sPzzNkhsRx8cu5nCflHZJ9XaUurr3/0ZovHINUUBepfEzdtQLBVAsmECBmX8vosXMdR88QdQG36F8fyfmr2yIEhW3QUkLlypeOqSAIB3aOAaND8XwGZGPbuSqEPezjlcIivgODc3D2WkcNj6YlTY0qPAx8sssb0OwGFR73vYzPoukspUWGKFwhCpmvA57Z9SvMKKXlkD9sIyHCxG+6XrhZXc1X5/NgHQofcVI0Hof7h4Wls9aXFZR+oatuLqNIUpE7v9zHY4rbEP88Wffb5V6Y3RuZmegS97R9skDS24HY+i0Vu8kEqsflzUOjT2savW/+jv1lJH8jcOnANWNcekBEskFmcL5sq9NRupqNj9yisGzBvYwyV/IeFi6SNV/gQtZIvYoejBVpP5S1W1Sq964+ZRsxGwuOzi X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: sypyKP1zcnR9oUwPLylATynQXfbY5kWSOHuLRmPWy5D+LELlpU2bBQbLgPPOFnRnXEHXIWdzUHaIxBNhlp1pYQ93MKWj6Naw13eJOAxu3/J1GI/z/x24KsbsbdR9jwabgL06GDH2L2gXZS1OqC27VQ== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 84d864ba-6a4f-4411-212d-08d9553189c6 X-MS-Exchange-CrossTenant-AuthSource: AM7PR03MB6660.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Aug 2021 21:15:50.4560 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR03MB7301 Subject: [FFmpeg-devel] [PATCH 6/6] avfilter/vf_find_rect: Don't make frame writable unnecessarily X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Andreas Rheinhardt Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: Rye1AHguSZkY AVFrame.metadata is always owned by its AVFrame, it is not shared in the first place, so one does not need to make the frame writable to modify it. Signed-off-by: Andreas Rheinhardt --- libavfilter/vf_find_rect.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/libavfilter/vf_find_rect.c b/libavfilter/vf_find_rect.c index 1a94655b6b..415d633579 100644 --- a/libavfilter/vf_find_rect.c +++ b/libavfilter/vf_find_rect.c @@ -225,8 +225,6 @@ static int filter_frame(AVFilterLink *inlink, AVFrame *in) snprintf(buf, sizeof(buf), "%f", best_score); - av_frame_make_writable(in); - av_dict_set_int(&in->metadata, "lavfi.rect.w", foc->obj_frame->width, 0); av_dict_set_int(&in->metadata, "lavfi.rect.h", foc->obj_frame->height, 0); av_dict_set_int(&in->metadata, "lavfi.rect.x", best_x, 0);