From patchwork Mon Oct 11 15:31:56 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andreas Rheinhardt X-Patchwork-Id: 31055 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6602:2084:0:0:0:0 with SMTP id a4csp3816306ioa; Mon, 11 Oct 2021 08:32:24 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyBdGHK+WNtac38zwBY0TkVFIgc1Gxt72VgS4Tnd61j3U9GpV8jH60kvBvAX9hwXTcadmF/ X-Received: by 2002:a17:906:2b84:: with SMTP id m4mr26745848ejg.179.1633966343925; Mon, 11 Oct 2021 08:32:23 -0700 (PDT) Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id ci22si11682499ejb.240.2021.10.11.08.32.23; Mon, 11 Oct 2021 08:32:23 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@outlook.com header.s=selector1 header.b=ZOoFOMYW; arc=fail (body hash mismatch); spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=outlook.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 496876802B7; Mon, 11 Oct 2021 18:32:20 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05olkn2096.outbound.protection.outlook.com [40.92.91.96]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 028256802B7 for ; Mon, 11 Oct 2021 18:32:13 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PEgM3koH6RfmvWrTR5LW0ZlOCy/+PF8daix5QQG3BNdJIE0nfVJmhgQyWzMMSdDle/thHa9N7CRCyEBsAJZ/THm9XEtgjM2zGWYtE0pPcoAXOsdxrL0RvBAduOz/zemRlUhX0yFTVt0hedyNB7NZKemRzgxsGx7rLkEmoHfjIWdRdMdaLUFAhNpemU+rCjEXmFjcc1AJfcYLTZNEE4anVCO0D5p1vmLZExtrruOG97iAPwKvAvVml/pc22yR2UXSCYSp7zlZ9bRRYW/iSiu0tBuKX46qp4MYo810Q0czE94ULwV+XTrBDqLwWjOSN+U0sdZjmVZmnnZ1tV24ChOYAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NHY6tOEiRZSeAFl9XiBf1nE4oNAuhEQkL896EzltkKA=; b=g9X9JdyNcKrnn8NPHlJIGfchkKZcoQ5/HIGKxs1PzU3hkqhJNsq2/WRiemHxZg1moUe2BRsGMFX8o5lBuKlosgKA2SQg9dME4kdJjqCDw8FPGsIR9HxIiJsftiTj4kut9oDqGX7orPlr8d00a6v0kB1ikUDn1tYu4eQDRvoyk4zkZtvUz/KY2UfajmCw2S0dHKVbazpH8IPWrXHS/y/OQ/1zKuiaybNskYgWojI22ZrEuU80QrFeXvNNANgM6fVCIFyNUd09FWgIrMbIgcQy27kWNOv9H+iYQWtagSsy7Qy2qzgc3F52ftcy3D9Z0h0Y/wTVNEHg/lSuDbTA0I72+g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NHY6tOEiRZSeAFl9XiBf1nE4oNAuhEQkL896EzltkKA=; b=ZOoFOMYWsxWJrzMn36f/5gywZ8eDJE7i6QC4VIFXZdhJGhzq0heNZ8Xe5xqYWF7hknYTYRv1/WUE1zeKEGyukSZ83yVUu7TrhXvCyjov1Gxf13kUSJ/BC/yPuDIY0Mz6YrX9O6Rg8azUWk/u2BgA3zGrP1jy+V5zk70AatWJ15wqCBWWS0PGuZK8B7YFGUk+nAA+fENQqmuzfx2RgBN4wgbDkPJcjUNyDiY9I8Ekcnm8Bs4n1KRKCAAVWbxFakviHhU2K2sTtz+8Ufj9yg8Mq3PKC6CmW+7Dd5pjRteDsoLf9/LT64XVvlE6+ZeWF+Ttys3nX509aUnG5lmOmFIj0w== Received: from AM7PR03MB6660.eurprd03.prod.outlook.com (2603:10a6:20b:1c1::22) by AM6PR03MB4616.eurprd03.prod.outlook.com (2603:10a6:20b:e::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.22; Mon, 11 Oct 2021 15:32:12 +0000 Received: from AM7PR03MB6660.eurprd03.prod.outlook.com ([fe80::700f:d70b:3bb8:4d51]) by AM7PR03MB6660.eurprd03.prod.outlook.com ([fe80::700f:d70b:3bb8:4d51%9]) with mapi id 15.20.4587.026; Mon, 11 Oct 2021 15:32:12 +0000 From: Andreas Rheinhardt To: ffmpeg-devel@ffmpeg.org Date: Mon, 11 Oct 2021 17:31:56 +0200 Message-ID: X-Mailer: git-send-email 2.30.2 X-TMN: [Xy5BVQgV47GJ4eKy3JsS2IUH/kNNb9ql] X-ClientProxiedBy: AS9PR06CA0142.eurprd06.prod.outlook.com (2603:10a6:20b:467::35) To AM7PR03MB6660.eurprd03.prod.outlook.com (2603:10a6:20b:1c1::22) X-Microsoft-Original-Message-ID: <20211011153205.1960963-1-andreas.rheinhardt@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from sblaptop.fritz.box (188.193.170.49) by AS9PR06CA0142.eurprd06.prod.outlook.com (2603:10a6:20b:467::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18 via Frontend Transport; Mon, 11 Oct 2021 15:32:11 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 07c3b5e9-b30a-4a74-1c82-08d98ccc4bb4 X-MS-Exchange-SLBlob-MailProps: EpEO96k6WomLR2JEIhXFxRYWdLpGyWrkBUUeFRpYLjnIcvWIDtfne86cPqaDGAVUlisvY/m3SM/8NP6ap9rRdyP3Dm6HHNG7u8+w+mSiJQ9uYgSlDLx1AVsKX9KXUbj0haR6bPwuum5YGd8ZxSqegv2t/hGz8eak7MaZHDpaqVQ1IUE4GquW26mV0bGBN2m5oiSBZ0SxYEkJZVxWdzaEp4wXdbJqNngm85INwZvZvHs+G/jqWBOekAbrZwsxp6QaVyZ0w/lPzwgGVQIpAwkemk+Publ2Nteq3xzVX0QyEnNWbzcy9RCmOBS5MUSC1Kx5QNpEEkEy7N2vL2YndcKmw0bWzx9hLQqnoM+JX7nMu75/kzqsfWgVsiWHQEaVMvcEx5auRx1o6NlwYBSg6O0bfNKjAcnrRXgcODze+T2g0F003AOFMav9jKrlGK7B+5yWUMRCHok78nHIkqsQCWQ3umHliaJ98A+YmNlrIR57r0av/XmePA48T6CIM6dGFzfpb7Wd2HB9gTBw0J0oiuRn99DBjC5Jclg1Vq/qB/Gnq3pzC3v6N0i8/MC91hdsOJj+SviWJHaWGbFVrcevMhr9gzO6sRl4buGGP0yysJXbnVNzrksXCSblwOF/aUH6J+JJu/yRhhuIjbYLJOmSQcM9SoRa5CLQ+RQnH1FIU+D8/5YCTwg14mkaFDp3bv1Jtq7jhZoAl7SMBNgHzFbhiVWgX1FFCMW+9i08OnH9x3lMoM7b/dyjsRGUP7c1eI1yXbRlQ48Rw+GIF9U= X-MS-TrafficTypeDiagnostic: AM6PR03MB4616: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: RTaxZ9amJSVF9LEt3zrhuxe9DsgvLAfa/nLCfhRFbMoGy2PDaSy88HXFHHDqGezqbEx0Ub7q8IexU1Nlpfhjq/KyQFQFWRI5m0Jjo4xQcmINlf7UwyCUT5v9/W0M1li2wwBqX5tdudp2mMV7EkzMHSjNJEf+IZ9PE6SCZ7YJEzSkugwuJ3xzwnmLHlM7OQEBwTxSp8rewvNfC2NAGig4iPVFSFEfqxAlexHvfZgVPADtYhO1VW52kBKK4TIkKM3xAtyYK3W0lcZW0OiS9iK150YOjtpjGv2P9HUqaCf/QtI2uNkaK+0ubSU0SxBDf9L3SeQ3uD+GRiMDRIhC5gnPUuf+Mkl2wJD2n6aQDXrZ27UB+9WXdIy9nLG8Qc/G9RhmnysMRvq3NIPHW0S/S3jM9keSFyqzwqPJWbHcfnejtZjIquUdwp8EgLfOaFmN9lre X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: KZ8NwyNj4woGpmCSJiMu6djmfBUvJHPrMRLmGMQa62zSQdnU8DTm7b10Jh8w9hTOmJuxbq14jG3yKnxjk8TVQZyZrZprpG1IlkV27aQTDD9gH507b0HceUtoNM6JW9aE6+TYaBStFpJALGFy8y29GA== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 07c3b5e9-b30a-4a74-1c82-08d98ccc4bb4 X-MS-Exchange-CrossTenant-AuthSource: AM7PR03MB6660.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2021 15:32:12.3277 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR03MB4616 Subject: [FFmpeg-devel] [PATCH 01/10] avcodec/binkaudio: Remove AV_CODEC_CAP_DELAY X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Andreas Rheinhardt Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: t1g+pH6aMjSX This decoder may output multiple AVFrames for every AVPacket passed to it, but after it has returned AVERROR(EAGAIN), it is completely drained and there is no reason to flush it at the end with a NULL packet. Furthermore, there is also no delay in the common sense of the word. Signed-off-by: Andreas Rheinhardt --- libavcodec/binkaudio.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/binkaudio.c b/libavcodec/binkaudio.c index af8cb2809e..5915ba6ffb 100644 --- a/libavcodec/binkaudio.c +++ b/libavcodec/binkaudio.c @@ -346,7 +346,7 @@ const AVCodec ff_binkaudio_rdft_decoder = { .init = decode_init, .close = decode_end, .receive_frame = binkaudio_receive_frame, - .capabilities = AV_CODEC_CAP_DELAY | AV_CODEC_CAP_DR1, + .capabilities = AV_CODEC_CAP_DR1, .caps_internal = FF_CODEC_CAP_INIT_THREADSAFE | FF_CODEC_CAP_INIT_CLEANUP, }; @@ -359,6 +359,6 @@ const AVCodec ff_binkaudio_dct_decoder = { .init = decode_init, .close = decode_end, .receive_frame = binkaudio_receive_frame, - .capabilities = AV_CODEC_CAP_DELAY | AV_CODEC_CAP_DR1, + .capabilities = AV_CODEC_CAP_DR1, .caps_internal = FF_CODEC_CAP_INIT_THREADSAFE | FF_CODEC_CAP_INIT_CLEANUP, };