diff mbox series

[FFmpeg-devel,09/10] avfilter/internal: Don't include framepool.h, thread.h

Message ID AM7PR03MB6660F46CF4390FA09B4046928FEF9@AM7PR03MB6660.eurprd03.prod.outlook.com
State Accepted
Headers show
Series [FFmpeg-devel,01/10] avcodec/mips/constants: Include intfloat.h in constants.h | expand

Checks

Context Check Description
andriy/x86_make success Make finished
andriy/x86_make_fate success Make fate finished
andriy/PPC64_make success Make finished
andriy/PPC64_make_fate success Make fate finished

Commit Message

Andreas Rheinhardt Aug. 2, 2021, 3:39 p.m. UTC 
They are not used by the header at all and only used by very few files;
so include the headers in their users instead of in internal.h.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
---
 libavfilter/audio.c    | 1 +
 libavfilter/avfilter.c | 1 +
 libavfilter/internal.h | 2 --
 libavfilter/video.c    | 1 +
 4 files changed, 3 insertions(+), 2 deletions(-)

Comments

Nicolas George Aug. 3, 2021, 8:01 a.m. UTC | #1 
Andreas Rheinhardt (12021-08-02):
> They are not used by the header at all and only used by very few files;
> so include the headers in their users instead of in internal.h.
> 
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
> ---
>  libavfilter/audio.c    | 1 +
>  libavfilter/avfilter.c | 1 +
>  libavfilter/internal.h | 2 --
>  libavfilter/video.c    | 1 +
>  4 files changed, 3 insertions(+), 2 deletions(-)

Ok.

Regards,
diff mbox series

Patch

diff --git a/libavfilter/audio.c b/libavfilter/audio.c
index 5996f607b2..0deed5683b 100644
--- a/libavfilter/audio.c
+++ b/libavfilter/audio.c
@@ -25,6 +25,7 @@ 
 
 #include "audio.h"
 #include "avfilter.h"
+#include "framepool.h"
 #include "internal.h"
 
 #define BUFFER_ALIGN 0
diff --git a/libavfilter/avfilter.c b/libavfilter/avfilter.c
index c04afc6639..16581ecc09 100644
--- a/libavfilter/avfilter.c
+++ b/libavfilter/avfilter.c
@@ -41,6 +41,7 @@ 
 #include "avfilter.h"
 #include "filters.h"
 #include "formats.h"
+#include "framepool.h"
 #include "internal.h"
 
 #include "libavutil/ffversion.h"
diff --git a/libavfilter/internal.h b/libavfilter/internal.h
index 6a4c546b4b..6c908690b4 100644
--- a/libavfilter/internal.h
+++ b/libavfilter/internal.h
@@ -27,9 +27,7 @@ 
 #include "libavutil/internal.h"
 #include "avfilter.h"
 #include "formats.h"
-#include "framepool.h"
 #include "framequeue.h"
-#include "thread.h"
 #include "version.h"
 #include "video.h"
 
diff --git a/libavfilter/video.c b/libavfilter/video.c
index 0771268c40..810cc87f52 100644
--- a/libavfilter/video.c
+++ b/libavfilter/video.c
@@ -28,6 +28,7 @@ 
 #include "libavutil/imgutils.h"
 
 #include "avfilter.h"
+#include "framepool.h"
 #include "internal.h"
 #include "video.h"