diff mbox series

[FFmpeg-devel] Fix for bug #9231: B-frames parameter is ignored in videotoolboxenc

Message ID AS8P193MB1447841AFF31CC635506639F98E39@AS8P193MB1447.EURP193.PROD.OUTLOOK.COM
State Accepted
Commit 55d9d6767967794edcdd6e1bbd8840fc6f4e9315
Headers show
Series [FFmpeg-devel] Fix for bug #9231: B-frames parameter is ignored in videotoolboxenc | expand

Checks

Context Check Description
andriy/x86_make success Make finished
andriy/x86_make_fate success Make fate finished
andriy/PPC64_make success Make finished
andriy/PPC64_make_fate success Make fate finished

Commit Message

Anselm Busse July 21, 2021, 6 p.m. UTC
This commit fixes the bug as report in https://trac.ffmpeg.org/ticket/9231 by removing the line that overwrites the user settings for max_b_frames.

Signed-off-by: Anselm Busse <anselm.busse@outlook.com>
---
 libavcodec/videotoolboxenc.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Anselm Busse Aug. 13, 2021, 7 a.m. UTC | #1
Hey everyone,

I posted this patch almost a month ago and got no reaction. Is there anything else I have to/can do to get this fix merged? I’m a little bit worried that it gets lost.

- Anselm

> Am 21.07.2021 um 20:00 schrieb Anselm Busse <anselm.busse@outlook.com>:
> 
> This commit fixes the bug as report in https://trac.ffmpeg.org/ticket/9231 by removing the line that overwrites the user settings for max_b_frames.
> 
> Signed-off-by: Anselm Busse <anselm.busse@outlook.com>
> ---
> libavcodec/videotoolboxenc.c | 1 -
> 1 file changed, 1 deletion(-)
> 
> diff --git a/libavcodec/videotoolboxenc.c b/libavcodec/videotoolboxenc.c
> index 4eaabed5d8..8dfd6e3d0c 100644
> --- a/libavcodec/videotoolboxenc.c
> +++ b/libavcodec/videotoolboxenc.c
> @@ -1398,7 +1398,6 @@ static int vtenc_configure_encoder(AVCodecContext *avctx)
>     }
> 
>     vtctx->codec_id = avctx->codec_id;
> -    avctx->max_b_frames = 16;
> 
>     if (vtctx->codec_id == AV_CODEC_ID_H264) {
>         vtctx->get_param_set_func = CMVideoFormatDescriptionGetH264ParameterSetAtIndex;
> -- 
> 2.32.0
>
zhilizhao(赵志立) Aug. 13, 2021, 9:38 a.m. UTC | #2
> On Aug 13, 2021, at 3:00 PM, Anselm Busse <anselm.busse@outlook.com> wrote:
> 
> Hey everyone,
> 
> I posted this patch almost a month ago and got no reaction. Is there anything else I have to/can do to get this fix merged? I’m a little bit worried that it gets lost.

LGTM.

> 
> - Anselm
> 
>> Am 21.07.2021 um 20:00 schrieb Anselm Busse <anselm.busse@outlook.com>:
>> 
>> This commit fixes the bug as report in https://trac.ffmpeg.org/ticket/9231 by removing the line that overwrites the user settings for max_b_frames.
>> 
>> Signed-off-by: Anselm Busse <anselm.busse@outlook.com>
>> ---
>> libavcodec/videotoolboxenc.c | 1 -
>> 1 file changed, 1 deletion(-)
>> 
>> diff --git a/libavcodec/videotoolboxenc.c b/libavcodec/videotoolboxenc.c
>> index 4eaabed5d8..8dfd6e3d0c 100644
>> --- a/libavcodec/videotoolboxenc.c
>> +++ b/libavcodec/videotoolboxenc.c
>> @@ -1398,7 +1398,6 @@ static int vtenc_configure_encoder(AVCodecContext *avctx)
>>    }
>> 
>>    vtctx->codec_id = avctx->codec_id;
>> -    avctx->max_b_frames = 16;
>> 
>>    if (vtctx->codec_id == AV_CODEC_ID_H264) {
>>        vtctx->get_param_set_func = CMVideoFormatDescriptionGetH264ParameterSetAtIndex;
>> -- 
>> 2.32.0
>> 
> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
Rick Kern Aug. 13, 2021, 1:12 p.m. UTC | #3
On Fri, Aug 13, 2021 at 5:39 AM "zhilizhao(赵志立)" <quinkblack@foxmail.com>
wrote:

>
>
> > On Aug 13, 2021, at 3:00 PM, Anselm Busse <anselm.busse@outlook.com>
> wrote:
> >
> > Hey everyone,
> >
> > I posted this patch almost a month ago and got no reaction. Is there
> anything else I have to/can do to get this fix merged? I’m a little bit
> worried that it gets lost.
>
Sorry for the delay. The patch is applied, thanks.


>
> LGTM.
>
> >
> > - Anselm
> >
> >> Am 21.07.2021 um 20:00 schrieb Anselm Busse <anselm.busse@outlook.com>:
> >>
> >> This commit fixes the bug as report in
> https://trac.ffmpeg.org/ticket/9231 by removing the line that overwrites
> the user settings for max_b_frames.
> >>
> >> Signed-off-by: Anselm Busse <anselm.busse@outlook.com>
> >> ---
> >> libavcodec/videotoolboxenc.c | 1 -
> >> 1 file changed, 1 deletion(-)
> >>
> >> diff --git a/libavcodec/videotoolboxenc.c b/libavcodec/videotoolboxenc.c
> >> index 4eaabed5d8..8dfd6e3d0c 100644
> >> --- a/libavcodec/videotoolboxenc.c
> >> +++ b/libavcodec/videotoolboxenc.c
> >> @@ -1398,7 +1398,6 @@ static int vtenc_configure_encoder(AVCodecContext
> *avctx)
> >>    }
> >>
> >>    vtctx->codec_id = avctx->codec_id;
> >> -    avctx->max_b_frames = 16;
> >>
> >>    if (vtctx->codec_id == AV_CODEC_ID_H264) {
> >>        vtctx->get_param_set_func =
> CMVideoFormatDescriptionGetH264ParameterSetAtIndex;
> >> --
> >> 2.32.0
> >>
> >
> > _______________________________________________
> > ffmpeg-devel mailing list
> > ffmpeg-devel@ffmpeg.org
> > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> >
> > To unsubscribe, visit link above, or email
> > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
diff mbox series

Patch

diff --git a/libavcodec/videotoolboxenc.c b/libavcodec/videotoolboxenc.c
index 4eaabed5d8..8dfd6e3d0c 100644
--- a/libavcodec/videotoolboxenc.c
+++ b/libavcodec/videotoolboxenc.c
@@ -1398,7 +1398,6 @@  static int vtenc_configure_encoder(AVCodecContext *avctx)
     }
 
     vtctx->codec_id = avctx->codec_id;
-    avctx->max_b_frames = 16;
 
     if (vtctx->codec_id == AV_CODEC_ID_H264) {
         vtctx->get_param_set_func = CMVideoFormatDescriptionGetH264ParameterSetAtIndex;