From patchwork Wed Mar 13 01:14:29 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andreas Rheinhardt X-Patchwork-Id: 47019 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a21:e85:b0:1a3:31a3:7958 with SMTP id ma5csp105977pzb; Tue, 12 Mar 2024 18:14:51 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCVE3lBJp/bIkxuRCA+3YyLdSad5nPImjQ0Gal4eilDiIkohHebgf2HWCw61ksguO27JkX013YeQD3+BoAR/prFnGn1LKP3HlLJaZg== X-Google-Smtp-Source: AGHT+IFbHfOZM4T1UNUXnmCzTKk7ifPNJHNYkKm8nf3VcaNRDwrEDhYdbqFY+nCxi02e4M1CORKO X-Received: by 2002:a17:907:a642:b0:a46:4d76:106b with SMTP id vu2-20020a170907a64200b00a464d76106bmr1470369ejc.34.1710292491316; Tue, 12 Mar 2024 18:14:51 -0700 (PDT) Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id i12-20020a170906250c00b00a452ee5fc67si3974795ejb.600.2024.03.12.18.14.50; Tue, 12 Mar 2024 18:14:51 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@outlook.com header.s=selector1 header.b=i0McGAfw; arc=fail (body hash mismatch); spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=outlook.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C320F68C633; Wed, 13 Mar 2024 03:14:47 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05olkn2013.outbound.protection.outlook.com [40.92.91.13]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id EC24968C633 for ; Wed, 13 Mar 2024 03:14:40 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=E45rc47Na5dUdHPtPOCpM6SpheN29RcLnMhASQhMImb2a/dQ1GedVj56mVuprfewm/ZzfyXJTZgI/qBiRY02zpWDzmccKZCPi+d3A0F5WRLDufRTtTyX8+JNt8i6zOGTQf0Ng54l4XQWIzyoyMhwFiaIHt6OaL+4f293vHu60jyH6I3CA+jkq0LBbAGuDoJRVaCzMMSvcTDo/Omwp4YFTznq2unKaWvsbf+BJd7SxXYnOyKuY9ovDZOaAt8S95nzKdKUJeoWlpQSCHXa+p+sgCPckpz8Lh7hQINbtFCsVN8sb8Jn3pzhNHjEPVjGcS5dnRroPRWN246AU9tkjxWlOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RBmDiGb3iIrMgJhmdL98VdTzB5BXawrRqLgu/6lNRew=; b=mouS4MU6uQ9bE9hVNTeN5HSfcuLJZVaTz7yVm/LgPkr63ck5xIuxULJprMIlKwGwqFSYxKINnWayU03MIDlk9Bj+svbmqu+UjmZNPZRqte66sbCI4PXEEV4J24kjc3nBntiDStZ98JAFniIrY6D57cJuws9vDYHc1ec+bVPpO21gqnsb84QAAWJ8w5X0269Jl7t7/69NVs4b2Nb+clSP4aZuAaSObuGfo1e/Lw3QhuCQnnBfMO98zWLt9SUoIOLGVG/GhMEBvQnEDpj+mh6F2tGpwvU0RbM300sfpn46g58EEvSCFMMpl/WR2kp3GBrJNfSpKX9luC8ETXfvVDF/wQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RBmDiGb3iIrMgJhmdL98VdTzB5BXawrRqLgu/6lNRew=; b=i0McGAfwA3/suc7HtUF9biK3Uio94Si5r/xvXvjgVqfLfp3N9jUGtuYptIPQcI7hSSVAETReArUiRpWJWsvtjwWZ3Yd5dxvN4AqMx3IwnVajpRESK7icCp0YrwlOHIRksN8LT/5RbZI/WscdgDmq/GasCmnKsnXfJIJVyuoQF0dAa6vRq5q6Wq8sUAV/E4GwPlmi/eEK7fzCLMTY3nvphrQsekCNuhbn7MhKwcjEpn6MMURZ7iz2Pobb1QntlfT7bZYCp3Jnb6YY4gjcvOeRbt0I181W53s0svY+7zmJQDNFhmpIahGWeqe0qwKtEnD4OOFIuUIyYSGBnEz8B14QOg== Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) by DB9P250MB0450.EURP250.PROD.OUTLOOK.COM (2603:10a6:10:324::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7362.35; Wed, 13 Mar 2024 01:14:37 +0000 Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::228d:8c6f:ed10:82eb]) by AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::228d:8c6f:ed10:82eb%7]) with mapi id 15.20.7362.035; Wed, 13 Mar 2024 01:14:37 +0000 From: Andreas Rheinhardt To: ffmpeg-devel@ffmpeg.org Date: Wed, 13 Mar 2024 02:14:29 +0100 Message-ID: X-Mailer: git-send-email 2.40.1 X-TMN: [1SL0ktUM/msrrkWGXDTVElJ/baejlBVXIlv3unRmaQw=] X-ClientProxiedBy: ZR2P278CA0043.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:47::17) To AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) X-Microsoft-Original-Message-ID: <20240313011429.2181761-1-andreas.rheinhardt@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8P250MB0744:EE_|DB9P250MB0450:EE_ X-MS-Office365-Filtering-Correlation-Id: f723c6e2-9b80-4ebd-7ed7-08dc42faf2cc X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Zj0gCeWnLVDa4RT+qxKYmm/tikmPWzwvody1grW94SDrkMBOSBBT4wSJa0wEUaLIp8YSD2LRigaEHmMhGI0UYJwYhdyyDpef5BXBt4a9QFNCfnUnZuM22Tlw/kUDKLIZ+hpHgo48bfiK3QaOqiZaoMNyqxSK6vwSY4beKUdnmZ35lJrwINra27em2+BrcsUDq9LbdszG/wpFlzmUyqmWgT4cn8OUYdpdOpHqAJhElzYRCmDZt4yQ+kwwTIdYdkd/1Wzv0GmrrOwcDxB11L8SpV6g3gqmWmK/NI4RCvpCC0vHJapQuXJjRBFZ/xysAsRln5HcgfIuJ4UsDwt6+MwwR4lx2G9YGdmdwYnee7ej6VOOXlMPWeO7N8cA7o4ntdRzbz0WV61BmN9qzHJSqn78slIMPlHaOpp+dKEsh0+/Qia7fCMqM9fXPReplXgJTm59LqA3WwN/meWRjRUf0Yn17KLqn4tudS6BgfsZaQYOlWjq15OBjfERizdxjAwbn0BZgIwkXQi7JH8Y4DVNjs85h8nQk3OTYz+NIVetMHhM1O7ZCpPRZ45MmPksVzKsqK5cl8B+MiXJlA0ooYBzAuQ3un0sNXUdk3WZ/lUTGoVcbESazkocdy2eEBqkn8XFlBvUI3HudPmkmv7WgwYjEOI1R8XsbyOMo0Z51hqZwfzd7pUUH9e+wigyE2DJWq8tC2zs X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: Esb3j5XXgxVCDMwUAvQ8TTxhLJhNYPEAVejc0R0p2FGCSkbfl3GBz+wpDO16/4kWPmXG9xORxernRcaL7SRkLRMWr//yUEBoY8ZAP01frTU1QvbeDPZNJaOGMbkcNdEBL3hJc5LW08pdZTSFp9buXKH0dyHrscSZSnvDm4gP+tNIloidVBDvVGNNnYyAZr61AQZCpiNUQUoArIaU1SIOdAK2RPj4eg3XBm1CKuYbc5B78nGHsgPGQt/pKDFSuKwwAyQFJAXbYWT6Y9/pWPApuKAfM7mqeaxNCeqAH38LZvj1EJ5e9k2L+cHvrk1RRBbz2v4BFtPac4Q8DDUeyUXWdqs3QMkv5ghFYD3gceIDPMIQ08OokGkAXoR4+0xm55TBOs17WMHlvzaeTNJpCQJJPOQBNjvXuqDeyU/qFErvNTLnwYezKvC+RF54gUEenTzlKxdXeNl67Dzq8QfnZDmG9KI8IKefpQBQXHhDFYV+P4jUw19C87jhXOy0HbmlB9FLl2H7THTKKpVNdE0nFg12zs1vqshrYa8AG1p94giuYN4u14hTxmVtFB/ygSmqo71ZeMb9Fvd1qow1wVvQ2qAiYDftypCm+KNn/3AfNqaX0tBj5zgaQ3QrdNHZp3LBUVa8PoDkjT4NqBs8iLtyb7ip97vuKyRkrLDwNlYScWNtLDvGlRTLsG85atz/bbMCpCF1kJm5hXtHaDq5FC7NWBnDBah6ewa/fQuNjYDeYKSfw0YPm5fk1W0AMda1qpyhx+rkLiP4/oAEbifC32CaozwTjlY1DR45AXMFPzLIlx3Q6WXaWYiSwqA+s3JGNMdBtr1s+JlPjuzh/PjQvr5C7LsS2+4JkJ+J3zjM+do3WfvVPmASsGR+N9uPfbPRy4P7SX/QkR4Eo9516M5YPVcOO7woUrqW0139GqdUJtJPzMcqC2LEXYHfjcOounGPoMS3HtZ8kLJ0AywxW/BQ8Zfy11B+tvlamz8L/ehICwrm/f5hCObq958/qA8kKBl1lfluFohfjXCGM7UoxU0MClpAt/AksI3o8Q43/hDHpF/KC4ucBx9tZkNcb7Is+zKxrEMa7jLIzwY7Zau10I5E3PkSu2o2Dy1OwgB1DN1MdnmzM+TREzeRCJeDFP8CsgFr9Q1f0Yc9xjByWDXluDdiRcK7tJNgJgFK/N+HyeYy8gny6CTKvqn9DdEbGYXDTrDA3GShNuTT5YAGs78rdaP+XgwpBKuHEnpQNd8BRby/XP4iFDaZLgFaTngNAj3BabaNHW+vVAYQ8OCfRnRgyKgAjeOtA/H9TA== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f723c6e2-9b80-4ebd-7ed7-08dc42faf2cc X-MS-Exchange-CrossTenant-AuthSource: AS8P250MB0744.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Mar 2024 01:14:36.4760 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9P250MB0450 Subject: [FFmpeg-devel] [PATCH] avcodec/ppc/vp8dsp_altivec: Fix out-of-bounds access X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Andreas Rheinhardt Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: qH+ie8mNt3A6 h_subpel_filters_inner[i] and h_subpel_filters_outer[i / 2] belong together and the former allows the range 0..6, so the latter needs to support 0..3. But it has only three elements. Add another one. The value for the last element has been guesstimated from subpel_filters in libavcodec/vp8dsp.c. This is also intended to fix FATE-failures with UBSan here: https://fate.ffmpeg.org/report.cgi?time=20240312011016&slot=ppc-linux-gcc-13.2-ubsan-altivec-qemu Signed-off-by: Andreas Rheinhardt --- libavcodec/ppc/vp8dsp_altivec.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/ppc/vp8dsp_altivec.c b/libavcodec/ppc/vp8dsp_altivec.c index 12dac8b0a8..061914fc38 100644 --- a/libavcodec/ppc/vp8dsp_altivec.c +++ b/libavcodec/ppc/vp8dsp_altivec.c @@ -50,11 +50,12 @@ static const vec_s8 h_subpel_filters_inner[7] = // for 6tap filters, these are the outer two taps // The zeros mask off pixels 4-7 when filtering 0-3 // and vice-versa -static const vec_s8 h_subpel_filters_outer[3] = +static const vec_s8 h_subpel_filters_outer[4] = { REPT4(0, 0, 2, 1), REPT4(0, 0, 3, 3), REPT4(0, 0, 1, 2), + REPT4(0, 0, 0, 0), }; #define LOAD_H_SUBPEL_FILTER(i) \