From patchwork Mon Sep 25 18:04:53 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andreas Rheinhardt X-Patchwork-Id: 43899 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:2a18:b0:15d:8365:d4b8 with SMTP id e24csp1403533pzh; Mon, 25 Sep 2023 11:04:32 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEvW5YeI3471nulnWbeUqXhwgYHQyxelsqnhZeS/euWDP1ftfUgiKkflMHUSZDxpMtzQ2ez X-Received: by 2002:aa7:d90e:0:b0:532:cae2:8dfc with SMTP id a14-20020aa7d90e000000b00532cae28dfcmr6739532edr.5.1695665072143; Mon, 25 Sep 2023 11:04:32 -0700 (PDT) Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id n3-20020a056402514300b00530f5700caasi9127919edd.84.2023.09.25.11.04.31; Mon, 25 Sep 2023 11:04:32 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@outlook.com header.s=selector1 header.b=igCGql1B; arc=fail (body hash mismatch); spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=outlook.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3DF4568C9DB; Mon, 25 Sep 2023 21:04:10 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05olkn2101.outbound.protection.outlook.com [40.92.91.101]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 0EA2968C9DE for ; Mon, 25 Sep 2023 21:04:07 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=M/k5ofmPDFggVYMBX0VgQhgt6sYvb2OUqzn43coCM7UfX1rCV7tBFaYjjZlrId2kQNhuYlrA1abgQjnTFlmMsrnVfAvmQ0Z5qvRTL2cB1QSV+wozpisEb6GCwvKLJdcIvzI7BarIiQ8HZEFkSkBfbALmHeGi/Ul+bR8CQVPn/O/E6UnFTsO8lSV2dFe2d476Pw0VpMl5yjaoKnySRi/hdLZNnpMQexwAa2DPF+LE0roa89wyiPCXgHPOjA9hlQs+Pwr4jArfUMPLs5V4Sm+TgzOQsLSVqzUlneKycXcxREsoVxIZU+sEk11IDuz4aAM0/FdUpvqP1TK32z40zgbqjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cpBEcu7KSJE4I3OnUwQxZ5Ms5tZu/i7McCXZ1BnvJl8=; b=cT9+oyBe9CKYLwJPh7PG+YdwQC5D6/7W7xJRXDAUxWamjSHYB6qFrNkwcSoCfgw2Sg91+SYjN9ddXRZxTIDtpBRcyry38GaoOO4SVNbSE6syAQEBJbgpMMESRx7aX3dwfV6Ey28BMjJ0f2Cmnt1BCWQStMIb0uP4LFybMvneTDhFfVewODlPm1KGWvo6iumsQnes1udwIn6B4drGMD1hyO/lETSbEFB+zVuIraJFCZjVPSssqThFDo9KL4kyL6+DtB1qOexgCcGjzVvk9xPDE5dEW9zBr9nysSf6RLacG/BBwuyZlipMXBbqzxJz6QGAUpG77YIQTpg9ycN3fS/jvw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cpBEcu7KSJE4I3OnUwQxZ5Ms5tZu/i7McCXZ1BnvJl8=; b=igCGql1B9d/1jJcpu+3WFaFpVutDs7/Tpi/EvNcJSxPgFXxO/AYskXOSH1A+rXgANt3GZcxhEFDmSbhf+ZTEG3HQTLWeS573iHd/1glY8JzcK5MoTbrYrK1z7t3Mxc/KMCcT0k87MTg2ITerhi7nuDpUeaSSYu0nTMxXC+CKyB5Wjm0we0Q6Ybjiz3Jg5mciKVy5ulk6SFEvIInfoB6EMTVtNsjStHlGWU3qA4CZQrg/JG3nYfxwWiNmnu2yz7azfUwdTT1sejpY/xD7BWJ2iZU87Yy/7aZkrEEUY0vUHzviv+KEHmNbVEv1efNlJ9vRINW1z0c70xdFI+tkcTG57A== Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) by DU2P250MB0271.EURP250.PROD.OUTLOOK.COM (2603:10a6:10:270::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6813.28; Mon, 25 Sep 2023 18:03:58 +0000 Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::5e01:aea5:d3a8:cafa]) by AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::5e01:aea5:d3a8:cafa%3]) with mapi id 15.20.6792.026; Mon, 25 Sep 2023 18:03:58 +0000 From: Andreas Rheinhardt To: ffmpeg-devel@ffmpeg.org Date: Mon, 25 Sep 2023 20:04:53 +0200 Message-ID: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: X-TMN: [VlU4M/Zkxmx2eocd/Xv5oztLb5yK3SG9] X-ClientProxiedBy: ZR0P278CA0083.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:22::16) To AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) X-Microsoft-Original-Message-ID: <20230925180457.2060101-4-andreas.rheinhardt@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8P250MB0744:EE_|DU2P250MB0271:EE_ X-MS-Office365-Filtering-Correlation-Id: 5396bffc-04ed-4e20-e179-08dbbdf1ca4c X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +u2//jiLQu+lC53QlY4itZ09Ig4bTdfZYipYmFsA1DjbtBaeFQB6885twSgezRNFP/QMVg1TcNUf9RG+cQqKrgq21DPa8P2ZX99CaQnMXK3PZ0EHfLgWLSM6QyXSHGDqgxMKdWlimGae2pv4ZCIyOdDJa2lhnsXloMonLHFIleFNg9J6UUkYtD4iC4omJUuSYC6//EU/IMtnj5ei+fWeWZIZC+QQbrzNUVscO/KrIjHOOkDqXFZ+v0UWhIhUMH7VE95+mh9O4ZV4PdUglaWeNKKnsKQV/Ss5BZvKFGr0gmXuNaJB8poMOp5tS2LLxkz51kdlTzaaV+hbiFVOBrd6kY0u8l0ZMJZUBYCmtbsASqu+3uvdDusa/i9/mjD52NllmTeuHHGNVYNZWS9d2efIPBL3ON/DlY+vF4o6zJWyGAVg+qnpuhtvqRntjNf40z6Kb5MX3Olgu/K4sCuE8gwHEAqQkLV5K1vbS3ArGzOE7MxVglwBFEaLxEz7nnEwkFiwHyB3aHK7A9nuI9xw2wBRB6JUIFCm2kNwNOzCVEEHR1tXSfQUPvDYdxIx+AFWL4veWmzClCDnPv/A6XgCb5TxDSvPpQLCG0HLOEK0ueIvXXjp3qKydE7MNTopDMs0cd9x X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: oqy97WWE0E67R9cShVlWtW7zI8Sw6qE67rj1K2Lzs2dzXU2QutiI4Ok3AqVa7PUaUoV/1MaQNYoltj0BTf+oLubVGsTVNayaM0lj/jPveOYQjPQ++Im5Y6ea/Py6+K4CtvjrTD8OOr0DHwfDQNuV96AviRda1ri2kwp/eH/RuWbXJWTp5BlvMEeKMt5MMYCLlITD9BM/g+/R+GmXHkKY6n7DAl+GcL0CeV/lbyXYEvMUtHWWCLt1VmMT1Z1eX3EvpRr6eSzzwmr+u76Vx5P6ScaUWrqOr13byU7AWrc589jlvtiyZ0Eq/EUPtX3X4nyUFBxxiP/E/+b9cuotfYe/mSa1zGLaHhqJB1fCbv5wM2P0I7VOQfZzCr3SYwb/ey2M+wGctkmvxrnQKpNejI+xs5C3SCxGcyMjopX5TDPL7x+lbp8r+EZCZpl1T8hxet7PR1WnrKdIi9Z7I18k+vDY41ISefIN0M5cs+IFE4cRbd+RK/+E/Clin7bFWQTxQOP71GGgDxnZmeEoILd5gUKyNQhKjh1fnlh9+XRAof64z+afkqe4/dAEc7eq1Em52CLhgoQgVqNwCQ++/yySGwDPdDBVQWYuJ8ebktpash+Y5pQlLKDw3t9uagNorXnosu8b8yEY6nAHW0pRy7NGG/GE+aSsGyUmkW93ffiw3dbISIOYiap91tJO9iiHN6AYRuhonE2nig2BYGRb5UN86cdaNMW/E2gZog+M9S28WoKcU9emGPwxQTHqTz5BV3P6i9O8OIRb9V1SKHjdkm4UYwhND7rP8nnFeZ/O1qT7hyKUH8SgORkq40HENF+reQ2g7By0IMBKvlBdBDpEF9n6dhPFOKjjmS0kUUDwgE+qPWPkI0CUk4eU0IdxIWPEzGNLpSSV2rI/wJctCAQqqmrtcDJxqYrrCMA7lrmsqRhRRNC+Tx5Ti4mQt9rnCdgsvvZv46nh98cMWKMvvUX9U/180Wq8B8NONRkNUbTQXsc1IvAKk1wRK9leO35QPVd4DORyFOZ65q1nrtRY4EaFMhhDFwZIJLvWDnkvQQtmG0MHhuIf4E7udDHB7t+Tz1lqIAxZBgAI1dwjP/zhsXYUIg8DyEJe4lZ28coGlUUsdn2WMvYVJHB2jFPMXs1pH83Nx2nujUxaz8LAj9bUfel7b1AVGzB8yA226gu/gsQ1RVEUu+irpBlR8gipdH2unyftT0TolRC9g7pJ98yNHRX5WjKsgsJMZvrernHN5sJKe8/x/3srJhpePyx4CeJDPR9KD41K37yP X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5396bffc-04ed-4e20-e179-08dbbdf1ca4c X-MS-Exchange-CrossTenant-AuthSource: AS8P250MB0744.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Sep 2023 18:03:58.4655 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2P250MB0271 Subject: [FFmpeg-devel] [PATCH 5/9] checkasm/motion: Don't allocate AVCodecContext X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Andreas Rheinhardt Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: Jjucs8mg2slT Instead use one on the stack to avoid pulling in all of libavcodec. Signed-off-by: Andreas Rheinhardt --- ff_me_cmp_init() reads only codec_id (checks whether it is Snow) as well as the bitexact flag. The first check has been added in cfe675269bf44c49590e9076b5d2cd2503804f98 due to alignment; I don't know whether this is still an issue, as the ticket referred to in this commit does not refer to track (or at least the current incarnation of it), but to something else. tests/checkasm/motion.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/tests/checkasm/motion.c b/tests/checkasm/motion.c index 87b20d1c10..71a0ee3fc0 100644 --- a/tests/checkasm/motion.c +++ b/tests/checkasm/motion.c @@ -118,16 +118,14 @@ static void test_motion(const char *name, me_cmp_func test_func) static void check_motion(void) { char buf[64]; - AVCodecContext *av_ctx; + /* Setup AVCodecContext in a way that does not pull in all of libavcodec */ + AVCodecContext av_ctx = { .codec_id = AV_CODEC_ID_NONE, .flags = AV_CODEC_FLAG_BITEXACT }; MECmpContext me_ctx; memset(&me_ctx, 0, sizeof(me_ctx)); - /* allocate AVCodecContext */ - av_ctx = avcodec_alloc_context3(NULL); - av_ctx->flags |= AV_CODEC_FLAG_BITEXACT; - ff_me_cmp_init(&me_ctx, av_ctx); + ff_me_cmp_init(&me_ctx, &av_ctx); for (int i = 0; i < FF_ARRAY_ELEMS(me_ctx.pix_abs); i++) { for (int j = 0; j < FF_ARRAY_ELEMS(me_ctx.pix_abs[0]); j++) { @@ -143,8 +141,6 @@ static void check_motion(void) } ME_CMP_1D_ARRAYS(XX) #undef XX - - avcodec_free_context(&av_ctx); } void checkasm_check_motion(void)