From patchwork Fri May 24 22:04:45 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andreas Rheinhardt X-Patchwork-Id: 49210 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a59:542:0:b0:460:55fa:d5ed with SMTP id 63csp2018451vqf; Fri, 24 May 2024 15:05:15 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCUod87uuwnf+sslvHqdpbWhBF81C887zlEvJY3eFDTMKw3oj/EpFkrd9EdVORCYEL/7VI91pJo+HKhursdJGb0uuyWnsVWO6uOxDg== X-Google-Smtp-Source: AGHT+IGBAkWlNRmj9L+rSwxAfUDERPdN99tg5tJlmiQVU3G1lZrypEE50SOsknP6xVmxqbJIr0LB X-Received: by 2002:a05:6512:29a:b0:51f:3f6c:7466 with SMTP id 2adb3069b0e04-529667cf9a0mr2321721e87.48.1716588315478; Fri, 24 May 2024 15:05:15 -0700 (PDT) Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id a640c23a62f3a-a626cc36ad5si122121066b.425.2024.05.24.15.05.15; Fri, 24 May 2024 15:05:15 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@outlook.com header.s=selector1 header.b=cEgr83l3; arc=fail (body hash mismatch); spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=outlook.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 4998868D57B; Sat, 25 May 2024 01:05:12 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03olkn2043.outbound.protection.outlook.com [40.92.58.43]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 46A2168D4F6 for ; Sat, 25 May 2024 01:05:05 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WdxBxOUjra6nFayTjd6Bzdp3j2WFwjGgCBb9MmuGk1CbKHH9dHQ6z3rx56LGz4RA1w6e2Gvq5vAQz7GNgU+dXHen0mSYplIsDU1zxOTxnINCKt5QsaysPAnLrVXI5ldgfQBWkt1xWoSPoGRu2QtqGSEaB5CkSX53Dnq3JvoiXIDyJGRVxQDa5mYh5qYT57juyt4nqFG4F6LHUg/RdmcKquREsQYwUvB6/3NRQwOEKp5a/EIkK2jJ4GYdaCAuFiU0D+agFp3PbqU7UbUbJ4KkfAgV3MVZ8a9DVs5I9YDHfRJq1CZCh/nxK+JmqnGsd3iaRqdmGdyiBpP90AXQtxeAMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5MM+uIxS3CE/pxDRjCuy6bef/7VGt4EgOYJAS8D0E+o=; b=KKcFvoh7QychW1yVgpix0f3gQY/P7ICMRST6dbfdM0XLHC0g8mJnzwfmf1smS/hrj7E8JY5Ay4TUFdgbDMMmMGJBTAlr03lbm+W2+mCi1ipYDkxLhN8hihcnuZ479z6FtjsKC8OEVdqVxVTtzL8nQztzd6ALasUm9R5I+oywtV+biEkY/L0mLd5HTrpF2TTmotOe9CHi08be0Aay/k+TFaL/1QYPqVO/WN/0AiKHmIAiDxPPYbH4Lf2bMQzro67Vb9CUA+fzxv0vJgEdF2lQDyBucu4gaq1gjh/Q/Ek/04o/xRemIoecF+GqG4kPtnkPkP9DFcmyUA1w+q9zxDpQAg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5MM+uIxS3CE/pxDRjCuy6bef/7VGt4EgOYJAS8D0E+o=; b=cEgr83l3Fa3fXcSQ0hCDPsNYwleF1q7j4qE5vsL4rcriIf6PR/Kv8EgbasTPbEGTzkGzpiHe+R8kkf1Yu5CSYKsrKBdPLNa0GPvvr8ewA8X/bwpOs/pKTMOkn/+XwUg+4tIEdDzY77L4oa0iEcFRlvoZK4EoqGUItqQH/Sni1c7I07v9C53yem5a8VffmxIiH67nUdJgWijrZTsiAGFCuBjNTUUWzxU8H8Zdn6M3OTuostMVu92ihSwuXfDtP6deZF4BCkNsZlBiF5y5o4gyNqP0jCAJt54X7sXiJhadyjbw0n1orqLIY9WSeC9FFiuOXcMQuHGmZY+SHHQN2FT/jA== Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) by DU2P250MB0368.EURP250.PROD.OUTLOOK.COM (2603:10a6:10:27d::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7611.22; Fri, 24 May 2024 22:05:03 +0000 Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::384d:40d4:ecb7:1c9]) by AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::384d:40d4:ecb7:1c9%4]) with mapi id 15.20.7611.016; Fri, 24 May 2024 22:05:02 +0000 From: Andreas Rheinhardt To: ffmpeg-devel@ffmpeg.org Date: Sat, 25 May 2024 00:04:45 +0200 Message-ID: X-Mailer: git-send-email 2.40.1 In-Reply-To: References: X-TMN: [eBelfRqUNQXCSJRhPZZfkbNyDG9TehIGGKZlYsjXl8k=] X-ClientProxiedBy: ZR0P278CA0194.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:44::21) To AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) X-Microsoft-Original-Message-ID: <20240524220455.1276419-1-andreas.rheinhardt@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8P250MB0744:EE_|DU2P250MB0368:EE_ X-MS-Office365-Filtering-Correlation-Id: 2bd07382-ea9d-4393-f413-08dc7c3d8fc7 X-Microsoft-Antispam: BCL:0; ARA:14566002|461199019|56899024|3412199016|440099019|1710799017; X-Microsoft-Antispam-Message-Info: t2SDI7nOvFzgT2RifugnG6YqbDp2oyRU36PDkJRu6CZ7XJOwXwAuLOD6cQMIDvFb8IJTfIS7XL4HLSmBEyDuqXks4hBj74hqC4juoDZ5dSgjYzAEvrRggkbo/6RA3UJ88LAzpQC6A3tOGbZ2agol7258NZqq06kFidV2WCM9v5+5MAE8X98b9/ZJJMINuZZp626ghqgoqyuWcKJTUWEfg1eM+7LwfTL9wyD1Szw7OA3wSZn8+wG0pJ052z5hgvRwMaBGXFvCLlP9FoLOU3hrOMkRZ5ju3l6dWcYRkxatH1Z3dr4ymklqwQ/Vw7jpalnFXpkPE/TiWzre7BVxdrckiX47rc750n8ImhLQWkjQXPXQHCgUIT/lufRn27SrHTqM39EBRJyOc9GedSo5Sb5kjwM63/GhrHkDyzq08vF0dtTBxP61uqODqcCpWQBKuiVf4K8puxjvkMvu2U/1pmvIBBXYT78twk/IAqmAovGBmFecn1DVW6ZcvH7bQ6VPB8nuatmlzL8pepOpCDIiYMnbz9gnOf4Zet0qmcNK7CJyWNrRlpMYGoJkfFc/ujuPAy55H9PpGfG4omnB6JzCsqOroYjwSC/cwx4FHb4w0RJgt4DZ+tT4SDiKD1I5v4Kklq4A X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: uGuNl1bgCNfAtQgAwJWbvfmvxn9Z8buzgPdjw6N1eGjL1CYeZmjhrHENBguzWR7Hy4MrSvQ1tSaK60KSakaKIgD/NVcPZKY/QptLyJCzw8M1nMdOqlexHAEfrPG9vCCGoxJ7UKmnUBBnEtHAgjrmdpq+ztwzs8UVX6ujrlU1IbWe+dlNUFoHpbSYZRcOTAJyjKWEnQyIgeQZGz0AQBLVjtyIHYZixlQ5t4xgWsMz+JitgvnF0/hOjJxrql5I/WDQH7M+qYeIokvFs/n74+8m+vAPKukg1WJUDX09T2MVXBHpQf20Y1z/7YMBTquPpMS9epTeCcUYtLJVkecDDpnufGqYM0ojCnVRj9w7y4B/Iqmv7kHpyqW2yzWoOV+iTdT4X0+88i/PQKTry4jt8mqDFD727uajE4Y3Ue5VT81bZt34kNZz2b0tVeKrtjYpsVBCO1WgD2n1kQ59my/KJ6GvDkFWc8c2NlCaikydi1bjsHHqotJC2kfizbz6DG5I9Lj9L4DnuMSHPzQJGmdwFkDn3S+wa409o5csDZKapnxNlL/lOch7uNGw29apNFPK0Y0qxbBS77D9e+5OooXrE+WD2yd796+yRkesrvI5O/A1148+wVslJYiYtJRw5ufzao/oVk5dNgEyRZVpPSFEBDOUedFQahu8Yv5NEjmR/T6lBPwhZvIseqc2A8kgZnu4tpSBxveFhkv2TKB4oGqYgHpk2au3KwI4hnGli3PE2kbRJ12BLNMF+DXJXmMz9sx5x9N+qVCeKgZ6xKHxyUCvEFXDsxlWx4Yp+h2Svg8VveydnBb6/BzKREd8YxopYgpdx7bcs8ZUvuM/NXq3gHHgmumFJQnWuayuWSrOZFXiY+m4LPSKB9C8sweyucdAPlFmuXkpOyrl+SuOXdOKG+pvgKp7vQCYyIM5U67t0bAuyjs0TI5bESxm9wXDHB8mgC8sPXPlvBZFwafjfz52TYYphx7bBjrAjQ40cfc9V8uAAkyFppjQ+Oe8vUFtSny/hjckUJGLf2/E/rSDEheTG+92H2VW+R4HnqNM4+4qKsovFwpsFNlFQJGowbRAI4Ti69YpeWLVB7yCuEQdWfpy/XiAg21tcOlrCrHGiI9hr2f2e4FaZ28v3Z7G/p1T6TJU2fDJgGKfNlK8X6c7uWyfVY/7VHbCNbM4/21jL+15v6A9ANRqE9mNgHvvtms04sCDouT/mWkjmk6iFgzpjVpHONrA44SAHaNCIRqH6pOgUEAQrU3ZepNSHHAUHs1lqNVHZaeIXwm4u022jylk7A5CY1YkD4njlg== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2bd07382-ea9d-4393-f413-08dc7c3d8fc7 X-MS-Exchange-CrossTenant-AuthSource: AS8P250MB0744.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 May 2024 22:05:02.8851 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2P250MB0368 Subject: [FFmpeg-devel] [PATCH 02/12] avcodec/amrwbdec: Mark default switch as unreachable X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Andreas Rheinhardt Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: V+5Epm+VoY5q Alternative fix for Coverity issue #1473499 instead of a3bb269db92601e2dc0e99352468d02f7b26c7c2. Signed-off-by: Andreas Rheinhardt --- libavcodec/amrwbdec.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavcodec/amrwbdec.c b/libavcodec/amrwbdec.c index 21a730b835..de1e661f2f 100644 --- a/libavcodec/amrwbdec.c +++ b/libavcodec/amrwbdec.c @@ -556,7 +556,9 @@ static void decode_fixed_vector(float *fixed_vector, const uint16_t *pulse_hi, ((int) pulse_hi[i] << 11), 4, 1); break; default: - av_assert2(0); + /* Everything >= MODE_SIM is impossible: MODE_SIM is patchwelcome, + * > MODE_SIM is invalid. */ + av_unreachable; } memset(fixed_vector, 0, sizeof(float) * AMRWB_SFR_SIZE);