diff mbox series

[FFmpeg-devel,6/7] avcodec/flashsvenc: Avoid copying frame

Message ID AS8P250MB074484260CA669C6C69EF48A8F089@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM
State Superseded
Headers show
Series [FFmpeg-devel,1/7] avcodec/pnmenc: Check av_image_get_buffer_size() | expand

Checks

Context Check Description
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished

Commit Message

Andreas Rheinhardt Nov. 19, 2022, 2:59 a.m. UTC 
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
---
 libavcodec/flashsvenc.c | 36 +++++++++++++++---------------------
 1 file changed, 15 insertions(+), 21 deletions(-)
diff mbox series

Patch

diff --git a/libavcodec/flashsvenc.c b/libavcodec/flashsvenc.c
index f42ef73b37..3c3d9c8813 100644
--- a/libavcodec/flashsvenc.c
+++ b/libavcodec/flashsvenc.c
@@ -48,6 +48,8 @@ 
 #include <stdlib.h>
 #include <zlib.h>
 
+#include "libavutil/buffer.h"
+
 #include "avcodec.h"
 #include "codec_internal.h"
 #include "encode.h"
@@ -58,6 +60,7 @@ 
 typedef struct FlashSVContext {
     AVCodecContext *avctx;
     uint8_t        *previous_frame;
+    AVBufferRef    *prev_frame_buf;
     int             image_width, image_height;
     int             block_width, block_height;
     int             block_size;
@@ -89,7 +92,7 @@  static av_cold int flashsv_encode_end(AVCodecContext *avctx)
 {
     FlashSVContext *s = avctx->priv_data;
 
-    av_freep(&s->previous_frame);
+    av_buffer_unref(&s->prev_frame_buf);
 
     return 0;
 }
@@ -193,26 +196,19 @@  static int flashsv_encode_frame(AVCodecContext *avctx, AVPacket *pkt,
 {
     FlashSVContext * const s = avctx->priv_data;
     const AVFrame * const p = pict;
-    const uint8_t *pfptr;
     int res;
     int I_frame = 0;
     int opt_w = 4, opt_h = 4;
 
     /* First frame needs to be a keyframe */
-    if (!s->previous_frame) {
-        s->previous_frame = av_mallocz(FFABS(p->linesize[0]) * s->image_height);
-        if (!s->previous_frame) {
-            av_log(avctx, AV_LOG_ERROR, "Memory allocation failed.\n");
+    if (!s->prev_frame_buf) {
+        s->prev_frame_buf = av_buffer_ref(pict->buf[0]);
+        if (!s->prev_frame_buf)
             return AVERROR(ENOMEM);
-        }
+        s->previous_frame = pict->data[0];
         I_frame = 1;
     }
 
-    if (p->linesize[0] < 0)
-        pfptr = s->previous_frame - (s->image_height - 1) * p->linesize[0];
-    else
-        pfptr = s->previous_frame;
-
     /* Check the placement of keyframes */
     if (avctx->gop_size > 0 &&
         avctx->frame_number >= s->last_key_frame + avctx->gop_size) {
@@ -224,15 +220,7 @@  static int flashsv_encode_frame(AVCodecContext *avctx, AVPacket *pkt,
         return res;
 
     pkt->size = encode_bitstream(s, p, pkt->data, pkt->size, opt_w * 16, opt_h * 16,
-                                 pfptr, &I_frame);
-
-    //save the current frame
-    if (p->linesize[0] > 0)
-        memcpy(s->previous_frame, p->data[0], s->image_height * p->linesize[0]);
-    else
-        memcpy(s->previous_frame,
-               p->data[0] + p->linesize[0] * (s->image_height - 1),
-               s->image_height * FFABS(p->linesize[0]));
+                                 s->previous_frame, &I_frame);
 
     //mark the frame type so the muxer can mux it correctly
     if (I_frame) {
@@ -244,6 +232,12 @@  static int flashsv_encode_frame(AVCodecContext *avctx, AVPacket *pkt,
         pkt->flags |= AV_PKT_FLAG_KEY;
     *got_packet = 1;
 
+    //save the current frame
+    res = av_buffer_replace(&s->prev_frame_buf, pict->buf[0]);
+    if (res < 0)
+        return res;
+    s->previous_frame = pict->data[0];
+
     return 0;
 }