From patchwork Wed Mar 13 23:09:31 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andreas Rheinhardt X-Patchwork-Id: 47034 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a21:9204:b0:1a3:31a3:7958 with SMTP id tl4csp103449pzb; Wed, 13 Mar 2024 16:10:12 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCVi4pNoixfRYRZffgSP9aRVB47XOjE7hpRcDmCWFMUR5OiBqxz44u7eQfzO4+sOoVl1fN48JoIrYusEZYOFpuAgdwS+WuTf9Ct2WQ== X-Google-Smtp-Source: AGHT+IGKLe4fWkot/L9Fd0TFkk5IjRJQe7LCaFlZE7jxrl4nfEN529wJlG7dqfnfJg7izTMxtRT2 X-Received: by 2002:a50:99d7:0:b0:566:47ee:b8b4 with SMTP id n23-20020a5099d7000000b0056647eeb8b4mr3280260edb.17.1710371411919; Wed, 13 Mar 2024 16:10:11 -0700 (PDT) Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id ck26-20020a0564021c1a00b0056750fa2e67si102191edb.407.2024.03.13.16.10.11; Wed, 13 Mar 2024 16:10:11 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@outlook.com header.s=selector1 header.b=elpfoRMj; arc=fail (body hash mismatch); spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=outlook.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1FF8F68CFEC; Thu, 14 Mar 2024 01:10:09 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01olkn2078.outbound.protection.outlook.com [40.92.66.78]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 0E20A68CF55 for ; Thu, 14 Mar 2024 01:10:02 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XnRYa81B0odQtLPg4gCzrO62or9Cm6HWDkWMQs6FHDzAyPOyA5+Szn5mLoBDVwKW7vGpCbJ72CKVxo/+b17ox6/7CNu+G1o7CXIgvZZ2PchvxUK5klKeK3RrpN9em/cxhJz4C6Wb7egk3AqE9xKTjSyn7GQiNFwiUj3VR2vTAHCZ08eiGgwNwQ9MP7doltDMijb/bq3wyKCEalv2CyVclMB80OPIi1q/Y9m+YtVlWH0bf90wlYnifyfY2zzkoibecMgJGSINGwv77NtjJfP8iY77kgIWiKYRMNjkhCtnjEbK/KTXEeIz46XqXEsj7sPDZo8YZU5sQlDa3Om/KxI9fw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cru+c9BMzwF4bhUV7MYtKBSa3turvf1+Po3MdzJG580=; b=gQks7IOZl7LM29c7haVWOmlIj9QFZyKpzgGKzAB9NuH4L2DTBifKUKF+6sV3VzSwxl0ns63hDnQUGltA8WgLJChYeAGi8kMZpp0KBbrThv9OG4nuK3qUe/DnkakJO6uCMqkqsKoRFvHxDWgdwtEOVBnIitMUhmVyXOL84pbZ3IJoFmnjsOZDMptJshnhzXsCp7YMJnBotUiIHPJso5y5lnRII58hu7EJ9PbciY6JGK0/qL0OOHwE7Yt4dOy3QP+LwVqT2CTkeoezRCFORJuTNdLClUxVWXnNVbpbJubJQJqZb4K6v/PolEwxm6wo0ZBHxLc33HsKfmgwMluwbpAhPg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cru+c9BMzwF4bhUV7MYtKBSa3turvf1+Po3MdzJG580=; b=elpfoRMjHJFej4t/3BNDvmmV3o7G0gqzxNAW++SGC+o3lypdcjfTdvACnFjBUyb7EQEcHd2gOGrpTeAnEhLKMVwyzfZLM+L5Zf8e0eRYtg0vfnZ96WBYHB6/2eh0wrfiTd+YvPlTNiKLcCyl4b+MvzohQf/8quf+JW+pNv/pXhPvDFszVdkucK169YFW5xhlFsavaBkpMzHAQeudPv1x9oI8qpuvYC7oXuJnrZqjAITe6SfDv1ImP615B0hkhzIh1cT/3sR4V9Tt+krq5nOXWPip/WMycB/cjJ8n8JZ+FdIU+u7hqWCHuPPrTvY1SgehWoNYz/UdsY5akKJmKtyTHg== Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) by DU2P250MB0126.EURP250.PROD.OUTLOOK.COM (2603:10a6:10:239::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7362.38; Wed, 13 Mar 2024 23:10:00 +0000 Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::228d:8c6f:ed10:82eb]) by AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::228d:8c6f:ed10:82eb%7]) with mapi id 15.20.7362.035; Wed, 13 Mar 2024 23:10:00 +0000 From: Andreas Rheinhardt To: ffmpeg-devel@ffmpeg.org Date: Thu, 14 Mar 2024 00:09:31 +0100 Message-ID: X-Mailer: git-send-email 2.40.1 In-Reply-To: References: X-TMN: [dICU/rPirgBB4Ua1jfb/wbEEUCWvJZ10lhdu6ry7kLQ=] X-ClientProxiedBy: ZRAP278CA0003.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:10::13) To AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) X-Microsoft-Original-Message-ID: <20240313230935.3058793-2-andreas.rheinhardt@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8P250MB0744:EE_|DU2P250MB0126:EE_ X-MS-Office365-Filtering-Correlation-Id: ea562723-2c21-41ff-140e-08dc43b2b54c X-MS-Exchange-SLBlob-MailProps: 9IecXKUgicDyadF/9QYgeT/1Wlu6smXx/Ihk27CaRz3I+FsUFFtDIEWpt3JyYRHA4GhnJ19JtXjt8gOYv1JNhwtwmEMoTZoEDdMjiQG6Xp/nghUroP8Gnnr6fLKWAADkBwGEudG0ohiwMtJxvKy19N5V7O0TI3dbWMp4xnxKtXioyf+kY/srZ5qnFs6n5fPegYEoWANMs86lK7PM4K0+/YKFGbBBxmnYkdTxKH5u2MahNv1dgIJDjvNXKAQFpFq0oRc21hnRq6/UV5zuGKT42/G3PHtt1/WN0eGHkwsyU4iQlxD8bad4Fq5vAAMGRoZkz8jA3plb/AjyIewFgkAJY8Ra6k+kqRCU91mrU+LTBSQAV+Tv3N/JuDxkmceb7eIkko68mf1JRTb9/luZouRMnCt4W9h1Pgq19oIgy5ePRbn/Ln1pJqFau+wTq/SVmBDhvbi12rNdIotvYucjkrP9pQivgnfktF9Om2Qarbj5ME3Do1qrC+YlTc8eB9/vGxm2teaTEOi7z3PyjRQYyOEYXyJDxVDnykNVbBWkIphmQQNed0iexQcG8y9XvYk3KjopitXp4CdWjpvdGvuGIP+QZy7Z+9wZRdp5ctUVsLl2/WDtCjewUN9Uv3nZ4Y0Zq0yTmNfeizE0TnAnnbdvHa3Iod2xDRJpLZXX8KlYs0EW0/nm6Fa6LCNqjWL/shgAIf2OV9Ted5WSvFhe0LMAQ5Pg8IS2pRzC8M5PgNN630fQWOtTgtyqJirFuw== X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: C4x3no7FxgPrQEK+1irwyJREYE9msU8z7TRhNbLixcCYAb2Ozf7R5S5G3ZmerJ3ZW1alJcSozKuy38cXlNP7vdKzgLk6HWiQO6MKJsgrip7fAjEjvkdoQ4KiAX+X0AbhbxnjcrJy0LIU+RjQ92wCWSAFjxweZW2vbfFBtTny18rCC9f0UPCQnhJU+MQY4owjn3I+ZXhOQqP4eS3J+EX+CjiaZYENWE+FP5IV55Ydm+txJBuq4kr95qonXpjlZyj7QFNwm/jJFcYRR4kV+gKfjls95Rhjp7vTvD87hzzmwOf6EcFEUMnFmNKGEveOlTSdyzmHU7atyhNdRaCiZd9hjDl4UdgeUAgWUnPJEA0epvJZqunL+EyM5uqHutwSSKKOwfvCYScpmxgqbvfehzWZ55bkvwwCduK84uTAMSx6GIjuGLp+xcI31pqF3WONzAn5GJJcf70lTwU4/80o3hMj4A6kwiru8IJvS67LGws6WsqKkFK2wdNSXCFsWrdrPOjJFDQNC+cqxgRCdTrzkMaczdap3wpk4ZbDcXRIAvQDRcMKgYxmLH+pG5FGRNur1pH1xTA1kc2N/Hzp4F93pgP7rqO92FweRfMjmaNvU9HHKUkjXtgwrC8m1bHYk7WT0C6F X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: UXgXKW5pMuUVrVh8RQqujr0JGvTPd6ZSyuqjWUQsNStAgloVb48nPNYNOxPHcAvEPODq8S/x6iAvf97fwM4dh1IygZiuIQqNOVWoSmNfvNdH9opnA4bREvY/JHr2rXpFRcwKfDRSErizPOiP0XdNGCiJsuhmm0tBg1JD9hW/so/8SDB0V101xp6JXQ01n0ZwrocefuiaM4qwHdMqx0Qs7gxbX1bf6tUVQf886FHQoMO4WiHac8/v015qyO6lCU6T8V7AoV0J/R0B/VYbo+2GQ9BOvTnWcXRQdFwCo4Yy8k4i5JSNKfAx2jOah9mE3sq6/GSvR0mhh1nRUSpVOzOqazYSeVPn1cSUudFwCeAmb42JOFj8rAKVBM/WUv5jSbUTY5tZ+TrW5jDM26v41Mto4u/Ady+R04imFRIYu9CXDgKEIRSTanURrEeT6mEWeAMwrXM6eSTuJCUfim1bz/bfseFjin7soYAQpi2V5ybTuM4vwY0c7od26VN5+POVkknHwIsA8hlwx25UChBDv+iLAq3GDswKoMxLr2O5/f8/hhpujYf838IbsecHwT/Y0g8QVUyrytsi3G2x2D6h1QX+TTgmCVAwEk04/chbnn3BOwUp657NrTcIRxXRQ28mTuvxSf/I8nGhMcSry0IZ17uijq3tqyVMmUjzkiZQO4srAvNs7o+29qCwP8lbyfWhvySY6nEvv8HnPEB2EtAzDLC0ZvhIztpFqqCpHg6gW+pFaUZV9HwoP3wG8dJVS51VbpSOeGUkJWDBw3LQOsQJVqrA/92E+DaZhdwRBGJ7RAHUAAfkPcTlcqsNIs3+/jnxDcO633VRjYlasj0aqKI5X4K5M9F5k5P6gJ6p9RSekUAzvqUNK20/4wYexp/NI10G7lx0/GvY8kSvMlO/Q9gRF2zAgJUZ3MYHYT970qL4+4nukXLAoaXfgLSJzw/Uj34XaHIN2KyXZ/XQ0hHTAuFNwd+g8uz+OAeswES0XQny/pBZ6KpGoDirOE3b/R/w4/R/Y/JU7EUSA88WzJGihBW4TSw+RbvwMGPAGpT3gjlp3jvjUFHlN5JbpUpXNSEd87hKUZt2Rym6ezBNAXKGXsqY/QBWQFofDPveqT9Z5FtchNy+8f0OxDeORMHExA+LYg4fFl2ek9VOIv4TJPfkPx+bUkHvK901D2vYPqjyZGV9TMag1dGafpchG9qtDTt+esWzCgGNbCQVmKBUqNh3QXmxU63nJY/enmP+Qvbgz5i5R5yw3qs5k188vVsV+nSeHYxVla3PeXa6VVtF+qNllxZEndYt5g== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ea562723-2c21-41ff-140e-08dc43b2b54c X-MS-Exchange-CrossTenant-AuthSource: AS8P250MB0744.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Mar 2024 23:10:00.6576 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2P250MB0126 Subject: [FFmpeg-devel] [PATCH 3/7] avdevice/alldevices: Mark devices as hidden X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Andreas Rheinhardt Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: xkln2Hy9cqNL Both GCC and Clang create code that inlines the loops in next_input() and next_output() at high optimization levels (presumably when there are not too many devices) and this code leads to the creation of .got entries: e7: 48 3b 3d 00 00 00 00 cmp 0x0(%rip),%rdi # ee ea: R_X86_64_REX_GOTPCRELX ff_alsa_demuxer-0x4 ee: 74 43 je 133 f0: 48 3b 3d 00 00 00 00 cmp 0x0(%rip),%rdi # f7 f3: R_X86_64_REX_GOTPCRELX ff_fbdev_demuxer-0x4 f7: 74 41 je 13a These relocations can't be fixed up lateron when it is known that the symbols exist in the same DSO. This commit therefore marks these symbols as hidden, leading to code like this: f7: 48 8d 05 00 00 00 00 lea 0x0(%rip),%rax # fe fa: R_X86_64_PC32 ff_alsa_demuxer-0x4 fe: 48 39 c7 cmp %rax,%rdi 101: 74 55 je 158 103: 48 8d 05 00 00 00 00 lea 0x0(%rip),%rax # 10a 106: R_X86_64_PC32 ff_fbdev_demuxer-0x4 10a: 48 39 c7 cmp %rax,%rdi 10d: 74 50 je 15f (Note: It is actually strange that the compiler creates code that tries to read the addresses from the .got given that the addresses can be read directly from indev_list/outdev_list.) Signed-off-by: Andreas Rheinhardt --- libavdevice/alldevices.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavdevice/alldevices.c b/libavdevice/alldevices.c index 5ee97c56b6..6396076ecf 100644 --- a/libavdevice/alldevices.c +++ b/libavdevice/alldevices.c @@ -18,11 +18,13 @@ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA */ +#include "libavutil/attributes_internal.h" #include "libavformat/demux.h" #include "libavformat/internal.h" #include "libavformat/mux.h" #include "avdevice.h" +FF_VISIBILITY_PUSH_HIDDEN /* devices */ extern const FFInputFormat ff_alsa_demuxer; extern const FFOutputFormat ff_alsa_muxer; @@ -59,6 +61,7 @@ extern const FFOutputFormat ff_xv_muxer; /* external libraries */ extern const FFInputFormat ff_libcdio_demuxer; extern const FFInputFormat ff_libdc1394_demuxer; +FF_VISIBILITY_POP_HIDDEN #include "libavdevice/outdev_list.c" #include "libavdevice/indev_list.c"