From patchwork Fri Oct 6 02:46:30 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andreas Rheinhardt X-Patchwork-Id: 44174 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:7b1d:b0:15d:8365:d4b8 with SMTP id s29csp116961pzh; Thu, 5 Oct 2023 19:46:24 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHcBoHWxE4rKZK6v1FoTwe+iGoLmiF+jl6oiqgtkUWzZiSXU2TdZKdgOd59HRBGaCfzhpo5 X-Received: by 2002:aa7:d8d3:0:b0:52b:d169:b374 with SMTP id k19-20020aa7d8d3000000b0052bd169b374mr5879727eds.3.1696560384275; Thu, 05 Oct 2023 19:46:24 -0700 (PDT) Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id c14-20020aa7df0e000000b005340666a3e3si1176640edy.589.2023.10.05.19.46.23; Thu, 05 Oct 2023 19:46:24 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@outlook.com header.s=selector1 header.b=cMUsCUgJ; arc=fail (body hash mismatch); spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=outlook.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1966168CBA2; Fri, 6 Oct 2023 05:45:51 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01olkn2036.outbound.protection.outlook.com [40.92.65.36]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 6B6F468CBA2 for ; Fri, 6 Oct 2023 05:45:49 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GCbVc8NbLXYyzbzC9xxb/ZGV8JYPIDkZ3y6a8RGxPKc73v4hh6sKbIKnu/djvPTN79bZtmmJDam/Ozf2BciJVh0dGBKEokLskgLMiwDtIGJI3FwQFYhJkNyTgOFwKYx0wWkRes8iuQXrpk4vCrxwc6MuGGK4T/+kjXVp5iDYHCPUFnn38wnIGtQoHPFSTiVfKWo26V/CUSnuYbx1SrUGG/6cUhcWPNuBBm9JggWQL5reenxLEP2CjeWBs63KFPmhdE5FaVcRFrcdTJKFhGxLcOC4cp7RF5jCR53XGffoni6wGvmtGjK34dq33ER3zmw+ITF2+4QZRCH5oGvN3jiapg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=R6zMI2tkZ7WdWpZlsQG/NProGBzJpxMgdP4OTP+mhDA=; b=KhL79JgRBasGe7s521+MM7xCQX65ETbxZ4FRhB8LdKg2YExb/Px33DxZlwsQBZoE7UYTKlTsyIFMkqceih1kXPUXdKAkhlwRtvd6dlLVOKuE6qfJ4hUb50jLl4eJiv1L2kcXJwB8zH2yJAETxm9QnxhDjgS+EQVl9MBFO5vix4H63rQFDPrupRV1ylzzmGTxRq2nT/vRXWI+ES0yV4R0T95HRy4wTZe2XO+Bivk03Y2cplQRfjSk2P3u8xfGIxZsMd8WTugS+RfTIfrK+lBXhEjvizOkdERZumOJwoSZ7ellX42Rl390/KMo5LFSG3Z0clohwC2uiYaciZTTXigv7w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=R6zMI2tkZ7WdWpZlsQG/NProGBzJpxMgdP4OTP+mhDA=; b=cMUsCUgJUtTyRBCMy9S7EBz9HonVhyPch2LWP03ItyONV2pxR3/higZRgM0kVZ5PIEp49Ih/XDrvlZqWq25opNPZg32ALz0zNAqP4Mhr6/TECEW3TRsRnX5WzNYcDysZBKL53RlqZxW3J3+GLTNT8xkHyel8l3oY13kijnzZp8/N9WiwN1QuOhGqC85OVq+uHktM0j1X3EyGpCOaSgoAZa6JtNre/zwpXI8Y5esOdgMrQpgEIDh8VlSffyEbMW8SUWouDRs0VvLWkieA3SKZu+CFDUvK6wxDC8d7rgRkdFQQRuAVNLmJ7e5DOqQM7nuaVlOLsspw/v5G7+ieJoDocg== Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) by DU2P250MB0148.EURP250.PROD.OUTLOOK.COM (2603:10a6:10:275::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6838.37; Fri, 6 Oct 2023 02:45:47 +0000 Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::5e01:aea5:d3a8:cafa]) by AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::5e01:aea5:d3a8:cafa%3]) with mapi id 15.20.6792.026; Fri, 6 Oct 2023 02:45:47 +0000 From: Andreas Rheinhardt To: ffmpeg-devel@ffmpeg.org Date: Fri, 6 Oct 2023 04:46:30 +0200 Message-ID: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: X-TMN: [m2IwSVkpxYTVi7OhEarl4D30MM0uYfd5] X-ClientProxiedBy: FR4P281CA0094.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:cb::11) To AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) X-Microsoft-Original-Message-ID: <20231006024636.1005349-6-andreas.rheinhardt@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8P250MB0744:EE_|DU2P250MB0148:EE_ X-MS-Office365-Filtering-Correlation-Id: dadf3de8-a237-4fd6-0bfe-08dbc6165832 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: POmh/LlKKoDp7RTyu30na/uFPHVIzHevCCXCBXNH1rjo5pCN/yJh75TQ3aAO/E9d6qP3h7Is53ZLtKAAXEp/OPP7uiGiQBN0ANCo9FprteS1x0j3eC9yII5fVdUNvpAbwyzTVYQh30Bn732RElRQCdIxnnGLHbTvgcd6cRe80ghBZy+ptV+GSSSGg2YQA/erj+VmzS3tiZIqSn8BQ+4q42FBpO+t/aEkrxr+s6ylJ7Zh4EcOQCCMalI6WJAl8sbYn2r8Kmco3NTiiSFKQYx0ot90dlYfmgCN7dkoASPIAwben3/0JSab2batnKHkrayOOh7+E8jYbzxNxKE+6k7Mb86t/j45oq6qRgf6t8W78DjeBYXZQYgvlVlpQmKKFysJNX8wFgUB67irshclXxoaJZfelSvFVJMMpuqg8dEwUlh8/00Hnlt5RjGoldxldn7/a/k5N3Q8nLzdVnzntYq9137pMA6M2Q8j0urIjZnTjQhCIvj1yQUGhtU0duWSSU/FaUirlGw+RzAAR8LVrwHV0M9OB4YrgLFRzTrldrkA1t5Qe/ob/JfBtt9ko1SVBOtXidYAEUEcoV+9SxgjNyJDHv5+UOUC7Rx/rDLR2N0soptA8HsMLsq6PATaQG/wA0Do X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: XUTzU4bfdyPAnIjWj6+XklfzTIcrW7utMbpzhkGhov5SippMuWVFx4tNp9efqWJfyY0ecyo0mxRtYkm4JOW5Z4f5X2KqE5d3DxFC9fvd8eVZf9PiGHb5wQeZhOLZ6kRu52XmtqVAjtahpHku4nhgTwyuHAzKYHNa1v8pcxHikPZrMgr3QqRZX0ZwoUVwYMLk7K9sPqU5Bgf+SwRcAt7d11kWMRrffi9THA/KNoj9fLK43RCBZyZFLuUuAGBU+TCtK8it4lkOvTdoRGF40sIwgRFceZ1sYWDkPKdAr1ip2AaT3eCVDXTIeqVIOhAZIERtw8lijVsv3Fh+lRdpYMb0NauSuRotAoE8PsV+Jdo9uaCLdoUaP7E0GTcrFdtmtlgY/99wt/KwSlCihxLZDu44cgLZsDOa1A+HSkGDYmCUkP4/XXsO05PCEgpHBAynXuUHYEjLacMcDmlxOnKeARRIMDyAAGtGYEkFprT9VwDn/ukO4AZaS4W3JmXua7TOoL8IVTSg+wsAJkSKks6MmZGJ2bkMRLo0Lnr8Jbx/gvKM9vcUW5aelTG0DMTdSedPVMauc9PHEZrbnHKw1nGjQtnqHYIlvDXZ+u5mw43iGAE3spjh5p/J+7hop7JJwuLnfkFF2KzlheI7rl27d828KIBobSvSMGQ3BFFtxn1SE/3TO3XUasNtD7IMM+RD/ULD1nuPtKKMtBJkxdbsHrVs8VLCeocHQYA2JSuYbyAEuMJjTT7Cpe5JHg6dlBNRFIDQceWGC4BHYc/7i16uOLFdG0Y0fJVg9KtCauXJOvs2+lGDwysKlrBK3QVS2kvb0ynXyS9Wroa9bxIts59yI3UHbWcZSxkqHbE7D4QLxuNEd4e34Nh4pUUzFeP8jyj3kqaXKFQ2/MMh/EOb/yD6Ldu8EXImGoODI97k4iN2n7nH5cC8yHPxbT8vzKHYJ6w/KDv3TQDTrJjWyzd52j1MADLrAM9wCFhOE4nhFSFxiba1hWJJF2sgKwXxUuJruyDNLEit0I/yxjVDPyY2PAJh8qHb8BCLCssKcUMwWVK2FMq0XA5VH7A241nSlJzBre9mWjPNlbQpxhv54336ADKilxjUtvtLI/g1a7J0lXvBSHCvlp5kSezMMH9reOp7JmrH563PpoCiYHDeJhhOg/ZRHN/+JipVxveA9cbayEmP9QHGS1g2GKJ7Q4aCpC00HS9ddvP3g5Vye8qGwGfGxowcjDsGVk/0GzOLKcnbFtjRQIzdwH1uRcdyo8huNtu2dDkKFUKhau7r X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: dadf3de8-a237-4fd6-0bfe-08dbc6165832 X-MS-Exchange-CrossTenant-AuthSource: AS8P250MB0744.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Oct 2023 02:45:47.6598 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2P250MB0148 Subject: [FFmpeg-devel] [PATCH 07/13] avcodec/mpegvideo_enc: Don't set write-only properties X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Andreas Rheinhardt Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: Tx+EVbNlYBoF The frame is immediately reset in the ff_mpeg_unref_picture() call below. Signed-off-by: Andreas Rheinhardt --- libavcodec/mpegvideo_enc.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/libavcodec/mpegvideo_enc.c b/libavcodec/mpegvideo_enc.c index c06fdd08fe..9e28304554 100644 --- a/libavcodec/mpegvideo_enc.c +++ b/libavcodec/mpegvideo_enc.c @@ -1698,10 +1698,6 @@ static int frame_start(MpegEncContext *s) } s->current_picture_ptr->f->pict_type = s->pict_type; - if (s->pict_type == AV_PICTURE_TYPE_I) - s->current_picture.f->flags |= AV_FRAME_FLAG_KEY; - else - s->current_picture.f->flags &= ~AV_FRAME_FLAG_KEY; ff_mpeg_unref_picture(s->avctx, &s->current_picture); if ((ret = ff_mpeg_ref_picture(s->avctx, &s->current_picture,