From patchwork Sun Oct 23 19:34:12 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andreas Rheinhardt X-Patchwork-Id: 38918 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:4a86:b0:9d:28a3:170e with SMTP id fn6csp1859178pzb; Sun, 23 Oct 2022 12:34:36 -0700 (PDT) X-Google-Smtp-Source: AMsMyM47sSb0XLkhGxQTGGp5v4tBcN92KM/ZtIrxj4NzbFdrTDk256DPBvOcbc/fh4RD0Qf+fzSk X-Received: by 2002:a17:907:7250:b0:791:9093:47f7 with SMTP id ds16-20020a170907725000b00791909347f7mr24632020ejc.278.1666553676009; Sun, 23 Oct 2022 12:34:36 -0700 (PDT) Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id mc10-20020a170906eb4a00b00767e24156dbsi22647381ejb.256.2022.10.23.12.34.35; Sun, 23 Oct 2022 12:34:36 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@outlook.com header.s=selector1 header.b=SvQ1RmwR; arc=fail (body hash mismatch); spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=outlook.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id EE8E468BCA5; Sun, 23 Oct 2022 22:34:31 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05olkn2021.outbound.protection.outlook.com [40.92.89.21]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 2BB3C68B4F7 for ; Sun, 23 Oct 2022 22:34:26 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HNpDDD0iv5Rp06GUWNNqLCOi2upvWr4J2ISi9ZEkWrg7W/X4zsrbNm2Wq7ZvlGXJXaErLG7popm1wAW2lf/eyCM+enuECK1r5eywSx3T4KsLmas4Apro5ZnNXO19dlQryCQh0hqG5R+YIOHmmFgtsUCwWLa2fpP8y4cmsItSTB7VOEwdnmN/wzqyFO9nzjVAs6NvDYZHnauJcDR2IhY1hqdpV59HlaxdliLsRXAjejWrOVM7/WlnXAvm51avwnAIwuMVcIHHCmLI5ysDwMR2LaIIIYTpuad4r6kNoDyIxFRRSLAouDxGxqu+AmRElwuVv8/uSIiUpfblsPQglMOt4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=b7vYdOhZA+c0489rAvJuEDoWu8WZk0EZO+qsQ/WI9sk=; b=NvaxPaTKrh+pSXJmr+6zy/KDZJGqEY3o/14hrs36TW5WQg2q16T9hFiQ8hSitSvYdh1vVTJqfIqM1ccTN/WCDJ3G1ctjh17Mdyl8e0CHw146ctxZFMHMg39yfQJI3D8GFgs0K/9kSTeXSRqu4ijKhcmOgRZLpJCwnU7RND0onJMS00O1pnzPSbhn1WzJOJvYl3C3OW+usCkJqQtt08vQdNNY/MuIEZ5HAHR/t/x4Bi8ZRp/qSHyXDkod739YZ71Nigndy3lvirSSkSauVjeD2/sDDRi8yldqJ2pWpxVmkFs9+vxyB2nAexZxiqdc/Lm+4Mc3nVbJ98U9kAGNM4rZig== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=b7vYdOhZA+c0489rAvJuEDoWu8WZk0EZO+qsQ/WI9sk=; b=SvQ1RmwRzraFDn11gYznVIvNqz9i8TMYUZcIhY3VhxShdRZjgHcZk9zksWwCBgD8Wo9QVEa68mERIpjny+F1xdmvv4Y/047xZ9v1skP8qC2N7mzaZ5hoqndkgTMU+Mk7A/XGg5SJxjXN+1r3yZ7B7U8JzZxBvdWHh5tOEl7lR6WYYrhDt4RpfH+Tm5isXV8C+kudqurH9FfluH6fj5rNKC/i4egovdmzDIR5M5ZQy89UreT8SPHr6/vaHry5r6chnVcpkWNuEiX/mxuLicu6c1hYJlyX5sVToqfTQNrSSnDJk69itUJtr37TUh7+5/gE1rcfFrs9Y7vXO/zlcWzIng== Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) by GV2P250MB0825.EURP250.PROD.OUTLOOK.COM (2603:10a6:150:aa::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.23; Sun, 23 Oct 2022 19:34:24 +0000 Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::f9d7:680f:70c4:44fe]) by AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::f9d7:680f:70c4:44fe%7]) with mapi id 15.20.5709.015; Sun, 23 Oct 2022 19:34:24 +0000 From: Andreas Rheinhardt To: ffmpeg-devel@ffmpeg.org Date: Sun, 23 Oct 2022 21:34:12 +0200 Message-ID: X-Mailer: git-send-email 2.34.1 X-TMN: [K0+hAkETkmu7fEdh5QrHqEKOfLg6q+gN41VkRTkt4bU=] X-ClientProxiedBy: FR0P281CA0108.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a8::8) To AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) X-Microsoft-Original-Message-ID: <20221023193428.673747-1-andreas.rheinhardt@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8P250MB0744:EE_|GV2P250MB0825:EE_ X-MS-Office365-Filtering-Correlation-Id: 55d142ce-655b-432f-743c-08dab52d96eb X-MS-Exchange-SLBlob-MailProps: AZnQBsB9XmqH3kRfXJefTqIxzT/YbMNWXMCgcuU90+Y/g0UZzHcVA8ZDzjvllmcces7LKKdfCV30hGo12m6tjh6SaW1fwYBDtaVqn0UdvYFW5u8/ngOhrfv5z2grTQjEjA0mNB7qtFPd86rQqiL0ZQDd4inVodM/Ox3hUKtncTuQJSB9oCQ2bpwfjGO0Y+4oHtQkoeLMtKvanGZdIXyuPXaDTUZHUCwZidll5El5bPCnGNVg8IxYBelrXZOUX/6U4nrcmJ7l/3iAMQWIz4fHX9Ff/nukyCQRnlRsqtNbMWYHKijpefckTC9wcgSEkptmNrnvF/KLvtZgzJrK/8RFEwrXtYrU1IFuQmU4DwylldvDVbeg8J9Ar47rz9xwdICW6q3zPwRIDcGKQoY6sJ7lfFypl+YBEwrAVEtIyNSONAo7ucEhCmdDAY6tfMavVvmeZcb1A1rkgKVpDcNy5Ls8P0lnFoSXKDKO1eaY3j9oUTQCJAG5ji+qFO/3WPNTT56NPe8oRYPATlh9K15bjKGwzkmBg0XFDBzff98sbY/Bax7XxZvwSqMyFZazKcH81ncdBQGGXyy47j+gUVbKLX7Rsa1aBh+WI4m2XoG0n3nj7YVsQ7TG4jDorp0n41Os7xpk24O6lUyr648FMkKZ3IhGKPZVIRf6xWi50UyUUwlx8u/VS0R7kUahVFi21p5I66ZLuHychWCMnthnnDNe7V8jygl20vgswYXzl1KYqOjck25V6UgoRau5PUAqa9AcTtgj93N9NgGfXmE= X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: myDb6l4mcAJCDISnghoBnkeudh0EnXrn7fXCAi6b3qhSZVeF4aa1MOg5iOOewFVytjxwD1sD/+k7lR6H4IXNFaJ2zkwE7cgQG6TwNb/vFIgMH1spoKs82QBzGvhlhv6aW314vMncuKR3BMR5RPeQELrEjeJ1Qg676XM38YoY44Vjt989OF+g2Rzz/WOBG1p2QEN3pEmJiNrZkvsptWAXCaBNtHSg4toOPDEhJy/lhp5TYSzOd3hJLepU/1WrrJZ4zOtV/VHbJwC72cRDSw1Rj4GVQ88VfJd1o1p74kM5AhdvxnZe00LurjlZfyV+w04M51rtTHvEWdKR1aJ/wGyE04ZZRFp0Fpmis6o2I9Hfn7ZfzmkB8MhRNJ7AcQYJAOQIuQJnPusl81i/S8yDBXrqW8sSVT+IgNQ18EJQ8xbMER6CpldoCe8r+h0tlWWeu0WY0gudTKDnI7kuPl22nqNqH2JN3mYQWRva49OSJE8WtCK4oz2P7sLPtBdSAel/g+jj2OhhYanKqoWv62uWH40gEQO6n0GMO4zNhuL97H5SGfF3R9Z9rKjSbOWvb7GjKjkNtyDyGBctTPjchYSo3Diub93gvr9Nj1OYuoYEqf2neOaqJsiUbhMRxFlz+TmVGzTwTiHWNbpZeZIEMYCPZfgJQAyWyuBbr59Kt2uomVtLHN9skYzDNntFgA0FW2sXughP X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: FLZaVJsxydSFqV6nlQqwW/IRjUvm7ZTfkr5PBYY9dM+Lc2JI4bXNIbFOGNBvn/2HVe2fT1lqkcb6OliTtjMu4IqBi6Q1o6zpGPT7uxWviK/otJFTfNnCCv6Th7snt+Snn0MEmdlYxhTdqGlbO0G4MTRKzYqIqFFKjzEfeCiizCMX9ljvuLDlmMI8h+axq8+MEGAml7UGlJokAdyPsFjVX+1Hfb9N0SLbY9fXgw8WMpRSc1VS6cu+pMq9M3pEzqxv15Ka7ZlNkq+RidQALe9wd7kLMJEh1k+YzD5JkFTUSO41cE1SHqUS/dZVyHJ4OlkkGKDPb5gLSg0mvsS1oQmEG4oOSgckBFnYOA6bm5iESUsXO6GDvlItuUDlB/WbGBrBhttrb/N6rCuxhzeUimeAqLM5oYBTcHKMLDQNO8+1y2tuoL4HMhOI6/2vVhHilFJ82Vw8P66ZxpNFy9liTdgj6jdDlyvmInXes8KWPVx4mqvE5rmrW7Fs8pWN4n2FbNVZoX8qajnuwv5J0RWqzf4ds+cRI1mtMxyJpHpcp3TPuuJvVr4A3N7nFSHUZo5l17XCIlreAAw7bhRFF0x453lPTJvOqdoynx+tYuz+zYmqFpcLGtjW/9dHnxDkFsaWBXXesxbAQ2XPDOwDdec3QCxGrm97iSdKdPduYVqBTLJngFnPSNOa9pU40mq0FWbauo43nFD8klu0P60kFoS9qTfs0L+F82sYWFgII/4Yci3ADeRJprI2NkpTT0TJhb84H+MGIfSjjkGmsURVpJYBN5XkElkzZlxYVw3fccFSJrhUlTJEg9JKV1ISHrjNJWdFFoPL1E7TXiZsPnJtacwqnqB57e3+/tikDOoxoqg/80dKUSWKCdeqCCLyUywhOV9hHz+66y6ZZDEeLRCtE56CJIniHQJU3eD4HEcBMCuisJ4z75VEOVzff+Jh7nlv+YB6DaAIqRzkXSX+PrOIiiMRT3Wa9n8JeIs6QfHVdLrnWdKYhznfREYuLGq5pvgU3g1tMHggD4zSafO0VQka+ikzXXRmV7rGg+g2pmyz6x2OFgtL19oNoSQxcGin936G5D6VaOD/87Bd9dV9qhj0KWkzj8D1EN9xohJ4SJdTP0JgWabzM8nvtY44QvoQTneq08q0/91VF4uPGIhRuVxenSU9Q2G204f3QLdJAJFMab7zgQ5HFs9q2C3vDptjmkb4oaH7mQU45Aai8XffEVGdg63zJTRNQXSEEDESS1futS5CSZ66L8KLjlNFnn+K17hGgqW0cixkzAxcct17DB4RLwcLNoKx/mRQ6gNOqnxttz6tU0rHiF4= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 55d142ce-655b-432f-743c-08dab52d96eb X-MS-Exchange-CrossTenant-AuthSource: AS8P250MB0744.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Oct 2022 19:34:23.9796 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2P250MB0825 Subject: [FFmpeg-devel] [PATCH 01/17] avcodec/mpeg12dec: Remove redundant function call X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Andreas Rheinhardt Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: sIsEf+soMmyE Redundant since dcb29d37d4ffedc84e44df99f8d22ecf27e0f2cd. Signed-off-by: Andreas Rheinhardt --- It is of course only redundant if avctx->codec_tag is not allowed to change after avcodec_open2(); the corresponding option is not marked with the AV_OPT_FLAG_RUNTIME_PARAM and the above mentioned commit also relies on this, so I do, too. Btw: I wonder whether vcr2_init_sequence() should not simply be called during init. libavcodec/mpeg12dec.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavcodec/mpeg12dec.c b/libavcodec/mpeg12dec.c index 56bf73df11..c942be158e 100644 --- a/libavcodec/mpeg12dec.c +++ b/libavcodec/mpeg12dec.c @@ -2797,7 +2797,6 @@ static int mpeg_decode_frame(AVCodecContext *avctx, AVFrame *picture, } #endif - s2->codec_tag = ff_toupper4(avctx->codec_tag); if (s->mpeg_enc_ctx_allocated == 0 && ( s2->codec_tag == AV_RL32("VCR2") || s2->codec_tag == AV_RL32("BW10") ))