From patchwork Thu Aug 31 22:20:18 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andreas Rheinhardt X-Patchwork-Id: 43416 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:299e:b0:149:dfde:5c0a with SMTP id f30csp570392pzh; Thu, 31 Aug 2023 15:19:34 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGU2gsRDZefOOH1nPsJpwPEcimYezsIXhXLQOqM1gSavxKh9zvggmFdx10ID0pQqyZFP0Y/ X-Received: by 2002:a2e:9691:0:b0:2bc:f5d3:1021 with SMTP id q17-20020a2e9691000000b002bcf5d31021mr318447lji.32.1693520374450; Thu, 31 Aug 2023 15:19:34 -0700 (PDT) Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id gh5-20020a170906e08500b009a1b857e3b1si1610389ejb.304.2023.08.31.15.19.33; Thu, 31 Aug 2023 15:19:34 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@outlook.com header.s=selector1 header.b=S7q3kM3B; arc=fail (body hash mismatch); spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=outlook.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3CB6C68C7F2; Fri, 1 Sep 2023 01:19:30 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01olkn2100.outbound.protection.outlook.com [40.92.65.100]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id DE47968C4EC for ; Fri, 1 Sep 2023 01:19:23 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CDi/CHavRJ5MXpwVtITtXkzNhQx6XaqnzUVZ4tGKs3FC/cpYFvStX0TOGCEQnLGHtkSrx9L7HTEGeh2mzDyNwZAfE4cS664hIsdvCmcN9YyDCc0xtZV2Rx8aoo2JkLK9bbKrxurWcc3YvwE6j+hRqDeTj7bn8qTMaVH5i0iB1kAPyiaBhb5UAP778sT+tNsx1VkSse+/yR8YTyUchouEg758LlnhFbNgtEGF35eOuJjSK53Xm40rebs6PpK17I+ksSWov9inSjGfwiAT+jM6U2yViCVtMU8TO5jTHlc61RIB85auWOg3NkRdcKd6CJOZfayjQEkLPNhD/fZgBoAL8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hM7bBxgvS1qELTqGHPq2jneTvBF6UCmIcHTQMu0QI2E=; b=mPVWZhVumHXKDewVE0/ddwu47J92RSoVRbkE9TY/7UMjwoSflw3A0Nyl7RysRlvrTzYwsooDuZOTr4ortuPWWV1reJ5Vk9ojTAazENXUn2dD+nPbJL4oOVXVZucoAWZceu3jbx/NBAFmpfn/eCE+yc4FTGREYymNIuSqgs0A5bsbEHL3PW68A+qMKyVseXZO6I0/5H6sLB/WazX4EszFuNGLhWGN/EAa1Vo83GN80exkRNBAJ2Kd3aVIBMCt5Uyz/1sXlMN9v/KQvKFDoI/+ktnDeJLUQ0cMguRNaHRyVtqME5Dnrr/3Sdn6PzvfAMAcR6xEmf6kUDKuhVPuAXz8JQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hM7bBxgvS1qELTqGHPq2jneTvBF6UCmIcHTQMu0QI2E=; b=S7q3kM3BEDmhlObLLW2T53a2jK7HQm2BA1wdkAIrsXCarbjDebCkXsdyn+2lVDLJf1ZL0Zg8wqo/UVZO3j+205tzqiI65ZzeER7qRnEJ7HyJVwd/hUYl9dIVYWjc+UQkV0l8PazYSDCK4FoTFq2tU+8wOOgkkk4zZgUCvEFtrDTF2Xe6rlmjFLiUPHf3/OT2qPwV0zQ+1r6k7s9oIfqkASW5Uz7EpdD+23oqIVH/FdXjmOJZ5Hk9ajMEpWz1mw+gtfOrQdHsL1LtkO/fJT+WlS5UnIz21IlBhmDf3zveSEqU2vd2WhCf9TSh/+RvolsnjzI2qPo1G7pdm/8OBfsCQg== Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) by DU2P250MB0254.EURP250.PROD.OUTLOOK.COM (2603:10a6:10:27a::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6745.21; Thu, 31 Aug 2023 22:19:21 +0000 Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::5e01:aea5:d3a8:cafa]) by AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::5e01:aea5:d3a8:cafa%3]) with mapi id 15.20.6699.034; Thu, 31 Aug 2023 22:19:21 +0000 From: Andreas Rheinhardt To: ffmpeg-devel@ffmpeg.org Date: Fri, 1 Sep 2023 00:20:18 +0200 Message-ID: X-Mailer: git-send-email 2.34.1 X-TMN: [IYB5ML6A7ycu6Iyp9qQ0uQgXuPh10+oEIEbXyx9BD/E=] X-ClientProxiedBy: ZR2P278CA0022.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:46::7) To AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) X-Microsoft-Original-Message-ID: <20230831222030.4160639-1-andreas.rheinhardt@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8P250MB0744:EE_|DU2P250MB0254:EE_ X-MS-Office365-Filtering-Correlation-Id: dfb1c0e4-4628-4f4a-126c-08dbaa705353 X-MS-Exchange-SLBlob-MailProps: 70qbaZjg4msOH1kZ59XaVOI4Y8btiKHceaYN0cNrppL/gN4CKQ0+8SjJcnfpWZ1vnyFnpLirLpy7sv1ROZmzWZNScs9OTx/o2R0/bxXb1/NrUbFsdIZi6hiL6abouwrvlm8xsPsMVgnisWJPFEyH2GDKOuanROvLqC7zRb5DPvQpRFphQAGnOPc20asR7/RlB+j+Mpu4AUk4cYoddRiPHIQi1e6m2rXPYBIzcv0EuCI2K8X8GXi4wiV7qK2h2OlxOYl04Rx2OsBGMkhG2bq9IQD/W69VRM0FkH3I4kGdQ2+IdYT1sIaHGxKPQatNYjJr4b2+BwM55P+oVlqnyhImSwm3cIBQWzQoGefvd+3EviCziOQQ7UXmt5wfrfnz8bUNqtKVbrDpmlHhnX1SQ/exODr6LTFxq5abD+7MpuYf1aEnB8ggy5HTXyD4U0BT09YjtPFgd3h71O5gljk5CNNZMiT9CUguyH0S5Fg3XUo08arK5SXJD/25SjW9sinluBOlt24ELXpkF83h7HiKJjsxhbjr0JZ3Z7vzKMt2Q79VVwgxbIadnvQ6wgkk+LD0lt6lOF1jHXJwbhw1+Gv7egT2qOfNkwc3kNZTrX9F1buuSfikK6ht1q8LBbQV3uZC82VrAcW73DtKmJKteYqY2hSbEtKkd37gxs7OIh2eaCGVNTjWvX+GiNK6FrTrZsQFEyJGEGMHkh/acUa3XB4LZBIBnEIjwxGjWa6RUd+/24G9lgpVPLTbLq5Xjw== X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5V/sUg6WObIZU6+Gns+dF44VZxYUPnbucgcJAEodMPpeuPHAUuwOMawsa2yU4e0ZuoU7+nlkrJtLi6z6IvZXEmV1fZINaXCYcsjjM3wV3JSQzz4c0lRRZLH5+7d98NXhzUL8oTtJh9f9/LShNFgTVRNYzxG9N3OhUCfxL23cldeHRpjoPbBMAZzV/CGTEZUWFJrZISH1dUxk/NPymQYXXE7/TeFOTTmN6ZJrUOUAUzzkMxSykHVgQH+9elyIqVnUg3UpystKAu1gZ286Nh58yr6BoeYAWOQu6FsH2BEUyaWZbdiVvQNXM+4OWoQx67/ME5PT2PTeMRjv4OoX2xDwGU/rwcDuf/6gpeWaMjULbLNcfP7lr13hU6rSp8QNJyirpGh428I/4tG9wBotEhLVVMGw1s7iHza2fiiZQvmYOwbcD/63cJq1p/p1NcUX5g1+CcVqgF8QkHpv6zUeQ8Px5JIw8v5Vsw9Wb+xH3cmvULxa7k8VEaXtMee3/nCpBR4HSzS78vXh94l/aOGCqcBIoNZymaN60C+6+0jVj8QG4cnrouXgmBhiOt29NCeHBqfbRnnxIizfg8SJeh1YobZfl4epXcJfTKKtB/+OcG19Be+IBH+JSnw5b0V1hxrLAnI2 X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: r96KFDkHqKr5SHQEToNI1beaa0f17Jy3KhB/BgysgSl64u7a1VGDclb2C1LtEL1W+hZnioRdiobBXzxCEd7nbO96MfgqpfJnMlbaiv5xcMTG+4BQAqva1I/97XzL6tZFV5bs302uQEMkz+x5ji+dk37I+oWfrracnTBRqGJ9GAeEcB60PMFkFLUJIrG87cghwf6VltlhJtznLRYUqE3ZT/Tnbu65RAgfLI2UpgA+yOD4PLzs55JJQEIEd/KSXSGQfdnAQXR7nkr62dFWWhobu2XjHb+SP1yCiFiatWJwZfkxcxGFlo+YgURHiwZFFLr9cvkb57Ugz1wwuVrbCD5gycPAMq39Cl4Ydi8hhewxfoJ1RAYSz422qeTy8gEYrZ8uireXiu8yWQ1auJ5VdR2M5ghnsjGQYJ6dwWpU5O5CqDHjuUeMya81cIDeo0eD3ZCiXX3vF+Ef/3UiHxq75rs8P+VsbH1mWSYQjSF4SkMc3YcMB5A9YqJ7E6QQEHaWz8nNet3nmlRBpBCB3NAtQnA5nguytVfv6hXUukJW6zcGKu8Wquq/sT5sLLR+dYl9wC2/1J80x3adsxbCq6mQZKTdq+YK635ktpJ2vHFmI4W5lLctBCNJvvzdHpzUSAHVv4A95XkfH04dZM1L5v84QPv5mke6xo3qfe9hidHorFnVpdR2d90UNO9rnVGU/Rlno1252qMhgL2kyx1KkQIhGwlFDMflA7UeR6f90CzP2tB/SUbSuqLya/6uBd/PsPe1zXe772CbqFMo2z7zMYgJ9pyeVnCGIIX/IZjM/newE6dHoApKVeYrH1RN4/USn2r8c9ss2+OsoT2XYnJAJAWDK3vN8qR5aZ3ZCb1jJ+OEw5eMHzgQmQzBMkonO7wj0ZKSaJ2ldZsD8Lxkr26d+FlOmEu0NR+TbHJ44EJD51Wj5Gz+boyN5r6zZ8F6P0GtarY+gbKsw8pCjsY1tcO1gKkeybB01x33sy2KZshfxj/Npo1YEo1iAZVaZkjrG2g0CWj88/JnI5wiP19ROuL5pKvSoXkAI52sansb6BafDYAX6btdR87bF7v6JgUlYgaI5abGPMBpYTADUJgB53b5LY8HzgpyeVPZQpcEM/w3smDCAiuGpMy8gTR/1Qburz3yBnBvEXmVsSjMomOnWS1fms/lFZgCGZjtfMukkI2pvsjfH+Kg08yTY3OAnhZbuE+Pqj/T3AtfvmVQeKqLWG52yVgpCJsXGfdhELllOk4JmjBDBhMhfYLNfjPnAutYA7C0zmaUHSKl X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: dfb1c0e4-4628-4f4a-126c-08dbaa705353 X-MS-Exchange-CrossTenant-AuthSource: AS8P250MB0744.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Aug 2023 22:19:21.6648 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2P250MB0254 Subject: [FFmpeg-devel] [PATCH 01/13] avfilter: Remove unnecessary emms_c for ff_scene_sad_get_fn X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Andreas Rheinhardt Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: 5HiFlhpo4coo ff_scene_sad_get_fn() does not return functions that use MMX at all. Signed-off-by: Andreas Rheinhardt --- libavfilter/f_select.c | 1 - libavfilter/vf_framerate.c | 1 - libavfilter/vf_freezedetect.c | 1 - libavfilter/vf_minterpolate.c | 1 - libavfilter/vf_scdet.c | 1 - 5 files changed, 5 deletions(-) diff --git a/libavfilter/f_select.c b/libavfilter/f_select.c index 49fcdc31ff..c9e216f51c 100644 --- a/libavfilter/f_select.c +++ b/libavfilter/f_select.c @@ -294,7 +294,6 @@ static double get_scene_score(AVFilterContext *ctx, AVFrame *frame) count += select->width[plane] * select->height[plane]; } - emms_c(); mafd = (double)sad / count / (1ULL << (select->bitdepth - 8)); diff = fabs(mafd - select->prev_mafd); ret = av_clipf(FFMIN(mafd, diff) / 100., 0, 1); diff --git a/libavfilter/vf_framerate.c b/libavfilter/vf_framerate.c index 6ef5dca27a..6d448be74c 100644 --- a/libavfilter/vf_framerate.c +++ b/libavfilter/vf_framerate.c @@ -76,7 +76,6 @@ static double get_scene_score(AVFilterContext *ctx, AVFrame *crnt, AVFrame *next ff_dlog(ctx, "get_scene_score() process\n"); s->sad(crnt->data[0], crnt->linesize[0], next->data[0], next->linesize[0], crnt->width, crnt->height, &sad); - emms_c(); mafd = (double)sad * 100.0 / (crnt->width * crnt->height) / (1 << s->bitdepth); diff = fabs(mafd - s->prev_mafd); ret = av_clipf(FFMIN(mafd, diff), 0, 100.0); diff --git a/libavfilter/vf_freezedetect.c b/libavfilter/vf_freezedetect.c index fb4e59b127..18d392d9ae 100644 --- a/libavfilter/vf_freezedetect.c +++ b/libavfilter/vf_freezedetect.c @@ -131,7 +131,6 @@ static int is_frozen(FreezeDetectContext *s, AVFrame *reference, AVFrame *frame) count += s->width[plane] * s->height[plane]; } } - emms_c(); mafd = (double)sad / count / (1ULL << s->bitdepth); return (mafd <= s->noise); } diff --git a/libavfilter/vf_minterpolate.c b/libavfilter/vf_minterpolate.c index 610ac6b1bb..9920210ece 100644 --- a/libavfilter/vf_minterpolate.c +++ b/libavfilter/vf_minterpolate.c @@ -825,7 +825,6 @@ static int detect_scene_change(AVFilterContext *ctx) double ret = 0, mafd, diff; uint64_t sad; mi_ctx->sad(p1, linesize1, p2, linesize2, input->w, input->h, &sad); - emms_c(); mafd = (double) sad * 100.0 / (input->h * input->w) / (1 << mi_ctx->bitdepth); diff = fabs(mafd - mi_ctx->prev_mafd); ret = av_clipf(FFMIN(mafd, diff), 0, 100.0); diff --git a/libavfilter/vf_scdet.c b/libavfilter/vf_scdet.c index 6de84a43a0..15399cfebf 100644 --- a/libavfilter/vf_scdet.c +++ b/libavfilter/vf_scdet.c @@ -126,7 +126,6 @@ static double get_scene_score(AVFilterContext *ctx, AVFrame *frame) count += s->width[plane] * s->height[plane]; } - emms_c(); mafd = (double)sad * 100. / count / (1ULL << s->bitdepth); diff = fabs(mafd - s->prev_mafd); ret = av_clipf(FFMIN(mafd, diff), 0, 100.);