From patchwork Fri May 24 22:04:46 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andreas Rheinhardt X-Patchwork-Id: 49211 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a59:542:0:b0:460:55fa:d5ed with SMTP id 63csp2018522vqf; Fri, 24 May 2024 15:05:24 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCVMQh5y+9WU4FsPGxwMJdp/5O5VF6YnROc7NBm2puHLpLFuUiGfhxLFa0OXF0E5MOv3mQ5vwipUIOZQBR1VYr0HT29sDmkJ3CZAKQ== X-Google-Smtp-Source: AGHT+IFIT2gysK3ToqBpVOrSHGV8mAfk1sewiTBu4pOVbC5gKfNCQQIfUo3ff9+Z04OUmJEnfz1U X-Received: by 2002:a50:bae3:0:b0:578:68f7:4371 with SMTP id 4fb4d7f45d1cf-57868f744f8mr233500a12.3.1716588324361; Fri, 24 May 2024 15:05:24 -0700 (PDT) Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id 4fb4d7f45d1cf-578523316f2si1219003a12.94.2024.05.24.15.05.23; Fri, 24 May 2024 15:05:24 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@outlook.com header.s=selector1 header.b=qoKyFftg; arc=fail (body hash mismatch); spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=outlook.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 6612268D595; Sat, 25 May 2024 01:05:20 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05olkn2056.outbound.protection.outlook.com [40.92.89.56]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id AC0B868D566 for ; Sat, 25 May 2024 01:05:13 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fsOYRRDR48CQ7FhGspLsPGsWXTs5Y2RYvLno+DQQiulFbUMp8QsVngK4mNhkyH7wtBvaLkhh/WRxa8pjGoLYEcRpDVB6XXfYhJqssdyqYQAh7+YKkjnivNYVERS178UmCcVy3zAwZBsALl0Z6PYnVFfoCXYg/zHa/jjtXyqc0FBcE7wwDSeGFzw4wkfgMhppUBmfhLmTM9Ef2HV+MpQfqaxsj2XYAzAtCFGQeBzcyrQaBvF58qnhvbrTBO2O3/M1yYEJiZYk4TxBR4Pcao8WkYI1TbEdTrt/kpjI3czDXjCFKrwDY4/QB2k5FR3SUQpo0qU1K7PpswkmZsfnZqTCmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aemugSAm3zB1ByKWddgvmanjzpRPj6xAhEfLrvQY2OA=; b=g3mNZ4zJti0OjxgebNZN3L41Viml7sw/sSL6fdAMRa+J29PoUT0Kd5u+f8VilehRhUBEIbeZQ+OMH/P4sz1Fvt9YRbpVykolzvU1lvsO5H6DyPgujVUkt6rvc9mZ91GCcN1kmtswUbysUyMJx7LgvX4oLDOXGhQtsD9UuIbAevrgTxVbqmaRIMjj8MKSYHsM9xpZxJUD2HiPLMZblPvlNjO7I84FRyOZLzWt+jSGA1ox+2fZ6PA3ISPlVUhM/3NbckERgpMwXciwXLt2UUHKQnBRzJaplTC4y7gHhviLJujSAsBGiuRHWGlMbOLmupimG4QKWjHDdKMYvOgHyQHTIQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aemugSAm3zB1ByKWddgvmanjzpRPj6xAhEfLrvQY2OA=; b=qoKyFftgp7b1ziVUMFKuaBzrO8534md1g+hI/pGzZ6TSFOzmEDa0lWhvp9jioF798lPcSUs1to26eTFMvDD5L4vw7sNI3b+5Rf79foiZ8/PuOFxJ9a2K6/tcC01/YfODJ3mOPGH7hqmAS/VUK0slLhXKsUs0xm2Qs+5rGfYeMC4mnszDiLzPBnlBW6l9MS6rZyGAwC3uwg6V/5kJYeEfiybN4e29D9qkNrR4PUl2tgxT9xqk9NiQQu97sDcuTVRud6Vl2nHuyISl2JjqT+Ad9epXU+X26AtpORVVVDu6aT+bpJepgArVGIVPxQoNMJ8GIwMMbeR2scSJ0fl/ofAglA== Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) by DU2P250MB0368.EURP250.PROD.OUTLOOK.COM (2603:10a6:10:27d::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7611.22; Fri, 24 May 2024 22:05:11 +0000 Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::384d:40d4:ecb7:1c9]) by AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::384d:40d4:ecb7:1c9%4]) with mapi id 15.20.7611.016; Fri, 24 May 2024 22:05:11 +0000 From: Andreas Rheinhardt To: ffmpeg-devel@ffmpeg.org Date: Sat, 25 May 2024 00:04:46 +0200 Message-ID: X-Mailer: git-send-email 2.40.1 In-Reply-To: References: X-TMN: [pZr2tdWDgvElyrGZLPZke5WamiJVI1yiqkuT+eyM4KQ=] X-ClientProxiedBy: ZR0P278CA0194.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:44::21) To AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) X-Microsoft-Original-Message-ID: <20240524220455.1276419-2-andreas.rheinhardt@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8P250MB0744:EE_|DU2P250MB0368:EE_ X-MS-Office365-Filtering-Correlation-Id: 1f1bef49-ae54-4a96-7ef5-08dc7c3d94ed X-Microsoft-Antispam: BCL:0; ARA:14566002|461199019|1602099003|3412199016|440099019|1710799017; X-Microsoft-Antispam-Message-Info: WsoBK/c4Z67V8MjGdXlZ4c/IOTHpPf6bwO3lpvb8cYP3kVIwZjbCl0yT2A/5LURvXeJ99pNGhTtaT5++i74HSoBjbxk0yT4W/wadOPjfGAIwflMEInAN2IPG7/GmEidH9WFqHTMnZbWyDDWZSXhDNFw4urUSogQXM4hv/C7pUOamSZBecp5TDo2eiq67n5wr1inDZxRBQ1muukcyS5wPSSicGs4mkrSEcwDLborXTO46YMQ32kVhB2a8cnc56n776JZPtvVSuypArsLWKRy6vHvdnegpAzt22Ensj5eYqXjHyeeYZU9Fj0RL+TA98T6oDjocs6KETRRi0pAYi8yp5ISh7OfRiycXV7MeFqAbYAqrIQuXPTewt8BKxLwJ5SZhC78ZEyMi+7YLhaIYiyuMZIYK4FCZan2eOtJQW79lUra2aBRpb7097zd53Lk/eJIZRSLGEyWCNcIsuKysmHzJJB6GIKLmAbxYsaik5pkCaHPLxrGTJasQ6S6ds8x4LWb3vx3iicNKnOKaz1r0Fs9zawgfWjckk7UK+wgUK2fB9c/rhf/aY7Trtq5TQzboEXI36BfFrru1h5Sq4huBnRQvdc0no1E0by8C5mu2+LJ/wD1K3WNQfLCDDWxJo1X/ulgLJnZVVJHrGmuLd1NXL+UMKnDGi7pr7r5+Yi1YyheZlpW2HGysHPhD2sDQ6f12jXFq X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: TebmcdhfASSMtb2Ithbn+Xl3efXxD0pcsbgQs4qHluq88oT6E8DnlYISDQlmPtGwwc6JOa1b35W++8tX8PR2CG5xyjWhsP68sQYjoAL+PsBqPIC5eVN6doj3v4BgOKz31U+ddn4saVt033dWLvw1N5VQ9ERWcO5uL1EUuhtxkqs+4q/Pw1grgNUYjoa9KSy+KkPvXjGuf93tXsD1IvDKWigvKpfDJyTWhy7xaX/yy8N5DIqCY+ckUgvCCGcLvnK40UXqFuPl6d2Io+ZvkdFiK2hHufXZi6R96DTGqO69T6V7SOApCay1LzZ5G7g+/0HhZq1sz857HTxcpgF/qEm5ouDu25o8xjG9tb6YYIEWLNh+t1OGwWA37nHnl9GYitGfjvB6msYjoaS2xlX5ERnE64SIxI1pf+8EngQ+vrHc7Y5Gam0b+ZzZI0SQwok0JbLCe+/lNgc5QwVAO7BEJTwJV/cznXGjrJRIUc+BV+ZycAIkcPegkfUBDhd8JnEnAIar4Gtjx+XhRm1HDSIzEFbtg7/IUzV07vKEQRUNUcHpIuE2qTWlseHJuc4XuN5OOmr0A9eCubdGUclOmquGxwq158C4GqavSfd3EGna4jsGakWoQ1sGK1QC6Vr2/Rb3BF4vv7/J3OziJ1Xan2sETLWia7uwiIKmt9Agb7oF5wJcCyx7aoBH6akeywpkCsQONy2fEjInDS/9eis++Wal4tTa8X6WBPcRYh6heRAcUzXzfC4wpcC0wdjNYKA+qNRFqsAFEzuAM32Tr1kU1QHkNYWzwsdK5emBAIrHv225dfp4azTBPIOEXiFZEnvdv5nRRRl0YL2Im8Ro/1Ajm1xBYwUfWF0tkdfogJjRBCwRhGCQze7OZFjlH//2VHYMIKN5CqLJEjeeeD3M3RlWL6/+lioySi4GKmRGpyNybtiT7eSuX6NGSphJKiiAqQdnto6VKL5JQV0PouNxCG+99FSAntIKNFNgaz51IruJdOVKkxG0o3z7x0XW6RFtCY6x5j6RVocdhNY2QnoRv6rBoPfgVphByzdBMufTvB+q4XT53VDlDdm22C9wCRUqbZyugfzWDRdfQl+yOnrjDbw7p4D+h0nH/KC8H1muSgeQ+bf5x8eSUVBWdDCpQw/cFfj27Ko/aEEa9lG3A/gzlKcTCm1Tm0+PNs6TgVMzUkCKDyZh0p6z40eDaF6COxmpw0UlV9IrikGji7QYe2APsMDqFBus3a5W32JnK+WAlLOGlxvgRFk3BC9QU4hNRdYLQcNajS7PWBYEAEyHzXnXEULz46HyG/rpbQ== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1f1bef49-ae54-4a96-7ef5-08dc7c3d94ed X-MS-Exchange-CrossTenant-AuthSource: AS8P250MB0744.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 May 2024 22:05:11.4804 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2P250MB0368 Subject: [FFmpeg-devel] [PATCH 03/12] avcodec/proresenc_anatoliy: Mark impossible case as unreachable X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Andreas Rheinhardt Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: KdkLLvegXynn Should fix Coverity issue 1440385. Signed-off-by: Andreas Rheinhardt --- Alternative to https://ffmpeg.org/pipermail/ffmpeg-devel/2024-May/327293.html libavcodec/proresenc_anatoliy.c | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/libavcodec/proresenc_anatoliy.c b/libavcodec/proresenc_anatoliy.c index 2fb96e9cf5..7b7618af9b 100644 --- a/libavcodec/proresenc_anatoliy.c +++ b/libavcodec/proresenc_anatoliy.c @@ -845,18 +845,25 @@ static av_cold int prores_encode_init(AVCodecContext *avctx) } if (avctx->profile == AV_PROFILE_UNKNOWN) { - if (avctx->pix_fmt == AV_PIX_FMT_YUV422P10) { + switch (avctx->pix_fmt) { + case AV_PIX_FMT_YUV422P10: avctx->profile = AV_PROFILE_PRORES_STANDARD; av_log(avctx, AV_LOG_INFO, "encoding with ProRes standard (apcn) profile\n"); - } else if (avctx->pix_fmt == AV_PIX_FMT_YUV444P10) { + break; + case AV_PIX_FMT_YUV444P10: avctx->profile = AV_PROFILE_PRORES_4444; av_log(avctx, AV_LOG_INFO, "encoding with ProRes 4444 (ap4h) profile\n"); - } else if (avctx->pix_fmt == AV_PIX_FMT_YUVA444P10) { + break; + case AV_PIX_FMT_YUVA444P10: avctx->profile = AV_PROFILE_PRORES_4444; av_log(avctx, AV_LOG_INFO, "encoding with ProRes 4444+ (ap4h) profile\n"); + break; + default: + /* Already checked via AVCodec.pix_fmts. */ + av_unreachable; } } else if (avctx->profile < AV_PROFILE_PRORES_PROXY || avctx->profile > AV_PROFILE_PRORES_XQ) {