diff mbox series

[FFmpeg-devel] avcodec/av1dec: Fix unintended fallthrough

Message ID AS8P250MB0744F433FC23F57A713F85B38FBF9@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM
State Accepted
Commit 85b185b504759c794d872ade303bb9be4f79cdcc
Headers show
Series [FFmpeg-devel] avcodec/av1dec: Fix unintended fallthrough | expand

Checks

Context Check Description
yinshiyou/make_loongarch64 success Make finished
yinshiyou/make_fate_loongarch64 success Make fate finished
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished

Commit Message

Andreas Rheinhardt March 15, 2023, 2:09 p.m. UTC 
Fixes Coverity issue #1521982.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
---
 libavcodec/av1dec.c | 1 +
 1 file changed, 1 insertion(+)

Comments

James Almer March 15, 2023, 2:36 p.m. UTC | #1 
On 3/15/2023 11:09 AM, Andreas Rheinhardt wrote:
> Fixes Coverity issue #1521982.
> 
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
> ---
>   libavcodec/av1dec.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/libavcodec/av1dec.c b/libavcodec/av1dec.c
> index a80e37e33f..4d3b559b96 100644
> --- a/libavcodec/av1dec.c
> +++ b/libavcodec/av1dec.c
> @@ -911,6 +911,7 @@ static int export_itut_t35(AVCodecContext *avctx, AVFrame *frame,
>           default: // ignore unsupported identifiers
>               break;
>           }
> +        break;
>       }
>       case 0x3C: { // smpte_provider_code
>           AVDynamicHDRPlus *hdrplus;

Good catch. Same issue is in libdav1d. Want to fix it too, or should i?
diff mbox series

Patch

diff --git a/libavcodec/av1dec.c b/libavcodec/av1dec.c
index a80e37e33f..4d3b559b96 100644
--- a/libavcodec/av1dec.c
+++ b/libavcodec/av1dec.c
@@ -911,6 +911,7 @@  static int export_itut_t35(AVCodecContext *avctx, AVFrame *frame,
         default: // ignore unsupported identifiers
             break;
         }
+        break;
     }
     case 0x3C: { // smpte_provider_code
         AVDynamicHDRPlus *hdrplus;