From patchwork Fri Jun 25 21:58:37 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Hayden Myers X-Patchwork-Id: 28714 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6602:2042:0:0:0:0 with SMTP id z2csp1861009iod; Fri, 25 Jun 2021 14:58:58 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyqJ5TeYPlm+pG56hZrdiUMeEhq00fRxzQ+DU5oYRy6SXhSMWKhfGfSG+qzjkZIoC+asLBy X-Received: by 2002:a17:906:744:: with SMTP id z4mr13332869ejb.347.1624658338354; Fri, 25 Jun 2021 14:58:58 -0700 (PDT) Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id z4si7567009edb.208.2021.06.25.14.58.57; Fri, 25 Jun 2021 14:58:58 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@SkylineTechnologySolutions.onmicrosoft.com header.s=selector2-SkylineTechnologySolutions-onmicrosoft-com header.b="o3y/Yr7Z"; arc=fail (body hash mismatch); spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id A998568A119; Sat, 26 Jun 2021 00:58:52 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2091.outbound.protection.outlook.com [40.107.220.91]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 9AF03680814 for ; Sat, 26 Jun 2021 00:58:45 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LWC+LuFQ3ovo3p89RJHmCVy7CzVdt5qK9AhC3ak0LX9KLkbm7Zusm5GyRdRyYFOl3x655KJ/NIQ/ZVUvchQa+Uugq8WtMU9yiMpMBOZFCUWKwukqtC3nIwyhDsXB9RZ1pmrTRCskjOHiRE8mDg1G6vIyGd56VRLFYFOynCWNtUxsaGwr31QxDqVul1DFSV5PtY0B2YlVTxQkvIy4ywQ7ef5jnqajnV2b/p78aw5xfn98p3sIhLOqYVFx7s8lYDqhcjiJH9/Z0nhES9p3cQ+gV6Po7ATkVkgal3TS7BVuKFzzA5lXjShO+DJXLoLEBIRfsdRZCrlCox86uey7bH2iWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1mTAM6WAMmHAB5Jm3K1AVtY5WatTW1si0NIv2KMB6w4=; b=fIUjIghbxG2OMSjaZjvRG7d4Ii/vaoTt7U/pd7q6/sMFPd5aqjsnCZGJXEy/kjcLbfYA+fwt7vMhtYVbW9ZgRgdgaqzeVO2nXW6wMCT4MjurslTRgpluybAbX5Q/2Y66U3XUhd0N9BM2LRCccVo0cXowJr0mX+g0+ymxbFjm/4iFMmpR4YSk3CvSPLnw2gEIF7v+1tC65EaeSaVeB5AjV3wlb2F9169mTjkdLIAD4jrucXpo/HDio3tmKtC1IsZfvMMqMr0OBSpXN51qybAEiSmqZ8OQsxB6uI8lphxywbKSJC8RDFNnRK4qiTIpEL21cB/Evn18V4gfiYaQk3Y90w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 191.237.4.149) smtp.rcpttodomain=ffmpeg.org smtp.mailfrom=skylinenet.net; dmarc=bestguesspass action=none header.from=skylinenet.net; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=SkylineTechnologySolutions.onmicrosoft.com; s=selector2-SkylineTechnologySolutions-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1mTAM6WAMmHAB5Jm3K1AVtY5WatTW1si0NIv2KMB6w4=; b=o3y/Yr7ZqoIdp+PjBLM7bBn20nwauhNSushTJPNHrhhboQCRAm+VfduknSdhD37FunHVimjgzZlBDTWS10xAR4u7K+xNeUoBvQ502HpZaXBQo+cGnH+5K4nwul/VOwQ5TOggqIsqq+1l/VrJPfqlLQb4UZuJSX/E3nANdarJy3o= Received: from MW4PR03CA0315.namprd03.prod.outlook.com (2603:10b6:303:dd::20) by DM8PR10MB5448.namprd10.prod.outlook.com (2603:10b6:8:39::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4264.20; Fri, 25 Jun 2021 21:58:41 +0000 Received: from MW2NAM04FT038.eop-NAM04.prod.protection.outlook.com (2603:10b6:303:dd::4) by MW4PR03CA0315.outlook.office365.com (2603:10b6:303:dd::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4264.18 via Frontend Transport; Fri, 25 Jun 2021 21:58:41 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 191.237.4.149) smtp.mailfrom=skylinenet.net; ffmpeg.org; dkim=none (message not signed) header.d=none;ffmpeg.org; dmarc=bestguesspass action=none header.from=skylinenet.net; Received-SPF: Pass (protection.outlook.com: domain of skylinenet.net designates 191.237.4.149 as permitted sender) receiver=protection.outlook.com; client-ip=191.237.4.149; helo=us1.smtp.exclaimer.net; Received: from us1.smtp.exclaimer.net (191.237.4.149) by MW2NAM04FT038.mail.protection.outlook.com (10.13.31.135) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4264.18 via Frontend Transport; Fri, 25 Jun 2021 21:58:40 +0000 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.106) by us1.smtp.exclaimer.net (191.237.4.149) with Exclaimer Signature Manager ESMTP Proxy us1.smtp.exclaimer.net (tlsversion=TLS12, tlscipher=TLS_ECDHE_WITH_AES256_SHA384); Fri, 25 Jun 2021 21:58:40 +0000 X-ExclaimerHostedSignatures-MessageProcessed: true X-ExclaimerProxyLatency: 14521535 X-ExclaimerImprintLatency: 2522497 X-ExclaimerImprintAction: 4dc2c2b1b602421cb4c5a14a94305337 Received: from BLAPR10MB5169.namprd10.prod.outlook.com (2603:10b6:208:331::15) by BL0PR10MB2996.namprd10.prod.outlook.com (2603:10b6:208:7e::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4264.18; Fri, 25 Jun 2021 21:58:37 +0000 Received: from BLAPR10MB5169.namprd10.prod.outlook.com ([fe80::a02c:73eb:c6fc:90e5]) by BLAPR10MB5169.namprd10.prod.outlook.com ([fe80::a02c:73eb:c6fc:90e5%9]) with mapi id 15.20.4264.023; Fri, 25 Jun 2021 21:58:37 +0000 From: Hayden Myers To: "ffmpeg-devel@ffmpeg.org" Thread-Topic: [PATCH 1/1] libavformat/rtsp.c: Reply to GET_PARAMETER requests Thread-Index: AQHXag0zbftX9tm4dUK7l0rw+vsWYA== Date: Fri, 25 Jun 2021 21:58:37 +0000 Message-ID: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: ffmpeg.org; dkim=none (message not signed) header.d=none;ffmpeg.org; dmarc=none action=none header.from=skylinenet.net; x-originating-ip: [144.202.232.42] x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: 8da29f1d-66ea-42eb-d25f-08d9382464dc x-ms-traffictypediagnostic: BL0PR10MB2996:|DM8PR10MB5448: X-Microsoft-Antispam-PRVS: x-ms-oob-tlc-oobclassifiers: OLM:3173;OLM:3173; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: uc1xDkdHQjnR3SkoPHZ+lKidEJ98EhxnCbiGPk5cs5QnKbUTL7tkPwLxqu0MpoCtYdtCktibM8XilB6QIdV5Z5N9eCXoPjYSteF1Y0+xSun0dc5r0cEckJ/d9vbG8W/A1YYCXruZFAGk73XTB6YM8LNm/p95XRuQoZmkzmqR0J2Z8yi+GYWvZHpPgCmAEguublyHwgqCvV+8wo+t1dAe9quo6SZYjwWddSb0gxV6owJ3gzbA2qYzicsZNMdr18g/88a2DbeF7zG1xjeWmGauAqVnoMUNMQOqxPlAleuL/xlfwV8mZlybdR8A7zbwL7PYY8Y4Y50BPjX5CNIZlboY1IipNahr35bn1AGdCsZNFr/N8paEeOpExzjO36y+LSjXabVxx5IFpR3bstBmbwOi7dMOExuGLJwNh5iEMdb0UNrz3ZuoLYFYwsFaPtSefX/dDq4oan370HgaT6XOktWJPIpn7ORgYrH4S02oO18hfeRvRXv02UIvvN9wYb+WpdNPXveSWaGQHToT/sdBNrCWV7/whwcmwfeQEkHYu3QEHoFqwTXRGygFBsJvO62bqdqlbHRCbgIn8A+YsSly55b260biCEiM6eRZFDu37QYIx8w8jW0cmVyWJBlUkqlH5P8sn7oysDzmJ8rPt518WhAB6g== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BLAPR10MB5169.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(136003)(346002)(39850400004)(366004)(376002)(38100700002)(33656002)(478600001)(7696005)(6506007)(9686003)(55016002)(122000001)(64756008)(66446008)(71200400001)(66476007)(66556008)(66946007)(76116006)(8676002)(8936002)(83380400001)(186003)(86362001)(6916009)(316002)(26005)(2906002)(52536014)(5660300002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?q?a/ou8FBTn+FepeEZr1NwM/H?= =?iso-8859-1?q?tokPVdH87T8UboaSsjGTHFfUeK3RReCggw8mwCYjgpW1c695zf6r6AOQNw3r?= =?iso-8859-1?q?va5VCwQFUwhUa6ufKlfbH03j+iyFMqIfZP66hrhKMXR1jEqVr7SsJTRhvQ6R?= =?iso-8859-1?q?aUFoGrEx1/Hf91PoGatdJm8R+qD4JldH3nbY/bQvWOUTz4G9afpVSsChYuGE?= =?iso-8859-1?q?vv6fIHjeGQzESIgAUTSDi7n0P/Jiedz0IwIIAQZ221edYhNVZk7yZpAd+HQU?= =?iso-8859-1?q?830CJRo+Ro3zujgVFHt1jJwU2XAlpceCMm+IG6+v7R1SM/ilMEafiaWSefPW?= =?iso-8859-1?q?e3NJCDmLHbsB7ENCwnlYduPJgh4lSMcKHNKilX+q/cGMxzf59N+udGZrutjB?= =?iso-8859-1?q?+wzuj5rMEHTSt8OYwVIKH3hkSJwCiGX1jSexisv/n+NU9o9AwcCqTr5Uf4AW?= =?iso-8859-1?q?NCrmfHK7rd/oeBmRlALDCfBWibl44IarBqJ3UOgtKWyq6k9gwkJNHkckC5ct?= =?iso-8859-1?q?K12i/4SE89+aTR1wh6ICNMVKe4TRLgEIcKVnwsOvLtnnLH6iTICgl6IHFqx7?= =?iso-8859-1?q?7WyXY/FBSCO48A5YjiRTZKWpqk13JSb9R2j8aYt8ZjtoAav/dDRqtnOoXW/3?= =?iso-8859-1?q?Ht4IeQ80gSwMt3WRaqK6440qJNAKaxMowSaCiC5LdqtUOCEH7xqolupq5U3N?= =?iso-8859-1?q?NpI16JknHkGQyrYs9vGDI3dWaW02bcFagDaT2ph2jJZdAVu+kEZJQSr2C3ld?= =?iso-8859-1?q?uO8+HvE62fZ2Aww0OR/LEzPRTzgkF+ZqISTZL7nsSzIQMOndOU0CtLgZ8AJj?= =?iso-8859-1?q?ctiA1KwtzE+P+iV7FiQO4pVj5xbLtHXV1iJd3+T0Gz1/IsZlO7FFI7L8/Szy?= =?iso-8859-1?q?UTNB3NAXAMurFnZLKGxPjE7yejOYPj93niGSSXhxOKelU3XVp0e/QK1yvOOI?= =?iso-8859-1?q?4ikJ0Km97mR3lywLw4EF89bltmeFC4CqdaKZrsxUWAcPgS8q/Uk3S6n4WwXG?= =?iso-8859-1?q?JIVydZZxtx8kxJXvkGsA7hoPOuMIRk4KqsdTt/taySvnVAeEXpMTSSzLVXqN?= =?iso-8859-1?q?LtN0eC+DKxs/I7XXzGOPfr1DqvtwlSMdmL8PCiWmI/kek9AleBDOu5XkxPdg?= =?iso-8859-1?q?x+Oag/s0sVGU9uv/5dPH6jcOohenrm9mwQYcNQQP7XOiQPUFFGpIvFb6DLBB?= =?iso-8859-1?q?VJEOj0t7rA2hkHsWVlLlPaPKiOp0jK48E/Bix/YpN42tiGNm9qPrYJHJ5rLo?= =?iso-8859-1?q?Lt89+n2WhejtOh4nyL+oju9T+v18z+UevT+K8i+qrvp5dfGVYkTrnMw+5Clk?= =?iso-8859-1?q?7krUU1UwLI/7nCg+TX1xkjDXFxSUXKfZpKskEQwk=3D?= x-ms-exchange-transport-forked: True MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR10MB2996 X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: MW2NAM04FT038.eop-NAM04.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 351096ea-ac9b-4feb-eceb-08d9382462a2 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: oG2hUax/EQaYszwiZ8n40YybmTALWveqYjQo6yz35wPl7G9ccXvrKf4a0dLevayciOXzHguSUwFsRDYY2FdIM+9cEJlYX0qn1F/pv3sBlr1rwQ4S+24hxoZArOojDUMptQiYX6Ju/rJjdN7WjCyamZx129AaMEqOdDghhLJMpH/VK2yiR/hlpETVoK+oJA2lNlsnqSz1ZqYcOP06l8f0FcVMJ/aBGmpqOkgL2ZRkSOh3eEof7kLVTx4/wUdtQXyllGxoyNeowYfLyf87SrYXOxz7FmUQ8iZmd6ahYB1OUNdS1ePXCFiW5/QNsmXlVaK43nJUfZoMVr0HSPl7mGH2tb0bUBD7+BGvZV4b97wT7EgK7/S33FROtuOq55z/aqYUvurInWV22zLHVVKK3MLmOFhl32JsT1hG5jjmS7bwXDomyPJMAyqRJWmMeJZHkxoPXB1BpEdGix97yHHNQ9nMhl/qVmQ6okrBJPTLJ8JaThNdpABS0fNW9a/jkntSKOfZ5o/thZOshRfscgSB0yhxStJ0Sgso/kkYt47uXEb5+McAsNS0HUi9AZct6t1p99oBPjkd7Q83T0qyfSl0/BCYZizXEHOHsDTFEifLbzHtLlmujmMV7vzKuO36nrBmbzz0mBivJ/yDrz2dafkjyIP+zBjlZ8dksICS1rEhFJLnehf6tUqrGnDqtQIbtI3n8NeTZJa4CtZl9PnPBW21dsNl6HAOgiZO7MnC/WtQQc25r2IgaWG3KBfGrMs8eyy8LAGsryzFl8risqUmuMO+vrZOBRvp/OXTVItg4FCKXmVB9dqgLEVpqY/NEozxuPQTnDxSP6mSiStHdpS6lw7b5uIqVMZltaiT7iboXH+SbWqI+N0= X-Forefront-Antispam-Report: CIP:191.237.4.149; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:us1.smtp.exclaimer.net; PTR:us1.smtp.exclaimer.net; CAT:NONE; SFS:(4636009)(376002)(346002)(39850400004)(136003)(396003)(36840700001)(46966006)(8676002)(82310400003)(83380400001)(55016002)(2906002)(7696005)(336012)(6506007)(36860700001)(33656002)(33964004)(478600001)(9686003)(166002)(70586007)(70206006)(66576008)(8936002)(5660300002)(316002)(52536014)(82740400003)(26005)(7636003)(47076005)(6916009)(86362001)(186003)(356005)(7596003); DIR:OUT; SFP:1102; X-OriginatorOrg: Skylinenet.net X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jun 2021 21:58:40.6220 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8da29f1d-66ea-42eb-d25f-08d9382464dc X-MS-Exchange-CrossTenant-Id: 6d9102c7-bb77-4c07-b670-10ed3ffb09cd X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=6d9102c7-bb77-4c07-b670-10ed3ffb09cd; Ip=[191.237.4.149]; Helo=[us1.smtp.exclaimer.net] X-MS-Exchange-CrossTenant-AuthSource: MW2NAM04FT038.eop-NAM04.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR10MB5448 X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: [FFmpeg-devel] [PATCH 1/1] libavformat/rtsp.c: Reply to GET_PARAMETER requests X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: YGWb1wsCz9Jg Some encoders send GET_PARAMETER requests as a keep-alive mechanism. If the client doesn't reply with an OK message, the encoder will close the session.  This was encountered with the impath i5110 encoder, when the RTSP Keep-Alive checkbox is enabled under streaming settings. Alternatively one may set the X-No-Keepalive: 1 header, but this is more of a workaround.  It's better practice to respond to an encoder's keep-alive request, than disable the mechanism which may be manufacturer specific. Signed-off-by: Hayden Myers ---  libavformat/rtsp.c | 4 +++-  1 file changed, 3 insertions(+), 1 deletion(-) -- 2.20.1 Hayden Myers Principal Software Engineer t: (410) 590-2027 diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c index 9f509a229f..dc660368f0 100644 --- a/libavformat/rtsp.c +++ b/libavformat/rtsp.c @@ -1259,7 +1259,9 @@ start:          char base64buf[AV_BASE64_SIZE(sizeof(buf))];          const char* ptr = buf; -        if (!strcmp(reply->reason, "OPTIONS")) { +        if (!strcmp(reply->reason, "OPTIONS") || +            !strcmp(reply->reason, "GET_PARAMETER")) { +              snprintf(buf, sizeof(buf), "RTSP/1.0 200 OK\r\n");              if (reply->seq)                  av_strlcatf(buf, sizeof(buf), "CSeq: %d\r\n", reply->seq);