From patchwork Mon Mar 12 07:25:00 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hazem Ashmawy X-Patchwork-Id: 7948 Delivered-To: ffmpegpatchwork@gmail.com Received: by 10.2.1.70 with SMTP id c67csp1296357jad; Mon, 12 Mar 2018 00:30:54 -0700 (PDT) X-Google-Smtp-Source: AG47ELuU0qRgO/Cb3JP8CX5KTGo2MTGELLjIph5HxYjNnj3c1XIa7ja7QVPsQqSbvwpIgxQ63eBY X-Received: by 10.28.133.200 with SMTP id h191mr5111976wmd.39.1520839854307; Mon, 12 Mar 2018 00:30:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1520839854; cv=none; d=google.com; s=arc-20160816; b=itYjro8JDxyr2nnP3iVEQk8fqOvN+h0V2Usi/N4VNKklAT/12YYyc7EzLpqYyRLVQ9 CvtZN/1hvMxY8PXYPljnIZg8FsnWUTpwAtMw1LVxZ6kPUdesHvQiyh6Sy3vIyuwTITcH kyazAovx9/EX4+7PPGnhIXLggrMTe75h54bz+PEC28m2ZggCVO45DdW3ZolCFgk2GZ9E aZYXM4OIUpHHkbcUpyGnhzaAPnjK2BXBxQw8C1L+uW58ZECiNqDTPTaIf2egaKu8wjwA k7GBgaia1K0hWYMK4uYcnjrcnR4V9Emr/sBjrrjEu22x77p9Koh6bJnWXO8FEmmXPj0t mduQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:reply-to:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:to:message-id:date:from:references:in-reply-to :mime-version:dkim-signature:delivered-to:arc-authentication-results; bh=5sSel1QI+i/kbuGjVvyNpGQNOWTED5B2Uf4gOZLXUDI=; b=yNBE9dIFMXwmzPWVR0waQ0X2iDvdAUz1x/WVtA4cDkIff400P714T2yTEbmXxioxyq slpY70TZDpE5riAoPU6ek0gmKehw///QL40F4u+yH9f892gi1m/262YHekF9lRokbgVt fHo0ueScvIOkQavaGj8w+rkPPcUkVNtaXtuRYw8OaODvk2l5Lm78KnIvf+tFefyyWH9q 3ag3AtJUqRNQo0gpo25/WK/lLj/fOvTy0rmYaM7nk4VBh4+dfTrU4L2jikiLnV15E7kS FuB9TC7S6kfDHeSo90z2+AANDUA/V2nhBbYkeAYzHAiK1qRxKmVk0/UqlMIu9pEVXle7 Ak5Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20161025 header.b=u1Bl0fTd; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id l20si4331091wrg.3.2018.03.12.00.30.53; Mon, 12 Mar 2018 00:30:54 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20161025 header.b=u1Bl0fTd; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3051968A483; Mon, 12 Mar 2018 09:30:42 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-ot0-f173.google.com (mail-ot0-f173.google.com [74.125.82.173]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id BFFF4689F7D for ; Mon, 12 Mar 2018 09:30:35 +0200 (EET) Received: by mail-ot0-f173.google.com with SMTP id t2so14311915otj.4 for ; Mon, 12 Mar 2018 00:30:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=i1OQ/TAH5Ljo36kkZdiFTzmscnDtnJSGtGL66WY8oY4=; b=u1Bl0fTdfaGhZ83yrr2xnDF4To2sE0goaolKfFZiqO50HeFwwyPxoqQi7k9I+kQAVC kMctt96iBfcQR17AST0SSOZ3k0NB5lKQYCALEAD3EMkNYurGDF7mWuSoGR6Mr4H0jeI8 1MjoEdJpduNO8gkebGBYT10TOmwz0dJiBB4lhBhYv0NwDuN/sINMJ31tf7JMDyO3F8bS C6U/ojZ7rtk+XgmE/x/uu0rqpDGn4qfjV5HRdhfRPZjhSkAQ0jta1Ck5ePnwV5QPCqtH /O37DdUR5GhaHGEUMwVGRIwrPhi6csoWs46Y6fQ22V7VYIfw530ujr1W0CPetBYGKYY5 5YsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=i1OQ/TAH5Ljo36kkZdiFTzmscnDtnJSGtGL66WY8oY4=; b=cyr4unQ0Z3BGWaF4lSvABgU88aMMfVvZIW+FND5KMn7pO8G/7a37fXRc31s3VDCtuu K5ACc4rt5ejF8NBnD/uDhfFDn1pF4Im0k7qvmzRBECvrENlFJWEaloidy1MKgxzTznfs Oq+VAEHXvztkAs7tmZ1LBSWVK03lZlJ6f3nQL2AE4lHqSvblWEC8Iz59MmUfJ/99m/6K cy52mkBJFOumtltPsevLASQeu8SlGEdVK/SQ9VEBSZAL7N5rGIZh0PpXgVSq7TfBThqY 8EuC8/LIlm/txlBrJ4Zvxi6j9dA64gnYD8Tyutk7DDehEkSQmGjuRDHcxiDeNv0daBLE O6tA== X-Gm-Message-State: AElRT7EVOyHocU5nTbtInq82sqDCrOx5KcJGMzyeZrjFAR6V+ULhcknz 5xHlwyRSDZaB2n9Pd4oSWgaP85eccBoJweWFhtI= X-Received: by 10.157.86.129 with SMTP id o1mr5035961oth.363.1520839501452; Mon, 12 Mar 2018 00:25:01 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a9d:bf0:0:0:0:0:0 with HTTP; Mon, 12 Mar 2018 00:25:00 -0700 (PDT) In-Reply-To: References: <1520556648-10318-1-git-send-email-hazem.s.ashmawy@gmail.com> <1520556648-10318-2-git-send-email-hazem.s.ashmawy@gmail.com> From: Hazem Ashmawy Date: Mon, 12 Mar 2018 09:25:00 +0200 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH] avfilter: add panorama filter X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" So, I spend few hours trying to incorporate the partial change. I'm not sure that the video sent by earlier follows the faces order here https://github.com/google/spatial-media/blob/master/docs/spherical-video-v2-rfc.md#semantics-3 Because when I made this change, I got a reasonable equirectangular ouput: https://imgur.com/a/BEN00 comparing to the changes sent earlier. https://imgur.com/a/vaIvW What I'm saying is: when I changed face order to this (which video sample seems to follow), I got a reasonable output. down | left | top front | right | back Comparing to Google's: right | left | top down | front | back diff --git a/libavfilter/vf_panorama.c b/libavfilter/vf_panorama.c index de08ef4..5383d57 100644 --- a/libavfilter/vf_panorama.c +++ b/libavfilter/vf_panorama.c @@ -34,12 +34,12 @@ enum Projections { }; enum Faces { + DOWN, LEFT, + TOP, FRONT, RIGHT, - TOP, BACK, - DOWN, }; struct XYRemap { @@ -403,7 +403,7 @@ static int config_output(AVFilterLink *outlink) switch (face) { case LEFT: - locate(z, x, y, M_PI, rw, rh, &ox, &oy); + locate(z, x, y, -M_PI_2, rw, rh, &ox, &oy); break; case FRONT: locate(x, z, y, 0., rw, rh, &ox, &oy); @@ -418,7 +418,7 @@ static int config_output(AVFilterLink *outlink) locate(x, y, z,-M_PI_2, rw, rh, &ox, &oy); break; case DOWN: - locate(y, x, z,-M_PI_2, rw, rh, &ox, &oy); + locate(y, x, z, M_PI_2, rw, rh, &ox, &oy); break; }