From patchwork Wed Mar 27 14:02:36 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Carl Eugen Hoyos X-Patchwork-Id: 12499 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id 09813446CEB for ; Wed, 27 Mar 2019 16:02:46 +0200 (EET) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C412F68A59E; Wed, 27 Mar 2019 16:02:45 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-io1-f45.google.com (mail-io1-f45.google.com [209.85.166.45]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id E423B68A17A for ; Wed, 27 Mar 2019 16:02:38 +0200 (EET) Received: by mail-io1-f45.google.com with SMTP id b9so14101941iot.13 for ; Wed, 27 Mar 2019 07:02:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=Lo0vpKz23n0r413EvAQMOcy1jhQXbNpseLepCT1MpAs=; b=vGiqXj7To0p8nZ64NDRncLNwK5Zvwyhd6CGwiYpkL0Cx8p41hmg15gz18LCpoTlf5Z xKJej4blg9/12i5VDe/n1dfQOdndWWSlZchB/Ougd+2HRH67vIRc61d+d8jlFjLBiLSz ffHtAlIMr0zu3NmBU+skUpCeQaRK90X5UJuNV1XL+uevF7e4QuPntWA6cmA0tIUSlqTs 9e1v31oen3lCMmM/SKVB52KEjQepQdx8piwtwl5jWiQHvEGI26eXUkUzr61yKRFYh7Y6 nwTj7xpviJmm3kTnuhCMjPINu2CP70TwHHzltslB2PZOtRgjpwlh2sNUV3py+PJxdDZh /D5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=Lo0vpKz23n0r413EvAQMOcy1jhQXbNpseLepCT1MpAs=; b=cfnSFA3ofew0Uq+4eYAHXVddEdWuwBbtcTnZVVlqBAwv541gwFa924lLPl91WcnN0J BI/B8CuZrxnB5PQ/VPnSaT4QA7hLjDy0kM/fF0QAbQvRMjSb7NvCZV3eu33ypaRpFUs6 FKo94A3Qn5sddTejEXopTV8P1DlhtV7Uzk02SlgE1zrD5nA8AeoYDdd5fsgA4XtPOjHB ASXrqMpxIi8QrTaE/CiihwwJbgIXgYqUygagv4cBL58cAe5soBGjiceqZFv7TB6T0Q8U IMFp+4MbVD5jdKdEShN1by+yC/KRaR8zQVqogHdQGjD7k30GvqRgeC75Iix90iLeWyAJ rnig== X-Gm-Message-State: APjAAAWJJK7EYf7z455cfIWEuU7OJSHVORHwJ5YBuSYULIcXblFtaNtm NFiPiG18Brq53bj/dtN1CPac5biOMbV5/qPfNI/03Q== X-Google-Smtp-Source: APXvYqxajWdDhFudce/0khPyCYM33gN+oJoFbin82fgMHavq92Pb89J3h3FNHtUJoxg0jg2VcBuMcw9rLuitbPtQoMg= X-Received: by 2002:a6b:7b03:: with SMTP id l3mr7862946iop.250.1553695357248; Wed, 27 Mar 2019 07:02:37 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a02:5503:0:0:0:0:0 with HTTP; Wed, 27 Mar 2019 07:02:36 -0700 (PDT) From: Carl Eugen Hoyos Date: Wed, 27 Mar 2019 15:02:36 +0100 Message-ID: To: FFmpeg development discussions and patches Subject: [FFmpeg-devel] [PATCH]lavc/vaapi_h264: Do not set unused deprecated fields X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Hi! I don't think setting vaapi fields that are deprecated makes sense, this also silences a warning when compiling with clang. Please comment, Carl Eugen From b1f4e64e577ffecd1eab7b95d8d6f90e261cdd74 Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Wed, 27 Mar 2019 14:58:51 +0100 Subject: [PATCH] lavc/vaapi_264: Do not set deprecated unused fields. Fixes the following warnings: libavcodec/vaapi_h264.c:259:10: warning: 'num_slice_groups_minus1' is deprecated [-Wdeprecated-declarations] .num_slice_groups_minus1 = pps->slice_group_count - 1, ^ libavcodec/vaapi_h264.c:260:10: warning: 'slice_group_map_type' is deprecated [-Wdeprecated-declarations] .slice_group_map_type = pps->mb_slice_group_map_type, ^ libavcodec/vaapi_h264.c:261:10: warning: 'slice_group_change_rate_minus1' is deprecated [-Wdeprecated-declarations] .slice_group_change_rate_minus1 = 0, /* FMO is not implemented */ ^ --- libavcodec/vaapi_h264.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/libavcodec/vaapi_h264.c b/libavcodec/vaapi_h264.c index 5854587..dd2a657 100644 --- a/libavcodec/vaapi_h264.c +++ b/libavcodec/vaapi_h264.c @@ -256,9 +256,6 @@ static int vaapi_h264_start_frame(AVCodecContext *avctx, .log2_max_pic_order_cnt_lsb_minus4 = sps->log2_max_poc_lsb - 4, .delta_pic_order_always_zero_flag = sps->delta_pic_order_always_zero_flag, }, - .num_slice_groups_minus1 = pps->slice_group_count - 1, - .slice_group_map_type = pps->mb_slice_group_map_type, - .slice_group_change_rate_minus1 = 0, /* FMO is not implemented */ .pic_init_qp_minus26 = pps->init_qp - 26, .pic_init_qs_minus26 = pps->init_qs - 26, .chroma_qp_index_offset = pps->chroma_qp_index_offset[0], -- 1.7.10.4