From patchwork Wed Jun 24 22:04:32 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Carl Eugen Hoyos X-Patchwork-Id: 20593 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id 8E9D144AD4D for ; Thu, 25 Jun 2020 01:04:50 +0300 (EEST) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 6EE71680ABA; Thu, 25 Jun 2020 01:04:50 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-lj1-f174.google.com (mail-lj1-f174.google.com [209.85.208.174]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 705A06802AB for ; Thu, 25 Jun 2020 01:04:44 +0300 (EEST) Received: by mail-lj1-f174.google.com with SMTP id i27so4253595ljb.12 for ; Wed, 24 Jun 2020 15:04:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=GnbXas4tiwViVzEKTg6EmAJjkdUkIciGc4AyAtsxdy4=; b=gJPqEZSXk7q5/KNprT9RQxdMAQyfyteIsySgni4tR1NVDlDFtj2gTQhtbfLTX80khL n95Sy2QdVVE4M1javORqIkAZhmbyR236tWgl/IBhk5+WP+dheFE12dEiW+vUpoNl5HcQ 9EYHmkVAX+YIAlGqO21zCKMdlArxD2XAseyHGeH0k/rRriJ84BnlDEr9IJTnjMaTJgqY lVeSUl+d/Z5hK/J3HTJ4ly9UP8vj0T2cnnfBZtT3DQj60MSOyqm3Yzb7Kv/btfxXAtb5 RG+WPnKqhW2moViVkL9H6zkScCuEeTFY9lT+C65bnRLuahel4ahjm25xLzUqFXzI7Hpd N3Zw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=GnbXas4tiwViVzEKTg6EmAJjkdUkIciGc4AyAtsxdy4=; b=WdrgZIsn+8gCEu0FM28CkgnxRt0s6eiYi6CWni1IZQyWW8mYFzfSxg/iAg2Dz0llRZ Szq9s3/Dh3+1hvdxNkgFrP/LMHvz44pI1xSxsUSEhzQofy+9+hTYHcoInhly+WgDg61x y2md3mc7KJ43Mn+rfxYEiARQphvVzCKoJG2HH7FbCKE/k2lj45LFTgfrhcJdiXZBMx1a EmKb5sSjiGjPt9ihAew3jEAvtEYfwgJ+mGCTHcXfpzkuWUXyNcvdBZ8y4GtKWkxYhflp 8ejZFg5E/C3eMD+Ga35hlNepSxsQe6rw7WcemfhCZWzV9nPKeJHgWXmd5OpUQzWVv91z ka0g== X-Gm-Message-State: AOAM531bTWiPVgfb3ImBdhLM3yJ7Cb8B1ADwxG/0D408r8sRk5qCZALA vjMIMUXDLkwvy5u2LIWBz7Gq5lfSq88AnhN0YlkGLCrh X-Google-Smtp-Source: ABdhPJzC0JpbE6t8zc3O9wE6jyNT/rAPU4AbwJTLeTYy20TuK/9ePpKqPn2UgqS1kicM+O0q06F64tWvSTs36hk9KCk= X-Received: by 2002:a2e:a494:: with SMTP id h20mr15573732lji.252.1593036283477; Wed, 24 Jun 2020 15:04:43 -0700 (PDT) MIME-Version: 1.0 From: Carl Eugen Hoyos Date: Thu, 25 Jun 2020 00:04:32 +0200 Message-ID: To: FFmpeg development discussions and patches Subject: [FFmpeg-devel] [PATCH]doc/examples: Always open files as "binary", not "text" X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Hi! Attached patch fixes ticket #8638 and the only other occurrence of fopen() without b in doc/examples. Please comment, Carl Eugen Subject: [PATCH] doc/examples: Always open files as "binary", not "text". Fixes ticket #8638. --- doc/examples/decode_video.c | 2 +- doc/examples/hw_decode.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/examples/decode_video.c b/doc/examples/decode_video.c index 169188a4b9..18ee90a6c0 100644 --- a/doc/examples/decode_video.c +++ b/doc/examples/decode_video.c @@ -41,7 +41,7 @@ static void pgm_save(unsigned char *buf, int wrap, int xsize, int ysize, FILE *f; int i; - f = fopen(filename,"w"); + f = fopen(filename,"wb"); fprintf(f, "P5\n%d %d\n%d\n", xsize, ysize, 255); for (i = 0; i < ysize; i++) fwrite(buf + i * wrap, 1, xsize, f); diff --git a/doc/examples/hw_decode.c b/doc/examples/hw_decode.c index f3286f472d..71be6e6709 100644 --- a/doc/examples/hw_decode.c +++ b/doc/examples/hw_decode.c @@ -223,7 +223,7 @@ int main(int argc, char *argv[]) } /* open the file to dump raw data */ - output_file = fopen(argv[3], "w+"); + output_file = fopen(argv[3], "w+b"); /* actual decoding and dump the raw data */ while (ret >= 0) {