From patchwork Fri May 1 21:57:51 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Carl Eugen Hoyos X-Patchwork-Id: 19423 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id B9F3F44B1BB for ; Sat, 2 May 2020 00:58:11 +0300 (EEST) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 98DDA68BED8; Sat, 2 May 2020 00:58:11 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-io1-f41.google.com (mail-io1-f41.google.com [209.85.166.41]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A210868BED8 for ; Sat, 2 May 2020 00:58:04 +0300 (EEST) Received: by mail-io1-f41.google.com with SMTP id d7so1331739ioq.5 for ; Fri, 01 May 2020 14:58:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=qHMkCl9wk/HmPIui66bQC8gLgPLmjjbxcnBPWJT972Y=; b=jmvHnedETt8oljYjh4TeYKnFTqpTlsqbK6FOSpB1C3LGealbqXK6ZlHfcc8vx6hqFZ H2Dh1Nzm4w89qUHBOxQomFENqzxi9WfMpO3gF2KKaM1oahAdlVsNor2BVEQ4NreddadM NSVWvAj7oR37kSs15j1tEWBMfEwml090No6ONSVn5Fmv9CYE6LlxL+ygA1ExGDTSHP++ SHyZBb3n6dCdBD+FWsdkNdeb9Lnu4n2DU1svwXlU50szIYbu5q56x8WaETfkkBQ49EEQ 6LauxDBEVhDk+gI9bBipFvhUnZd8u4ky2DudyRD7TqrqmTQylWCKPWGsWxn6MeRTH71q LQAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=qHMkCl9wk/HmPIui66bQC8gLgPLmjjbxcnBPWJT972Y=; b=YKtKh3znPQEwUQIBXYfaf8MA9WBWQwzheWSaO+AP8AD7+Je2V9Em05lV9V3Iy2F9Nl hr9Y0n9dWamdviwTKEKP1SVflQVUgON6z7PB7rQCCNLC6E7IW583RX9fm98dT5uTONIG KNI/lkF0wU3HnGxMZU/a79llVlt5R8mnQQQnLDCpzI3FHyw0D9WWRKLB9CDb+H68pq4s fWEkS3uzofbTsv97/ZqYDWN20EWozlkKDyPLClt7iXLzpZ75y/5dzIBZnWCGW0bBoYLt JLi8KLbugKdChv0ncwh8YeUCDxP7eMBaHyuDgqnZP2VqS1RWNkARfRzl7x7RF1unP3YF h2Yg== X-Gm-Message-State: AGi0PuZauY5V8UraYRBLp78iM7AS2lRG5RjWl2vnI4606KijnXdEv06e y5XAp+TczBmCAUvfhgwshwzC7szyaBvLxd7tPTzTGO74 X-Google-Smtp-Source: APiQypLxJcg+XScqBkqb2P/U+xLjYWZAfAPJkoiKvLOvslKKWl7w1XpbD2DStwwh/KnH9duu/MZ4fQjIzRN1p5CrV8M= X-Received: by 2002:a05:6602:2e96:: with SMTP id m22mr5905329iow.169.1588370282881; Fri, 01 May 2020 14:58:02 -0700 (PDT) MIME-Version: 1.0 From: Carl Eugen Hoyos Date: Fri, 1 May 2020 23:57:51 +0200 Message-ID: To: FFmpeg development discussions and patches Subject: [FFmpeg-devel] [PATCH]lavfi/signature: Fix a cast of a function pointer X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Hi! Attached patch fixes an ugly warning when compiling with -Wpedantic. I am not in favour of adding casts to silence such warnings, but there already is an incorrect cast. Please comment, Carl Eugen From ed41ff40b9e1bff357b52394dcfa1107dc4ada74 Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Fri, 1 May 2020 23:54:24 +0200 Subject: [PATCH] lavfi/signature: Fix a cast of a funtion pointer. Fixes the following pedantic warning: libavfilter/vf_signature.c:294:69: warning: ISO C forbids conversion of function pointer to object pointer type --- libavfilter/vf_signature.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavfilter/vf_signature.c b/libavfilter/vf_signature.c index d07b213f31..3524ce5d50 100644 --- a/libavfilter/vf_signature.c +++ b/libavfilter/vf_signature.c @@ -291,7 +291,7 @@ static int filter_frame(AVFilterLink *inlink, AVFrame *picref) } /* get threshold */ - qsort(sortsignature, elemcat->elem_count, sizeof(uint64_t), (void*) cmp); + qsort(sortsignature, elemcat->elem_count, sizeof(uint64_t), (int (*)(const void *, const void *))cmp); th = sortsignature[(int) (elemcat->elem_count*0.333)]; /* ternarize */ @@ -317,7 +317,7 @@ static int filter_frame(AVFilterLink *inlink, AVFrame *picref) } /* confidence */ - qsort(conflist, DIFFELEM_SIZE, sizeof(uint64_t), (void*) cmp); + qsort(conflist, DIFFELEM_SIZE, sizeof(uint64_t), (int (*)(const void *, const void *))cmp); fs->confidence = FFMIN(conflist[DIFFELEM_SIZE/2], 255); /* coarsesignature */ -- 2.24.1