From patchwork Mon Oct 29 21:14:32 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Carl Eugen Hoyos X-Patchwork-Id: 10842 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id 193C844D1C9 for ; Mon, 29 Oct 2018 23:14:38 +0200 (EET) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 85D2568A6CF; Mon, 29 Oct 2018 23:14:09 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-io1-f45.google.com (mail-io1-f45.google.com [209.85.166.45]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 1535F68A6BC for ; Mon, 29 Oct 2018 23:14:03 +0200 (EET) Received: by mail-io1-f45.google.com with SMTP id n18-v6so5928941ioa.9 for ; Mon, 29 Oct 2018 14:14:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=XjynZnCeu9R+hqOgWS+G1E/vp6cN+cnILax1t77QAnY=; b=QR0J5g8VSiocHxwyV56yRBceKYxYldh1bvEMeq9uMi8olPk4CeCd6Hju8sNsddpaOe mrUxe23EBB+U1btUNojBNdicslqsY6gf/nhlCA3t9J3JYBWG4fnoQwQsCmLRzQkqTxl/ yJ9GPL2rdGAnErL9j3SY/n/HnKKmpGZKq9sSkN7SmtEgHqsAIhLRSpvp1EO2dVCy4w7c Z3kDaaI6ixNiU+X1yu53csWDEJ9FV7oYTW79E1zl/fk4DdiBFOHWXwdo+o2Ex+Ge5+oN CSMdVOjsCZvP3wciYaBaZfjhprDEKsYY2PFJOqxNCVjeud7X3uZ1zgNQ5C2HhS91+lUw Mo4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=XjynZnCeu9R+hqOgWS+G1E/vp6cN+cnILax1t77QAnY=; b=uDz0Ki9v4/EXZ5iePAjK472tOkdb7yMmZgHiEpTQhIOalYSuQqeU4xICw5w7ceSJHw t5M8vPSPNmJVBKi/N6XofRf22U4bVOWjOppYbWgyaWOJObscF3uS2uTdBafJjERJZlYU QW2xyBgqK8CxXzQoCo/Jg88l/N3LyclFzI7qPTfDHsEaxDHlpwtQIlNr8axB/OcQyjgz u01tEA/fLu+JejaUz6MQagDIwVQ1RUjSDTsjwElA4t6r0V5mBb4lO36GVYxRyCUbr92v 9EVFwuP15gjPj+F7vGUM/z2BfsvHVso9Lr96A+Xwf8Kd/Bk8RomNmE9TaEudyEnC4Kda taVQ== X-Gm-Message-State: AGRZ1gJ3FO100oqegMiaqN/lWCyuxGAqToW2Zhl7PhY75w+UwrBTAKHQ PBVFQxtpect/EyPLugbVnlKsjBXjgwrot2mqx34IkQ== X-Google-Smtp-Source: AJdET5epSgPmwRFyQOp1a2NnElSGPgwFAd6vexzy6qD0nYFObtFAkg1US8iTmg8LJN+ChKttvZQb5NL0QHQvxHL+KVM= X-Received: by 2002:a6b:d409:: with SMTP id l9-v6mr10256670iog.55.1540847672670; Mon, 29 Oct 2018 14:14:32 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a02:9854:0:0:0:0:0 with HTTP; Mon, 29 Oct 2018 14:14:32 -0700 (PDT) From: Carl Eugen Hoyos Date: Mon, 29 Oct 2018 22:14:32 +0100 Message-ID: To: FFmpeg development discussions and patches Subject: [FFmpeg-devel] tests/api-h264-slice-test: fread returns size_t, not ssize_t. X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Hi! Attached untested patch is supposed to fix ticket #7521. Please comment, Carl Eugen From ad5a9de93a8cfe261636993532246befddea984d Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Mon, 29 Oct 2018 22:11:54 +0100 Subject: [PATCH] tests/api-h264-slice-test: fread returns size_t, not ssize_t. Fixes ticket #7521. --- tests/api/api-h264-slice-test.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/api/api-h264-slice-test.c b/tests/api/api-h264-slice-test.c index 57e7dc7..9ca30dc 100644 --- a/tests/api/api-h264-slice-test.c +++ b/tests/api/api-h264-slice-test.c @@ -180,15 +180,15 @@ int main(int argc, char **argv) while(1) { uint16_t size = 0; - ssize_t ret = fread(&size, 1, sizeof(uint16_t), fd); - if (ret < 0) { + size_t ret = fread(&size, 1, sizeof(uint16_t), fd); + if (!ret) { perror("Couldn't read size"); exit(1); } else if (ret != sizeof(uint16_t)) break; size = ntohs(size); ret = fread(p, 1, size, fd); - if (ret < 0 || ret != size) { + if (ret != size) { perror("Couldn't read data"); exit(1); } -- 1.7.10.4