From patchwork Sat Aug 10 15:35:59 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Carl Eugen Hoyos X-Patchwork-Id: 14376 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id 05C0844A1F4 for ; Sat, 10 Aug 2019 18:36:18 +0300 (EEST) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E06F368AB37; Sat, 10 Aug 2019 18:36:17 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-ot1-f65.google.com (mail-ot1-f65.google.com [209.85.210.65]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id F3AB568AABF for ; Sat, 10 Aug 2019 18:36:11 +0300 (EEST) Received: by mail-ot1-f65.google.com with SMTP id d17so144277851oth.5 for ; Sat, 10 Aug 2019 08:36:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=Oo2smAVa6htM+7BD6NCskyou9QPvUmS/HGqtqiGOuHI=; b=peW33yF/1EhhIinsNMKFR8xQLsMyKvsdS9VCvLYXYBF82doVDf+lmPE7wHwal2CKZq XvCrUh8pTFn8BzTYYFDq2B3afqgDOGYml/WuDa3W6W+K0C/L5dEQADtwF9vF7n375SKw gPFaniFlED8+dV2WG3a48+Vj9zWfrN5xfFnpCWd5j5bzovA88O9RG+YWjlXcZBq2r3QM j6T44gBLJSwitjSzivlPoVYzTRaKqBxJDLwcbJT8cypORGqzUaDidzttzoXFeBepc8KM CpPpM0C86RRbos0ZAPEDU2PRudQ+J9jVIC1+a8d9BUDqENhBnvD1LsYjyJOUMI0ByHAb TYhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=Oo2smAVa6htM+7BD6NCskyou9QPvUmS/HGqtqiGOuHI=; b=H/5RPE2TnGV043u1i+q2Jo+FPZ3LTwYyCmMGSITK4cfPnaWbsnQ+UQbkcrNjgLnXhY 6NUsJ/3+o7NzQhKyJFk0HI+9h6/84XxXtbibVvL5Wd0vc6pdl+H+uOX9xRk3J+ilYPpa wFJF9MONNujVMpsahxNrTHk31uoO5C5i5+76uv4KgcXzDCp8VdQ1JqzxLPXt5FzeZspS 6oKw3o+MxFhW/qhhF+QJ4ogVH/mkC8vOPluLjOr6z1nTkQkpulpmh1rXhi+RDOfglOz3 UdO2tF8eaDQFahHY62QSDczni5jzR8yNXDMZBwMI3W8z+RoTgBdEBsws9HAmmDaNwX9f iZVA== X-Gm-Message-State: APjAAAWdIqG+mIH+SXTQJ1A+UTaAQZpzW8n1npsM5R3BB7UpatLKgjF6 jssfr1vfKai10uSElPA2fThyXsPSscikqMTFesXKmw== X-Google-Smtp-Source: APXvYqwIQKV7aPzIJeWlDipIVg/rMWfWCz9wOrvxwwQlvc9MoR/BZS2PNsC9ZdqH+7TP80aj6B3apBXdYt2OZxBy+xQ= X-Received: by 2002:a6b:fb02:: with SMTP id h2mr26504333iog.289.1565451370510; Sat, 10 Aug 2019 08:36:10 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Carl Eugen Hoyos Date: Sat, 10 Aug 2019 17:35:59 +0200 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH]lavc/libx264: Cast bit_rate to int64_t to avoid an integer overflow X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Am Sa., 10. Aug. 2019 um 17:12 Uhr schrieb Carl Eugen Hoyos : > > Hi! > > Attached patch really fixes ticket #8071 for me. Simpler variant attached. Carl Eugen From e94234fb683b30518d96b1a36aba9e27c4cf9f1b Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Sat, 10 Aug 2019 17:10:58 +0200 Subject: [PATCH] lavc/libx264: Cast bit_rate to int64_t to avoid an integer overflow. Fixes ticket #8071. --- libavcodec/libx264.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/libx264.c b/libavcodec/libx264.c index dc4b4b100d..772fc614ac 100644 --- a/libavcodec/libx264.c +++ b/libavcodec/libx264.c @@ -898,7 +898,7 @@ FF_ENABLE_DEPRECATION_WARNINGS if (avctx->max_b_frames < 0) avctx->max_b_frames = 0; - avctx->bit_rate = x4->params.rc.i_bitrate*1000; + avctx->bit_rate = x4->params.rc.i_bitrate*1000LL; x4->enc = x264_encoder_open(&x4->params); if (!x4->enc) -- 2.22.0