From patchwork Tue Dec 11 02:16:38 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Carl Eugen Hoyos X-Patchwork-Id: 11369 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id 4A40744CB53 for ; Tue, 11 Dec 2018 04:16:46 +0200 (EET) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 938D368A9BE; Tue, 11 Dec 2018 04:16:36 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-io1-f46.google.com (mail-io1-f46.google.com [209.85.166.46]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id BD60A68A808 for ; Tue, 11 Dec 2018 04:16:29 +0200 (EET) Received: by mail-io1-f46.google.com with SMTP id f10so10518912iop.10 for ; Mon, 10 Dec 2018 18:16:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=yzIl+JTnghVeHJo8uMOTJqlt8YynyvG1iy02EnKOyCw=; b=WU8ycxb7RhydJRnaEmEkaS2zAdZ4hUaeLQZqKm6gaeklG+UcuTHt3Kbn94YjRnxcDS j5s0jHkkW5UtnzvuGjX/3xqEvPWh1Pd8c0URnR9jLRnnlVffqcR0oP/8YoODMdxhEkGR I+nc18t+eZRTwaq478Y6A6EcS5rySjc0sIckHZRwWw3Q+NWkH93d9QMpDlkib0p4HqdI fzOsLQ041zcCrngK7WMRIX7g7YoJakcbkju+4SKco+o3ytWamVyWonThq/OoCbF2QAOE azU0RHj9RITaueBLmTs8k+IqgZXuf7dlroSe3r5v+7fkzc0ZxPUPDjjT7eabEI/D4HIV 0tYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=yzIl+JTnghVeHJo8uMOTJqlt8YynyvG1iy02EnKOyCw=; b=Nri43CqV1qeg7SNmA5zOStE0/Wy816SIQtxX7UgDMoevQKTDYnij2ph+6USdzzaBQa pBbW+qii2wh/QayGZD1d9/afjv0kUZOzJ8FAKwcnQ2jhUiKcmylPk1rD1RE/cU1huZIJ 51xIfUBHWX3aLIN26HQ9x6qqloYf/mtr83yVDPvoMQ3aDk7ROqgcbZ9DmRJtMkU5kAi2 YzfOU5n3SmaweufiIAtzFxTy6pABnol309S4xW4wg5lIRY7TUfL0TDbIo+HGovDuvcRX HG96bhcoH+z4T3FdaMHqJck6IJ5+jRMRVf/6anHp0TxlsW9Ru6ISUtfj22W2JDw1V/rk FWag== X-Gm-Message-State: AA+aEWaLMeX1yVYvKxNFAQSTYeLjZ14cD5C9WCG1BiaOwVBmbttSl7Dj nz4TNsVpA0zvoY8851gm8a4Db/4svDHa4Hw+tnG63Q== X-Google-Smtp-Source: AFSGD/U2htUvSF2hnNbpXbDgvZiOZxj58XdluNNMEmZGBQmWjOMDazeePc9eWk+uKmvQMScoGoio2Y8Z6x5RPBqYUqI= X-Received: by 2002:a5d:9405:: with SMTP id v5mr12278195ion.250.1544494599506; Mon, 10 Dec 2018 18:16:39 -0800 (PST) MIME-Version: 1.0 Received: by 2002:a02:5f11:0:0:0:0:0 with HTTP; Mon, 10 Dec 2018 18:16:38 -0800 (PST) From: Carl Eugen Hoyos Date: Tue, 11 Dec 2018 03:16:38 +0100 Message-ID: To: FFmpeg development discussions and patches Subject: [FFmpeg-devel] [PATCH]lavfi/signalstats: Cast AV_RN16() output to int. X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Hi! I suspect attached patch fixes a bug on some platforms, silences a warning. Please comment, Carl Eugen From cfc9e3fd1e24d108581bad096a4de987069b2c49 Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Tue, 11 Dec 2018 03:12:49 +0100 Subject: [PATCH] lavfi/signalstats: Cast the return value of AV_RN16() to int. It is unsigned at least on arm, fixes the following warnings: libavfilter/vf_signalstats.c:833:21: warning: taking the absolute value of unsigned type 'unsigned int' has no effect dify += abs(yuv - AV_RN16(prev->data[0] + pw + i * 2)); --- libavfilter/vf_signalstats.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavfilter/vf_signalstats.c b/libavfilter/vf_signalstats.c index 298881b..2b8c0de 100644 --- a/libavfilter/vf_signalstats.c +++ b/libavfilter/vf_signalstats.c @@ -830,7 +830,7 @@ static int filter_frame16(AVFilterLink *link, AVFrame *in) masky |= yuv; histy[yuv]++; - dify += abs(yuv - AV_RN16(prev->data[0] + pw + i * 2)); + dify += abs(yuv - (int)AV_RN16(prev->data[0] + pw + i * 2)); } w += in->linesize[0]; pw += prev->linesize[0]; @@ -848,9 +848,9 @@ static int filter_frame16(AVFilterLink *link, AVFrame *in) masku |= yuvu; maskv |= yuvv; histu[yuvu]++; - difu += abs(yuvu - AV_RN16(prev->data[1] + cpw + i * 2)); + difu += abs(yuvu - (int)AV_RN16(prev->data[1] + cpw + i * 2)); histv[yuvv]++; - difv += abs(yuvv - AV_RN16(prev->data[2] + cpw + i * 2)); + difv += abs(yuvv - (int)AV_RN16(prev->data[2] + cpw + i * 2)); histsat[p_sat[i]]++; histhue[((int16_t*)p_hue)[i]]++; -- 1.7.10.4