From patchwork Thu Nov 23 11:09:50 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Carl Eugen Hoyos X-Patchwork-Id: 6293 Delivered-To: ffmpegpatchwork@gmail.com Received: by 10.2.161.94 with SMTP id m30csp646085jah; Thu, 23 Nov 2017 03:10:20 -0800 (PST) X-Google-Smtp-Source: AGs4zMbsk34NL5DWBU3kcRGXRJDcZFJUai+JFJmuR2kfqy/1J45sK6eG1lylEc/3xpgiJ0dSS3+u X-Received: by 10.223.176.121 with SMTP id g54mr20303701wra.165.1511435420828; Thu, 23 Nov 2017 03:10:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1511435420; cv=none; d=google.com; s=arc-20160816; b=c1b3HmhZXBco8aJv0OJ1rzSSZ192L4Bpl0Te59JbKmLnGQuXzjfNJIgEFBxpWUU5r1 3mxWv3eyklyj4XXT0Wst9CnneUTB3r2hfPmEQqRGxBxVQictu36bPN3ZtqTxeZvagJ33 bo010xJe2Js1AZ3KHc6397UD5MqeWnVtvlwFuKbYRvmqFhwUrZf+GBe6FlE9qrIJcQbd nUH7ekrKrlNvrJ2RZa1ZDeGF+eBK7mNN8yGsblSHvXz8CmeUSFeJsKUwowwZD3f26MRI JQqCMPFBj+zfk+GS/pChukLSFcFHbU5z5pdVG7Tfed8CMrwcCaPgH5ZCKXBl+xW6Jfpw O0ww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:subject:to :message-id:date:from:mime-version:dkim-signature:delivered-to :arc-authentication-results; bh=NNQPKBWV00pBkj6F7vWK4wYfBPXCIKUPoq3gab5gw0U=; b=StnXaQfcfuL5elDFVF+eghr5JOglWp1PTJHuA94Ps76+oCz9DAu8cB64jBbhu5ExB+ OqVVonfjAPX+57e25SHIzhSm0C5n0paZsyjQqVwurLckqVkul+OaAmouZC/WxzUiv25b rH4UZ4dsRyMf21MD875Z0QcVGAGdyLSX+JgS6mvRFNOgYtlxHdnRe0E5fVRE+qrCV5PM PIE6+SY5uUPuJ8FB2A3ID98TzI4Sc81Pu7XL9LA9RzwkdOMV+42W5JHQDHGu9RCeuR4L MO1WGdXxnw4lyXFDRaMZ9OBDWgU8Q/CpTYEuCzu+Acjms4oeUOrdi9EQV6mPos3hCEMU kraw== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20161025 header.b=KN3Wc0iu; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=gmail.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id i55si14336388wra.76.2017.11.23.03.10.20; Thu, 23 Nov 2017 03:10:20 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20161025 header.b=KN3Wc0iu; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=gmail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B9A756899DC; Thu, 23 Nov 2017 13:10:18 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-io0-f173.google.com (mail-io0-f173.google.com [209.85.223.173]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 34F2B680362 for ; Thu, 23 Nov 2017 13:10:12 +0200 (EET) Received: by mail-io0-f173.google.com with SMTP id i184so18883801ioa.0 for ; Thu, 23 Nov 2017 03:10:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=586oMypI1iMwwgipRXGD3jczeALC9TcQdLEjqXltDTU=; b=KN3Wc0iu3VYbwWmVK/bGJ9ZuUkSaPI3GEuRIYFEbkF73bYyzPcZWRZ2xQvzApk7sWB X1grnaHdVnN5E/LyzxrTBwzpl67PuHaOiieB/2FCokxafDtTj0Blg7x7CbAS+uZ+6XXT E4ZR2ybQEKkil67pXbMiUAvOX5c/x+bqibZX9NbgABKWosdPYxKSyM6lWYW54fiMw24z hYFtyeXgT5F+vSgvp1OmhV4X7/X90FtVB40qIUTJde2wZdTGgjJSX3SJL0Zpf2XsXPmR IXZKJafNhZv9/7FcNjZlO2vwOCGifGYem+L4/9WJGZ1FKeoOF3g6Utmw+Zl2tevLSX4V yM2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=586oMypI1iMwwgipRXGD3jczeALC9TcQdLEjqXltDTU=; b=OX9WqSYWg1gso49MGQBOIYkxLNeCOnTJa/4gvKBWcbYFI4GRPMtO9l4nl6a0mvcW1L Mgh09+QDySwikqAm648Orb/aPi9ZACK81ucgn/APKpp1kPn53ltnvUnsWQ2LygGrndz4 YWGjw5pDZZ2nzOO6INTLXxHVfwtZOW6rfQo/GNHHC5fX4NScWObdUTwses0QqleK+B1R HU5nviuZajKRsjt+y0crdTAHgCDqS/KkXivUtBv7DhFEf2QUCyYnNBePUCb1aFiJQX/V Wm3WX1HVoQx6ffT6qV8+TAeC28K4CgUVBbdXsfVcHKVUh2rNoHcbkZBm8SYBEIpXMltF PVQA== X-Gm-Message-State: AJaThX4vZnKzJg6SJZXvPHphGmrlsvSYS5st4UDQgvSt2HmNwGcvhiwQ QaYhN/xXjpbl6dduQIqfit0dcCSSmgZzIVJqIws= X-Received: by 10.107.16.206 with SMTP id 75mr4004215ioq.83.1511435411384; Thu, 23 Nov 2017 03:10:11 -0800 (PST) MIME-Version: 1.0 Received: by 10.2.155.66 with HTTP; Thu, 23 Nov 2017 03:09:50 -0800 (PST) From: Carl Eugen Hoyos Date: Thu, 23 Nov 2017 12:09:50 +0100 Message-ID: To: FFmpeg development discussions and patches Subject: [FFmpeg-devel] [PATCH]ffmpeg: Improve warnings if av_buffersrc_add_frame*() fail X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Hi! Attached patch implements more verbose warnings as suggested by Nicolas. Please comment, Carl Eugen From 5ec3b8bdb776d9c14127017cd9e3077503be2bea Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Thu, 23 Nov 2017 12:05:51 +0100 Subject: [PATCH] ffmpeg: Improve warnings if av_buffersrc_add_frame*() fail. Suggested-by: Nicolas --- fftools/ffmpeg.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c index 0c16e75..3ce8833 100644 --- a/fftools/ffmpeg.c +++ b/fftools/ffmpeg.c @@ -229,7 +229,8 @@ static void sub2video_push_ref(InputStream *ist, int64_t pts) AV_BUFFERSRC_FLAG_KEEP_REF | AV_BUFFERSRC_FLAG_PUSH); if (ret != AVERROR_EOF && ret < 0) - av_log(NULL, AV_LOG_WARNING, "Error while add the frame to buffer source(%s).\n", + av_log(ist->filters[i]->filter, AV_LOG_WARNING, + "Failed to add a subtitle video frame to the buffer source: %s\n", av_err2str(ret)); } } @@ -307,7 +308,9 @@ static void sub2video_flush(InputStream *ist) for (i = 0; i < ist->nb_filters; i++) { ret = av_buffersrc_add_frame(ist->filters[i]->filter, NULL); if (ret != AVERROR_EOF && ret < 0) - av_log(NULL, AV_LOG_WARNING, "Flush the frame error.\n"); + av_log(ist->filters[i]->filter, AV_LOG_WARNING, + "Failed to add a subtitle video frame to the buffer source: %s\n", + av_err2str(ret)); } } -- 1.7.10.4