From patchwork Wed Sep 27 18:18:37 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Carl Eugen Hoyos X-Patchwork-Id: 5313 Delivered-To: ffmpegpatchwork@gmail.com Received: by 10.2.36.26 with SMTP id f26csp5334209jaa; Wed, 27 Sep 2017 11:19:07 -0700 (PDT) X-Received: by 10.28.12.134 with SMTP id 128mr1117834wmm.147.1506536347180; Wed, 27 Sep 2017 11:19:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1506536347; cv=none; d=google.com; s=arc-20160816; b=a3G9Itp/eP0BP1umPoREvbDdEHdmskzgkgzfUgbtQcn2yDHjhrfCj7AOkmly93/rej K/aus9jiADlM4XTgAWJ2rp3911LPcFSiTFdaywbuheTN4GfvnBX8+dwFwI0ZOWB/IIRr IHJeilg6fNCvmCLwm/3Cl/DQOzqRNNlsZMgOqOPMU4WfiG8ABkO2iP0wg6UqDXyeZBQP 4vz/qXaCbTNakTCcVX6T9GKcirsEtS5G5AiMh/omZPJ0c6+xdY0OKryqMGJPjnqGlyBU KhoOKoLTHJ3Vzly8KqN/yZH+kDQqWXN1SaBkZnQUTuSH/PlaHNmDk6yJoug0KNWzeAw9 Z5rQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:subject:to :message-id:date:from:mime-version:dkim-signature:delivered-to :arc-authentication-results; bh=Yk1WZaXtxfp5yZ8aqazRi/kR3Y7e/rQrbmVoK9UYuA4=; b=Dw2E7o1Qbck58MeCWtwBZOobnhsloGIINFGMZ2ZhhbHDXD7hnmW1drC5po6e1axlTS RMD6cWP3weg5XflmAMTd2R6NTb9gComTlltHV3W6Sx9X64xAC215MfjXWLXYKiXhjAkR JqIwYx4ER7tdqCb10sMnlb7o9AHUigOOy6R/XTI25ESj6gLlSijh+opxqBiLmdtC7cT9 13oU/zc1GfDAbtGnOxSA68kYhXrTNKgs6QU42lVCbF+s08jyud6gSX5eLr0IV0EVBhG2 8bCvOsIVjyLRjoL1rifisfIdL7NsAkmYUPCP5uD1wEChkQHS9GBqD6qrCNdbduB8KzdM 5DQQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20161025 header.b=rMbx/HyA; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=gmail.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id g193si4079077wmd.239.2017.09.27.11.19.06; Wed, 27 Sep 2017 11:19:07 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20161025 header.b=rMbx/HyA; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=gmail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id A285C689A54; Wed, 27 Sep 2017 21:18:53 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-io0-f180.google.com (mail-io0-f180.google.com [209.85.223.180]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 252976898EB for ; Wed, 27 Sep 2017 21:18:47 +0300 (EEST) Received: by mail-io0-f180.google.com with SMTP id w94so16440495ioi.7 for ; Wed, 27 Sep 2017 11:18:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=lxjTWDNRwmP1Ouf2J+f6KNDxmylTXeWhN9XiscA6oKY=; b=rMbx/HyAprNyLCVOtk/o1+HyfjvCTtHZKDF6Uwt20StyysW6gMy0NZvtba5sx/qvDn LSAyQ0NVuOSu2H0CyJGiogoYaS70XgNdHcWqCj1WWV4YUdHiQ8XL4u0t6lXp9qUfR1aN PnppGfwx+K+jcg0yqXzN4gaQKhPf3BAF+dPmqK33T2mRJKxuI7QM06pTR3cjeiA7yAGt ODcJMMp1gZWSPbeWszkARRPmmsuVxgCuVBuXoHdiYYeEnKPQ24IwQAWRxnG4dT9g9O5n aZK2T/fWwp2HDeCdV+5NeUELXGnl+hWaAEdXsDEc3gYr6f8CcdL2woINuweeBrUZWtAP pMXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=lxjTWDNRwmP1Ouf2J+f6KNDxmylTXeWhN9XiscA6oKY=; b=X7f6Yn+GiV+7AgpRNo8UzIX71Falx29UkVlsXrQ0GHK1KGWhj6CdrLeefmexwJnCGR SHza+hZTJStiWuQKQkAqLPQ2ebhlPqP2WoRAE+VTnFKzPOwqb61MO1ylQH5VskAmtIMw yegDfbrcKK6UEJs41PBn0Yr2OzTGUzjtEktazvzu0B6/mdwoqXOx6Mp3ytySrRTSE8Cr KxQp9QTQMN4p387UKEzmeC/1fI6aA2dpecEFzeIggNtoprf1mCSld/HNSkGgIA4Etmx4 Wz0BHk5tHDg48lkSLss4UJ6tq3jkDKjDWYzq4fGTYjwhCoqp5BFTOFuwRmD0432PmrvZ h9yw== X-Gm-Message-State: AMCzsaUyYT0cPTJ+S2HnzhdVuNbmxlOwFvYXqrShXfhKwGihvtotlKq+ /hZgCkDubowG/lbS0tRkxVm/JnJp7mnwHrvPHgQ= X-Google-Smtp-Source: AOwi7QCAQcEW3XG3xnuq4Mf+oR2TTyA8R/ezBQvvx4r8FQRhcJbArbzSETin0FKazOQmtskb+lPQq9hM43cHS1wEvTc= X-Received: by 10.107.10.141 with SMTP id 13mr3289723iok.302.1506536338222; Wed, 27 Sep 2017 11:18:58 -0700 (PDT) MIME-Version: 1.0 Received: by 10.2.139.4 with HTTP; Wed, 27 Sep 2017 11:18:37 -0700 (PDT) From: Carl Eugen Hoyos Date: Wed, 27 Sep 2017 20:18:37 +0200 Message-ID: To: FFmpeg development discussions and patches Subject: [FFmpeg-devel] [RFC]lavc/fdk-aacenc: Print an error if (e)ld was requested without signaling X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Hi! No opinion here, this was reported twice on trac this week, I don't know if there was really more than one user affected. Please comment, Carl Eugen From 256d46d2479b19103fab3f79f34f6ae597ae402c Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Wed, 27 Sep 2017 20:15:13 +0200 Subject: [PATCH] lavc/fdk-aacenc: Print an error if (e)ld is requested without signaling. Related to ticket #6683. --- libavcodec/libfdk-aacenc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavcodec/libfdk-aacenc.c b/libavcodec/libfdk-aacenc.c index 0e2051b..1477ad41 100644 --- a/libavcodec/libfdk-aacenc.c +++ b/libavcodec/libfdk-aacenc.c @@ -244,6 +244,8 @@ static av_cold int aac_encode_init(AVCodecContext *avctx) * implicit signaling if using ADTS. */ if (s->signaling < 0) s->signaling = avctx->flags & AV_CODEC_FLAG_GLOBAL_HEADER ? 2 : 0; + if (!s->signaling && (avctx->profile == FF_PROFILE_AAC_LD || avctx->profile == FF_PROFILE_AAC_ELD)) + av_log(avctx, AV_LOG_ERROR, "Signaling required for LD and ELD, initialization will fail.\n"); if ((err = aacEncoder_SetParam(s->handle, AACENC_SIGNALING_MODE, s->signaling)) != AACENC_OK) { -- 1.7.10.4