| Message ID | CAB0OVGpHUGpXh-ANZGCYV5432AOUjKEiZ09yiMpbxhbC6YetUQ@mail.gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
On 14-01-2019 06:09 PM, Carl Eugen Hoyos wrote: > Hi! > > This user mistake affects many people, attached patch fixes ticket #4184. > > Please comment, Carl Eugen Partially useful. Users who do this, are usually not aware of how to apply multiple filters, and this syntax is their attempt. The error message doesn't leave them any wiser. So, add a short note (or link) that multiple filters should be specified in a single chain, separated by commas. Thanks, Gyan
2019-01-14 16:59 GMT+01:00, Gyan <ffmpeg@gyani.pro>: > > On 14-01-2019 06:09 PM, Carl Eugen Hoyos wrote: >> This user mistake affects many people, attached patch fixes ticket #4184. > Partially useful. Users who do this, are usually not aware of how to > apply multiple filters, and this syntax is their attempt. The last user reporting such an issue knew about the correct syntax... > The error message doesn't leave them any wiser. So, add a short > note (or link) that multiple filters should be specified in a single > chain, separated by commas. Committed with such a note. Thank you, Carl Eugen
From cb10736ba113a7791816a4db2478eb25f148100f Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos <ceffmpeg@gmail.com> Date: Mon, 14 Jan 2019 13:34:22 +0100 Subject: [PATCH] ffmpeg_opt: Print a warning if more than one -vf/-af option was specified. Fixes ticket #4184. --- fftools/ffmpeg_opt.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/fftools/ffmpeg_opt.c b/fftools/ffmpeg_opt.c index a99e762..b5dfd71 100644 --- a/fftools/ffmpeg_opt.c +++ b/fftools/ffmpeg_opt.c @@ -1681,6 +1681,8 @@ static OutputStream *new_video_stream(OptionsContext *o, AVFormatContext *oc, in MATCH_PER_STREAM_OPT(filter_scripts, str, ost->filters_script, oc, st); MATCH_PER_STREAM_OPT(filters, str, ost->filters, oc, st); + if (o->nb_filters > 1) + av_log(NULL, AV_LOG_ERROR, "Only '-vf %s' read, ignoring remaining -vf options\n", ost->filters); if (!ost->stream_copy) { const char *p = NULL; @@ -1862,6 +1864,8 @@ static OutputStream *new_audio_stream(OptionsContext *o, AVFormatContext *oc, in MATCH_PER_STREAM_OPT(filter_scripts, str, ost->filters_script, oc, st); MATCH_PER_STREAM_OPT(filters, str, ost->filters, oc, st); + if (o->nb_filters > 1) + av_log(NULL, AV_LOG_ERROR, "Only '-af %s' read, ignoring remaining -af options\n", ost->filters); if (!ost->stream_copy) { char *sample_fmt = NULL; -- 1.7.10.4