From patchwork Sun Nov 5 01:25:52 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Carl Eugen Hoyos X-Patchwork-Id: 5863 Delivered-To: ffmpegpatchwork@gmail.com Received: by 10.2.161.90 with SMTP id m26csp1475429jah; Sat, 4 Nov 2017 18:26:22 -0700 (PDT) X-Google-Smtp-Source: ABhQp+R5J99sV86te6syRjRsYqD+mkLY+VwzN6MNq+qieVJgQU3wp5DHioifD/OJIR5q7MXHOJiu X-Received: by 10.28.128.194 with SMTP id b185mr2126441wmd.152.1509845181975; Sat, 04 Nov 2017 18:26:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1509845181; cv=none; d=google.com; s=arc-20160816; b=YcKLIwdFnhvf3OIoEGV5HOTNBSJLBseNnoM+5SGAy7O/o12N4C4bY8T3lQ+qO3/x+s bBRcfbfN5xUGh2qFiox/sDSNMx1eF4rBK17XLNU84lrKTbGhf2BQ4XlSrbQ7gEEcf/xD X/OpDjElXkMcG+lNdQG7mAUbDm7UKh25uXsZCaTW6GQRAw1O7GaCffdzBiwf7xfd3Uci 8ClgImnXX/OF9GWm8ogtO387t9H4UBDXRE8YwfyJ1QaIxlFPfp5SyAWvUlwSEydE6vRn kt0AKqARwN3PNv5sQfbP/CXKDIajkRwk5jDfdYI192uRaPRCtRii64sOObsq8ahvpUrZ a5AA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:subject:to :message-id:date:from:references:in-reply-to:mime-version :dkim-signature:delivered-to:arc-authentication-results; bh=pjXxmgKf2PA1UzkPv3O5i5rt8eGKpuLZ4pJj8fn/69U=; b=f230d7kDCO2hqL+m25QH2+rSVi6DB8Ux6Fxoryt8EUkgEnGUXXOUS9wmxvHxIvITLI npS5/hs3u72t595ZltvGdOYh1I1hg6VTU526jLDA4vG8pKicAu8IZ/D96rfBThm4qGFd uNWH+34+Y2H0LVPPyMA/VBGl11eCQ3kN7iy89Et5aa28eJvtwsTTvFAlAk8FOL5lfXBA g2gDyU3k/PPOVNsKZ4yXTzT+j59ZD2dOVDMDT+TfIXQaJl/gX9WZULz5ccRboVlMaFhH wzntxb1SVBRe4oz4bPK4s0rC5Va3V6q4MZJt3/EYi4zjzSZCOllMV1SnQWDIWsgxeUQK cZ2A== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20161025 header.b=uWLvakAv; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=gmail.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id 10si4587059wmf.71.2017.11.04.18.26.21; Sat, 04 Nov 2017 18:26:21 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20161025 header.b=uWLvakAv; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=gmail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 03F06689A52; Sun, 5 Nov 2017 03:26:09 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-io0-f194.google.com (mail-io0-f194.google.com [209.85.223.194]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 39106680765 for ; Sun, 5 Nov 2017 03:26:03 +0200 (EET) Received: by mail-io0-f194.google.com with SMTP id p186so12261641ioe.12 for ; Sat, 04 Nov 2017 18:26:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=GIyI6lyc3zEYSYsHbrkaoOfxsjB/l/hggZXjcEKl6mI=; b=uWLvakAvbrmdKYKiMmjR0gfcS5ibYawMj6yqMkIvXHAMzOVfelFsOkvNsEDkBA5q86 nqElCASz/n4YoQutD6t0wl6xskT2/AKsBTfEIP8NBRnimo9IaeuOXe9AW8tYyvMf+EsR B6oQpYuewLTQ18AZLII6GPpPZGpfzjELsSUykqMzzvXd4+JgH4iRODQvDufMnZemAXb0 7yYtwl/tJBIzt+gTPq3rHnfR8U5XSAXOchSfDHMhgIE0dK2OI0Sk6sMjiV1AwRRVmdWX lgTeXYzgrBCjZOAd61K+5qNQbNmRIkbVsNORlPhiyEGPcah2WvTYZDthIbFt13nE2Gvx BYtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=GIyI6lyc3zEYSYsHbrkaoOfxsjB/l/hggZXjcEKl6mI=; b=iZ5ttwUU5eyEfzcP9fa0u2zu0O6qVsVaKKbRrQT3GjjQ4kRxMOeTGaXxDsBLoq/CX9 z/HtzAimz+gzPi58vFRZK0yIFtjWGxQTDO1AkCx33dutf2VgMU5VSptd3U76Ol81ri+n MN0qLeT6VZtNaavMsyDDc/2riG5BpEJx44pUiBwGYgRR9ZifbK05Wmon73hg2w2n3e9R mFXCMocwn36B0fLwbsZfkf51LqQWI1vwgB2xMzkYLQIgarSHwrrS3EveF9FV0F2tBK11 ZNqHTmb9qSrlQlpLK0oOg9vNDghIqWCot/Iknm9Eb7uCPfEuQoEcM62CNxKlJmiTT6Xi VYCQ== X-Gm-Message-State: AMCzsaXR6RBK/YRoFgqBc2BLaWsHSi8NDt7pz0sU4s8cZGZfzjen33zk WSProGkbT4mJ/jHELGaBL81uyU+dq6o/PAFy+vg= X-Received: by 10.107.178.81 with SMTP id b78mr10661955iof.235.1509845173261; Sat, 04 Nov 2017 18:26:13 -0700 (PDT) MIME-Version: 1.0 Received: by 10.2.63.101 with HTTP; Sat, 4 Nov 2017 18:25:52 -0700 (PDT) In-Reply-To: References: From: Carl Eugen Hoyos Date: Sun, 5 Nov 2017 02:25:52 +0100 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [RFC/PATCH]lavc/v4l2_context: Change the type of the ioctl cmd to unsigned long X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" 2017-11-05 1:46 GMT+01:00 Carl Eugen Hoyos : > Attached patch fixes a warning on a current 64bit Linux system (that I > do not see on my ancient system where the ioctl cmd has type int). > Is there a better way to deal with it? The way I understand the issue the attached patch works with both int and unsigned long as types. Please comment, Carl Eugen From 7acece14950f212f49d7a24e14803a25c27aba3b Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Sun, 5 Nov 2017 01:53:49 +0100 Subject: [PATCH] lavc/v4l2_context: Change the type of the ioctl cmd to unsigned. Fixes a warning on recent Linux: libavcodec/v4l2_context.c: In function 'ff_v4l2_context_set_status': libavcodec/v4l2_context.c:496:26: warning: comparison is always false due to limited range of data type --- libavcodec/v4l2_context.c | 2 +- libavcodec/v4l2_context.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/v4l2_context.c b/libavcodec/v4l2_context.c index 9f3b56d..78aa0fa 100644 --- a/libavcodec/v4l2_context.c +++ b/libavcodec/v4l2_context.c @@ -484,7 +484,7 @@ static int v4l2_get_coded_format(V4L2Context* ctx, uint32_t *p) * *****************************************************************************/ -int ff_v4l2_context_set_status(V4L2Context* ctx, int cmd) +int ff_v4l2_context_set_status(V4L2Context* ctx, unsigned cmd) { int type = ctx->type; int ret; diff --git a/libavcodec/v4l2_context.h b/libavcodec/v4l2_context.h index 503cc36..4d7734a 100644 --- a/libavcodec/v4l2_context.h +++ b/libavcodec/v4l2_context.h @@ -135,7 +135,7 @@ void ff_v4l2_context_release(V4L2Context* ctx); * those frames will be dropped. * @return 0 in case of success, a negative value representing the error otherwise. */ -int ff_v4l2_context_set_status(V4L2Context* ctx, int cmd); +int ff_v4l2_context_set_status(V4L2Context* ctx, unsigned cmd); /** * Dequeues a buffer from a V4L2Context to an AVPacket. -- 1.7.10.4