diff mbox

[FFmpeg-devel] lavc/libgsmenc: Force mono and use 13k as default bitrate

Message ID CAB0OVGpQvY69Pfv1a8r7FbLZQLw9bCgNEpZ8N64YDXaETczuaA@mail.gmail.com
State Accepted
Headers show

Commit Message

Carl Eugen Hoyos Feb. 16, 2019, 7:20 p.m. UTC
Hi!

Attached patch slightly simplifies gsm encoding.

Please comment, Carl Eugen

Comments

Michael Niedermayer Feb. 16, 2019, 11:16 p.m. UTC | #1
On Sat, Feb 16, 2019 at 08:20:07PM +0100, Carl Eugen Hoyos wrote:
> Hi!
> 
> Attached patch slightly simplifies gsm encoding.
> 
> Please comment, Carl Eugen

>  libgsmenc.c |    8 ++++++++
>  1 file changed, 8 insertions(+)
> d19652f77a2e34959a7ea133809b5d51932ef277  0001-lavc-gsmenc-Force-mono-and-use-13k-as-default-bitrat.patch
> From 49e711e0a27e09cff014c0bd5de6783fa1c3330c Mon Sep 17 00:00:00 2001
> From: Carl Eugen Hoyos <ceffmpeg@gmail.com>
> Date: Sat, 16 Feb 2019 20:18:07 +0100
> Subject: [PATCH] lavc/gsmenc: Force mono and use 13k as default bitrate.

should be ok

thx

[...]
Carl Eugen Hoyos Feb. 17, 2019, 12:05 a.m. UTC | #2
2019-02-17 0:16 GMT+01:00, Michael Niedermayer <michaelni@gmx.at>:
> On Sat, Feb 16, 2019 at 08:20:07PM +0100, Carl Eugen Hoyos wrote:
>> Hi!
>>
>> Attached patch slightly simplifies gsm encoding.
>>
>> Please comment, Carl Eugen
>
>>  libgsmenc.c |    8 ++++++++
>>  1 file changed, 8 insertions(+)
>> d19652f77a2e34959a7ea133809b5d51932ef277
>> 0001-lavc-gsmenc-Force-mono-and-use-13k-as-default-bitrat.patch
>> From 49e711e0a27e09cff014c0bd5de6783fa1c3330c Mon Sep 17 00:00:00 2001
>> From: Carl Eugen Hoyos <ceffmpeg@gmail.com>
>> Date: Sat, 16 Feb 2019 20:18:07 +0100
>> Subject: [PATCH] lavc/gsmenc: Force mono and use 13k as default bitrate.
>
> should be ok

Patch applied.

Thank you, Carl Eugen
diff mbox

Patch

From 49e711e0a27e09cff014c0bd5de6783fa1c3330c Mon Sep 17 00:00:00 2001
From: Carl Eugen Hoyos <ceffmpeg@gmail.com>
Date: Sat, 16 Feb 2019 20:18:07 +0100
Subject: [PATCH] lavc/gsmenc: Force mono and use 13k as default bitrate.

---
 libavcodec/libgsmenc.c |    8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/libavcodec/libgsmenc.c b/libavcodec/libgsmenc.c
index c9e7ba0..fdb11c7 100644
--- a/libavcodec/libgsmenc.c
+++ b/libavcodec/libgsmenc.c
@@ -114,6 +114,10 @@  static int libgsm_encode_frame(AVCodecContext *avctx, AVPacket *avpkt,
     return 0;
 }
 
+static const AVCodecDefault libgsm_defaults[] = {
+    { "b",                "13000" },
+    { NULL },
+};
 
 #if CONFIG_LIBGSM_ENCODER
 AVCodec ff_libgsm_encoder = {
@@ -124,6 +128,8 @@  AVCodec ff_libgsm_encoder = {
     .init           = libgsm_encode_init,
     .encode2        = libgsm_encode_frame,
     .close          = libgsm_encode_close,
+    .defaults       = libgsm_defaults,
+    .channel_layouts= (const uint64_t[]) { AV_CH_LAYOUT_MONO, 0 },
     .sample_fmts    = (const enum AVSampleFormat[]){ AV_SAMPLE_FMT_S16,
                                                      AV_SAMPLE_FMT_NONE },
     .wrapper_name   = "libgsm",
@@ -138,6 +144,8 @@  AVCodec ff_libgsm_ms_encoder = {
     .init           = libgsm_encode_init,
     .encode2        = libgsm_encode_frame,
     .close          = libgsm_encode_close,
+    .defaults       = libgsm_defaults,
+    .channel_layouts= (const uint64_t[]) { AV_CH_LAYOUT_MONO, 0 },
     .sample_fmts    = (const enum AVSampleFormat[]){ AV_SAMPLE_FMT_S16,
                                                      AV_SAMPLE_FMT_NONE },
     .wrapper_name   = "libgsm",
-- 
1.7.10.4