From patchwork Sat Dec 22 23:04:53 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Carl Eugen Hoyos X-Patchwork-Id: 11522 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id E18FA44DE3E for ; Sun, 23 Dec 2018 01:05:00 +0200 (EET) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9945F68AA6F; Sun, 23 Dec 2018 01:04:57 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-io1-f67.google.com (mail-io1-f67.google.com [209.85.166.67]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A286F68A9B3 for ; Sun, 23 Dec 2018 01:04:51 +0200 (EET) Received: by mail-io1-f67.google.com with SMTP id p7so3429303iog.12 for ; Sat, 22 Dec 2018 15:04:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=ZBqwOXD+6cR9KHgCiWAk5FxkMxAvXdIUBM8h8vY40zk=; b=F3WlHui65icPSO8JKHD9RnLEUWEYnGi/ZU8wnZyv+YjTD+K5+Juh1/cKKCCtG1pmbO zZdugOD88kQhXjKYdao+JQ4NUqY0vbVJhe7iSd+9Rnyl+uv00jmx6MwZZa66V+LhMUOG CVR9eQ9NKkVzrwjQdl1yQOq7I+8lKNFOJ7r/TFXYy5cIziothQZxnx57+MNwH4IyvVT6 N+W3pHvXhcCu4BAA9+7rQULFwFYoWt66B0Pf/9Z/yxQ5jhUZQZYyHI0RaBguBSPTdMqS k+GeKH8ilTWVw0cANh982fIoFmMopa2BbHBTV+xLxpuh02SwrdncF4sPXQvoVTEj8Wuk qHSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=ZBqwOXD+6cR9KHgCiWAk5FxkMxAvXdIUBM8h8vY40zk=; b=bwW1QguqEJTNK5LRDo+qT/OHyUMrVF/oOGY14QnF5TTVaGFJ2KjpZ/mA1xeJOTI/yy 2EdAOXUtmz4qjDxGR06s0qr7af6jOHq0mBSqCRSXpK9QPUXSgkLWnNvo96QHfIuWAShB vDulCZoasB1hUQeA6neYj2FZPz04kp91VGHa4OJzZ/pyV44f9XYm+AsGJ7QXMubPi+9m a9dguRBCb+bhFhy2QkuSeKWtsmyO0qMMSHrlXiBaSskaTlQwL1QTP9Qkt2iCUu01+HOo wTQxhn1GWJfvE0qIiRtAzh3SIg9amFXx1CZfjZo3oGsNjTR6MwHxAS/mH7GEGWMDy/Ob 9geQ== X-Gm-Message-State: AJcUukcdDEStXYmd2mjQOTUjGeaq+PxOM/WZsRT9PbeFrY+ETujImO9G yzYkKGZj8NjiV2JFgyh/2HDOCcU/fCB3ieeXKUeKQQ== X-Google-Smtp-Source: ALg8bN7CCuANh4bXql3vdT+Z87XkuWWcVSDJDeTERpuWetm+aRVRktkHfTiTOJDN32EzXxB8Rd1i+wI+gGZv2YUpv6U= X-Received: by 2002:a6b:6504:: with SMTP id z4mr5790978iob.55.1545519893927; Sat, 22 Dec 2018 15:04:53 -0800 (PST) MIME-Version: 1.0 Received: by 2002:a02:5f11:0:0:0:0:0 with HTTP; Sat, 22 Dec 2018 15:04:53 -0800 (PST) In-Reply-To: <20181222083556.GB3501@michaelspb> References: <20181222083556.GB3501@michaelspb> From: Carl Eugen Hoyos Date: Sun, 23 Dec 2018 00:04:53 +0100 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH]configure: Make sure libpostproc can be found if -rpath-link doesn't work X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" 2018-12-22 9:35 GMT+01:00, Michael Niedermayer : > On Sat, Dec 22, 2018 at 12:08:19AM +0100, Carl Eugen Hoyos wrote: >> Hi! >> >> Attached patch fixes running fate with "--enable-shared --enable-gpl" on >> Solaris, the linker searches "libpostproc" in a >> directory"-link=libpostproc". >> Only tested on Solaris. >> >> Please comment, Carl Eugen > >> configure | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> cb5e59b98712ca53aba4561f4d7fe365b3b1e2ff >> 0001-configure-Make-sure-libpostproc-can-be-found-if-rpat.patch >> From d69f1fcee41e803e5208bbfabdeb37a19e73814b Mon Sep 17 00:00:00 2001 >> From: Carl Eugen Hoyos >> Date: Sat, 22 Dec 2018 00:04:43 +0100 >> Subject: [PATCH] configure: Make sure libpostproc can be found if >> -rpath-link >> doesn't work. >> >> Solaris ld takes "-rpath-link=libpostproc" as indication to search in >> "-link=libpostproc". >> --- >> configure | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/configure b/configure >> index 2205751..04d3417 100755 >> --- a/configure >> +++ b/configure >> @@ -6535,7 +6535,7 @@ EOF >> >> # add some linker flags >> check_ldflags -Wl,--warn-common >> -check_ldflags >> -Wl,-rpath-link=libpostproc:libswresample:libswscale:libavfilter:libavdevice:libavformat:libavcodec:libavutil:libavresample >> +check_ldflags >> -Wl,-rpath-link=:libpostproc:libswresample:libswscale:libavfilter:libavdevice:libavformat:libavcodec:libavutil:libavresample >> enabled rpath && add_ldexeflags -Wl,-rpath,$libdir && add_ldsoflags >> -Wl,-rpath,$libdir >> test_ldflags -Wl,-Bsymbolic && append SHFLAGS -Wl,-Bsymbolic > > theres a second similar use of rpath in git (in tools/target_dec_fuzzer.c) New patch attached. Thank you, Carl Eugen From d69f1fcee41e803e5208bbfabdeb37a19e73814b Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Sat, 22 Dec 2018 00:04:43 +0100 Subject: [PATCH] configure: Make sure libpostproc can be found if -rpath-link doesn't work. Solaris ld takes "-rpath-link=libpostproc" as indication to search in "-link=libpostproc". --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 2205751..04d3417 100755 --- a/configure +++ b/configure @@ -6535,7 +6535,7 @@ EOF # add some linker flags check_ldflags -Wl,--warn-common -check_ldflags -Wl,-rpath-link=libpostproc:libswresample:libswscale:libavfilter:libavdevice:libavformat:libavcodec:libavutil:libavresample +check_ldflags -Wl,-rpath-link=:libpostproc:libswresample:libswscale:libavfilter:libavdevice:libavformat:libavcodec:libavutil:libavresample enabled rpath && add_ldexeflags -Wl,-rpath,$libdir && add_ldsoflags -Wl,-rpath,$libdir test_ldflags -Wl,-Bsymbolic && append SHFLAGS -Wl,-Bsymbolic diff --git a/tools/target_dec_fuzzer.c b/tools/target_dec_fuzzer.c index a94d5e6..2a6d525 100644 --- a/tools/target_dec_fuzzer.c +++ b/tools/target_dec_fuzzer.c @@ -30,7 +30,7 @@ * build the fuzz target. Choose the value of FFMPEG_CODEC (e.g. AV_CODEC_ID_DVD_SUBTITLE) and choose one of FUZZ_FFMPEG_VIDEO, FUZZ_FFMPEG_AUDIO, FUZZ_FFMPEG_SUBTITLE. - clang -fsanitize=address -fsanitize-coverage=trace-pc-guard,trace-cmp tools/target_dec_fuzzer.c -o target_dec_fuzzer -I. -DFFMPEG_CODEC=AV_CODEC_ID_MPEG1VIDEO -DFUZZ_FFMPEG_VIDEO ../../libfuzzer/libFuzzer.a -Llibavcodec -Llibavdevice -Llibavfilter -Llibavformat -Llibavresample -Llibavutil -Llibpostproc -Llibswscale -Llibswresample -Wl,--as-needed -Wl,-z,noexecstack -Wl,--warn-common -Wl,-rpath-link=libpostproc:libswresample:libswscale:libavfilter:libavdevice:libavformat:libavcodec:libavutil:libavresample -lavdevice -lavfilter -lavformat -lavcodec -lswresample -lswscale -lavutil -ldl -lxcb -lxcb-shm -lxcb -lxcb-xfixes -lxcb -lxcb-shape -lxcb -lX11 -lasound -lm -lbz2 -lz -pthread + clang -fsanitize=address -fsanitize-coverage=trace-pc-guard,trace-cmp tools/target_dec_fuzzer.c -o target_dec_fuzzer -I. -DFFMPEG_CODEC=AV_CODEC_ID_MPEG1VIDEO -DFUZZ_FFMPEG_VIDEO ../../libfuzzer/libFuzzer.a -Llibavcodec -Llibavdevice -Llibavfilter -Llibavformat -Llibavresample -Llibavutil -Llibpostproc -Llibswscale -Llibswresample -Wl,--as-needed -Wl,-z,noexecstack -Wl,--warn-common -Wl,-rpath-link=:libpostproc:libswresample:libswscale:libavfilter:libavdevice:libavformat:libavcodec:libavutil:libavresample -lavdevice -lavfilter -lavformat -lavcodec -lswresample -lswscale -lavutil -ldl -lxcb -lxcb-shm -lxcb -lxcb-xfixes -lxcb -lxcb-shape -lxcb -lX11 -lasound -lm -lbz2 -lz -pthread * create a corpus directory and put some samples there (empty dir is ok too): mkdir CORPUS && cp some-files CORPUS -- 1.7.10.4