From patchwork Sun Nov 5 00:46:38 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Carl Eugen Hoyos X-Patchwork-Id: 5862 Delivered-To: ffmpegpatchwork@gmail.com Received: by 10.2.161.90 with SMTP id m26csp1453187jah; Sat, 4 Nov 2017 17:47:08 -0700 (PDT) X-Google-Smtp-Source: ABhQp+SIBVfhO6kICY/5cG0/WmoRtUcaHUm/6VjtwrZ0fVCmi2WsWStv/iFf7FS4ZXewlCYU4RYC X-Received: by 10.28.231.25 with SMTP id e25mr2456107wmh.157.1509842828739; Sat, 04 Nov 2017 17:47:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1509842828; cv=none; d=google.com; s=arc-20160816; b=jlU2B+Ec6cTLtWl7wAsdJUuM9xuW3h1YBvvDssD35WGKjnLZF4U9b5tuV/0pQGl6eu pn7o7iQvm9eLT3y9uajys2d/bMmm7ASmcNE7JZ4k4GBo3BbYI6e8A2RerkhkxFoRpgy4 NgvKsQiuITm25B3gpi2uDkzoXmWi5Fh2WWZQ3BquM02vMWyhneetawElVMGD1ZLhaxpM LHrAWO8EM1ZUVV5vz2NSSxHu2w2UCsoea9w6mJ8PmfkUQS5sB2m/wxSc8c3gnSqaYGZp kuzNDmAbTyBUI05pZcPucPwdSJDUmFdvb8cxu9CARpuvRU0liaRzPKqqOZbkeN3UiloP 3koQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:subject:to :message-id:date:from:mime-version:dkim-signature:delivered-to :arc-authentication-results; bh=gtkb/F8PxAylQK3oKKZh+Z+cNE7+pabnI8pYsxOX6c8=; b=tNRw17kVRsKh5Pt4J21a61K8s5wcFnzwDrcYPfju9DYqgBgOt8Zq+CVeiveLohLMzL o81jNnbI4eaL8qjdWkZqBUk1kWacNWepOYCf9dDceWOXZlwqYoYr8Z+xrHEWkYUrt2c9 /GKp338bEcehGveD7GpfFv9Os4/Rq1JTapoF/gr1EDijhvqRuMnj/E15qIBUSkGmwMv2 X3ExtIvX/a27roQT/WKTAAHOaD24Px+Ih8ZYqUnp0R7aKR/8bwCBz2HA47Kysq0Zf5c+ WvYZ+ORK5SKnSMG6j7aOp8bf338lsFJNA81edPK8D6Db6KaUMlf/z983rSwypCWEeKXz f4QA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20161025 header.b=adGUT7FK; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=gmail.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id f3si4361858wmf.73.2017.11.04.17.47.07; Sat, 04 Nov 2017 17:47:08 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20161025 header.b=adGUT7FK; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=gmail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 0C03168974E; Sun, 5 Nov 2017 02:46:55 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-it0-f43.google.com (mail-it0-f43.google.com [209.85.214.43]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 21188689219 for ; Sun, 5 Nov 2017 02:46:49 +0200 (EET) Received: by mail-it0-f43.google.com with SMTP id f187so1508713itb.1 for ; Sat, 04 Nov 2017 17:47:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=boCN7YrQY2Rqh8wOE/weMK7JAizqMjMvpFIRgY1UU18=; b=adGUT7FKZzagrFl2sB0YCaIUGy+hxNCMMKMsly9gpkLIx2o80myUKPN5lFHPTvpuyQ 60eLXb3TU7F8UaekxU06fhPfTllS84/FuQQVCUF/8RBReUl+I7YCKr6LjneAfPlbwE6G o5+CiEcK9j4V0AK42gwdv1DaMvo8h2HujTT2+i/3uMN6cyTJ3ittA2amnAZdohCBvtvk DvITUvfynseNXx0D6C3qUCz0Ts1sN9qxU4jartN41fYI8VcLt74OLJ+pAF5dMGjgEHcY WM6Wq+nLZf7oBf3M+Qu76TynNLuIubuQZfQBIyKu7qGvqjTaJw6QmB6xC8a3KGgdal59 Zyzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=boCN7YrQY2Rqh8wOE/weMK7JAizqMjMvpFIRgY1UU18=; b=sVpXQrFPjKzhFqfv67uLgj3sbOF6p7hHJTkl58Jz41GVSVpJgir5P5KUxrtf/y3pDe QzI+kkdGjxLBURJ5HOAuDbyWAEBFXRHnJmM2csBDz8lSopDCNIdjuhkcnxpJ7WBUFVtS JgDsnKsIkkqtg9MSrnrlpaGbWH1F3gQGunOhwh/wBb7oVok2EmNOu4hy5o/6NL+CIIRt Hph3SsaNdDaoV8m6NV/ydJe9bQS4iHYNWhQ/UkPglVV131JOkTROof6KEH8Zo0oCBoSS FpwmDxUN3Qm3zzSla8HGFmCPVSN/LModVGxM5EdyHqU2Af51vzjSiv8/iR4fq183Rwfq gpHQ== X-Gm-Message-State: AJaThX65iGp8rumEJDwBS5Jcvo2+rSf/lTWrGDLBh/iTX6ASnYTka6Q7 rvdBDnXtqXEtuGifMeUP4fVg+Br3OLGuWZmtyLA= X-Received: by 10.36.118.210 with SMTP id z201mr4536161itb.78.1509842818662; Sat, 04 Nov 2017 17:46:58 -0700 (PDT) MIME-Version: 1.0 Received: by 10.2.63.101 with HTTP; Sat, 4 Nov 2017 17:46:38 -0700 (PDT) From: Carl Eugen Hoyos Date: Sun, 5 Nov 2017 01:46:38 +0100 Message-ID: To: FFmpeg development discussions and patches Subject: [FFmpeg-devel] [RFC/PATCH]lavc/v4l2_context: Change the type of the ioctl cmd to unsigned long X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Hi! Attached patch fixes a warning on a current 64bit Linux system (that I do not see on my ancient system where the ioctl cmd has type int). Is there a better way to deal with it? Please comment, Carl Eugen From 06886eea147cd68ee14291de1e437c364682f8ef Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Sun, 5 Nov 2017 01:42:37 +0100 Subject: [PATCH] lavc/v4l2_context: Change the type of the ioctl cmd to unsigned long. Fixes a warning on recent Linux: libavcodec/v4l2_context.c: In function 'ff_v4l2_context_set_status': libavcodec/v4l2_context.c:496:26: warning: comparison is always false due to limited range of data type --- libavcodec/v4l2_context.c | 2 +- libavcodec/v4l2_context.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/v4l2_context.c b/libavcodec/v4l2_context.c index 9f3b56d..e3f0175 100644 --- a/libavcodec/v4l2_context.c +++ b/libavcodec/v4l2_context.c @@ -484,7 +484,7 @@ static int v4l2_get_coded_format(V4L2Context* ctx, uint32_t *p) * *****************************************************************************/ -int ff_v4l2_context_set_status(V4L2Context* ctx, int cmd) +int ff_v4l2_context_set_status(V4L2Context* ctx, unsigned long cmd) { int type = ctx->type; int ret; diff --git a/libavcodec/v4l2_context.h b/libavcodec/v4l2_context.h index 503cc36..1a6ad7a 100644 --- a/libavcodec/v4l2_context.h +++ b/libavcodec/v4l2_context.h @@ -135,7 +135,7 @@ void ff_v4l2_context_release(V4L2Context* ctx); * those frames will be dropped. * @return 0 in case of success, a negative value representing the error otherwise. */ -int ff_v4l2_context_set_status(V4L2Context* ctx, int cmd); +int ff_v4l2_context_set_status(V4L2Context* ctx, unsigned long cmd); /** * Dequeues a buffer from a V4L2Context to an AVPacket. -- 1.7.10.4