diff mbox

[FFmpeg-devel] tests/fate: Fix fitsdec-gbrap16 on big-endian hardware

Message ID CAB0OVGpiaC4iF0OCXxShc+QueOJ0s_mmQX1HWyDQUdPvoN_bDA@mail.gmail.com
State Accepted
Headers show

Commit Message

Carl Eugen Hoyos Nov. 1, 2017, 8:41 p.m. UTC
Hi!

Attached patch fixes fate-fitsdec on big-endian.

Please comment, Carl Eugen

Comments

Michael Niedermayer Nov. 2, 2017, 10:44 p.m. UTC | #1
On Wed, Nov 01, 2017 at 09:41:58PM +0100, Carl Eugen Hoyos wrote:
> Hi!
> 
> Attached patch fixes fate-fitsdec on big-endian.
> 
> Please comment, Carl Eugen

>  b/tests/fate/fits.mak              |    4 ++--
>  b/tests/ref/fate/fitsdec-gbrap16le |    6 ++++++
>  tests/ref/fate/fitsdec-gbrap16     |    6 ------
>  3 files changed, 8 insertions(+), 8 deletions(-)
> c39c8f21e9d3b2c15b6ac9ed9e7b2d0b864b4863  0001-tests-fate-Fix-fitsdec-gbrap16-test-on-big-endian-ha.patch
> From 61032df04a35d7cc939fa41e71ee3f882c3658c3 Mon Sep 17 00:00:00 2001
> From: Carl Eugen Hoyos <ceffmpeg@gmail.com>
> Date: Wed, 1 Nov 2017 21:39:33 +0100
> Subject: [PATCH] tests/fate: Fix fitsdec-gbrap16 test on big-endian hardware.

LGTM

thx

[...]
Carl Eugen Hoyos Nov. 4, 2017, 12:05 a.m. UTC | #2
2017-11-02 23:44 GMT+01:00 Michael Niedermayer <michael@niedermayer.cc>:
> On Wed, Nov 01, 2017 at 09:41:58PM +0100, Carl Eugen Hoyos wrote:
>> Hi!
>>
>> Attached patch fixes fate-fitsdec on big-endian.
>>
>> Please comment, Carl Eugen
>
>>  b/tests/fate/fits.mak              |    4 ++--
>>  b/tests/ref/fate/fitsdec-gbrap16le |    6 ++++++
>>  tests/ref/fate/fitsdec-gbrap16     |    6 ------
>>  3 files changed, 8 insertions(+), 8 deletions(-)
>> c39c8f21e9d3b2c15b6ac9ed9e7b2d0b864b4863  0001-tests-fate-Fix-fitsdec-gbrap16-test-on-big-endian-ha.patch
>> From 61032df04a35d7cc939fa41e71ee3f882c3658c3 Mon Sep 17 00:00:00 2001
>> From: Carl Eugen Hoyos <ceffmpeg@gmail.com>
>> Date: Wed, 1 Nov 2017 21:39:33 +0100
>> Subject: [PATCH] tests/fate: Fix fitsdec-gbrap16 test on big-endian hardware.
>
> LGTM

Patch applied.

Thank you, Carl Eugen
diff mbox

Patch

From 61032df04a35d7cc939fa41e71ee3f882c3658c3 Mon Sep 17 00:00:00 2001
From: Carl Eugen Hoyos <ceffmpeg@gmail.com>
Date: Wed, 1 Nov 2017 21:39:33 +0100
Subject: [PATCH] tests/fate: Fix fitsdec-gbrap16 test on big-endian hardware.

---
 tests/fate/fits.mak              |    4 ++--
 tests/ref/fate/fitsdec-gbrap16   |    6 ------
 tests/ref/fate/fitsdec-gbrap16le |    6 ++++++
 3 files changed, 8 insertions(+), 8 deletions(-)
 delete mode 100644 tests/ref/fate/fitsdec-gbrap16
 create mode 100644 tests/ref/fate/fitsdec-gbrap16le

diff --git a/tests/fate/fits.mak b/tests/fate/fits.mak
index 0335a7b..113498c 100644
--- a/tests/fate/fits.mak
+++ b/tests/fate/fits.mak
@@ -8,7 +8,7 @@  tests/data/fits-multi.fits: ffmpeg$(PROGSSUF)$(EXESUF) | tests/data
 map.tests/data/lena-gray.fits    := gray8
 map.tests/data/lena-gbrp.fits    := rgb24
 map.tests/data/lena-gbrp16.fits  := rgb48
-map.tests/data/lena-gbrap16.fits := rgba64
+map.tests/data/lena-gbrap16le.fits := rgba64
 
 tests/data/lena%.fits: TAG = GEN
 tests/data/lena%.fits: NAME = $(map.$(@))
@@ -37,7 +37,7 @@  fate-fitsdec%: PIXFMT = $(word 3, $(subst -, ,$(@)))
 fate-fitsdec%: SRC = $(TARGET_PATH)/tests/data/lena-$(PIXFMT).fits
 fate-fitsdec%: CMD = framecrc -i $(SRC) -pix_fmt $(PIXFMT)
 
-FATE_FITS_DEC_PIXFMT = gray gbrp gbrp16 gbrap16
+FATE_FITS_DEC_PIXFMT = gray gbrp gbrp16 gbrap16le
 $(FATE_FITS_DEC_PIXFMT:%=fate-fitsdec-%): fate-fitsdec-%: tests/data/lena-%.fits
 FATE_FITS_DEC-$(call ALLYES, FITS_DEMUXER IMAGE2_DEMUXER FITS_DECODER PNG_DECODER FITS_ENCODER FITS_MUXER) += $(FATE_FITS_DEC_PIXFMT:%=fate-fitsdec-%)
 
diff --git a/tests/ref/fate/fitsdec-gbrap16 b/tests/ref/fate/fitsdec-gbrap16
deleted file mode 100644
index 78abb5c..0000000
--- a/tests/ref/fate/fitsdec-gbrap16
+++ /dev/null
@@ -1,6 +0,0 @@ 
-#tb 0: 1/1
-#media_type 0: video
-#codec_id 0: rawvideo
-#dimensions 0: 128x128
-#sar 0: 0/1
-0,          0,          0,        1,   131072, 0x487894b2
diff --git a/tests/ref/fate/fitsdec-gbrap16le b/tests/ref/fate/fitsdec-gbrap16le
new file mode 100644
index 0000000..78abb5c
--- /dev/null
+++ b/tests/ref/fate/fitsdec-gbrap16le
@@ -0,0 +1,6 @@ 
+#tb 0: 1/1
+#media_type 0: video
+#codec_id 0: rawvideo
+#dimensions 0: 128x128
+#sar 0: 0/1
+0,          0,          0,        1,   131072, 0x487894b2
-- 
1.7.10.4