From patchwork Tue Apr 23 23:38:47 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Carl Eugen Hoyos X-Patchwork-Id: 12882 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id A44CC44913F for ; Wed, 24 Apr 2019 02:38:57 +0300 (EEST) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 87994689998; Wed, 24 Apr 2019 02:38:57 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-it1-f173.google.com (mail-it1-f173.google.com [209.85.166.173]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 83C06680258 for ; Wed, 24 Apr 2019 02:38:50 +0300 (EEST) Received: by mail-it1-f173.google.com with SMTP id y10so3199753itc.1 for ; Tue, 23 Apr 2019 16:38:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :content-transfer-encoding; bh=U1MoO7zao+z6QKM5Cu5/rCbWbRuEkncoJcJM58tnCKg=; b=sHeddRTNhuESfsnqf5yNP++MhIyIkuLOXCPSrdfKL10O1UaiQrRK9a4O9Atjblpo3+ Lk4jzEMNasCx47pvJdrRE1MElhxbTv3QOxsJNge1w3/vsMY/V5usgwT4PCDaA5Vh1hzt NJB1K5zj4SaZSdCNYIgHD0p7e7CHotBhiGQxiglhgFMdPkbhMi3fEPbvcZFJRAbCJMLx RV6/JBEcnSATATGNwirlpQoa7zjs5zD+akzDq9FazPfhc7KqlhCssautKwy4LyQWDwFT pOkiVJCHRuQa/fVgocbnoA9qXxjbTCtXVr0uWIEbJGm2Q0Wp8Tfj7T/lcpBHB4sZz3FZ /9ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:content-transfer-encoding; bh=U1MoO7zao+z6QKM5Cu5/rCbWbRuEkncoJcJM58tnCKg=; b=R728aTWMXehmdlRgpf3vd6znTbODOrhl7hb1hhiJfNTAqeMmuuJjTwIzUq5RQ9XgmZ vSUHCSidNTriB/l6YXICdac0bRgB3w3eYrSe6uwpUz2+eilYdvMGwsFlOlg6UHu0ZNEr 8YZ2BkAskNtZZ2COzubsY0whIQ7m7xx9oiUQUvhO7wWsAFapjsLjbwOhSi8IJHTrsj86 yvNJBedYCh9Jb0wvY8cxjb60gR8MekGuzEwf+flHo/OKcVgBU3lSG4efKqW7wcLjxDhJ LSbg4cJCgAKyeIhbtL08dYpw98QygxgZzM7lfJt3DpFO7JUyS+XKE0+wsYP7edg0cyG9 pcYQ== X-Gm-Message-State: APjAAAXx6fnvinnAom0ZYgOjpv7IE/z9o2LF8zllehC1u6QCmCSpFG89 4EExzI3Pa8oPoQlZQsgwyhrfpTy4yTh6wSFG1isc6A== X-Google-Smtp-Source: APXvYqxggCzFhnbvwnfzP+7o2rnimYy2838vY6exR+ZbWXro/Sho6jhIoGrXfiM6W1Terv6Fu9BjP9dsOv4UyqXI+7o= X-Received: by 2002:a05:660c:10:: with SMTP id q16mr4400019itj.149.1556062728733; Tue, 23 Apr 2019 16:38:48 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a05:6638:97:0:0:0:0 with HTTP; Tue, 23 Apr 2019 16:38:47 -0700 (PDT) In-Reply-To: <00a501d3809e$d7aa0bb0$86fe2310$@free.fr> References: <007b01d3804e$c5964380$50c2ca80$@free.fr> <20171229125419.5cb9940a@debian> <00a501d3809e$d7aa0bb0$86fe2310$@free.fr> From: Carl Eugen Hoyos Date: Wed, 24 Apr 2019 01:38:47 +0200 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [MSVC toolchain] Patch to allow building FFmpeg with Linux bash on Windows (WSL) X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" 2017-12-29 13:16 GMT+01:00, Cyber Sinh : > Sorry for the diff instead of regular git patch. Here is the patch. Only saw this today after wondering why nobody tried using wsl before... How can I test this part of the patch? In which situation is it supposed to make a difference? Carl Eugen > > > -----Message d'origine----- > De : ffmpeg-devel [mailto:ffmpeg-devel-bounces@ffmpeg.org] De la part de > wm4 > Envoyé : vendredi 29 décembre 2017 12:54 > À : ffmpeg-devel@ffmpeg.org > Objet : Re: [FFmpeg-devel] [MSVC toolchain] Patch to allow building FFmpeg > with Linux bash on Windows (WSL) > > On Fri, 29 Dec 2017 10:44:21 +0100 > Hendrik Leppkes wrote: > >> On Fri, Dec 29, 2017 at 3:43 AM, Cyber Sinh wrote: >> > The attached patch changes the configure script for FFmpeg (and >> > associated shell scripts) to call MSVC tools including their >> > extensions (cl.exe instead of cl for example). This is necessary, >> > because WSL can automatically launch Windows processes from the >> > Linux side but only if the process is in the path and includes the >> > full name. Linux doesn't automatically append .exe and such to invoke a >> > file. >> > >> > >> >> The attached file is corrupted. Please ensure its in git format-patch >> format. As it is, I can't even read it at all. > > It's in UTF-16, and just a diff. Yeah, nobody can comfortably read it. > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel > diff --git a/compat/windows/mslink b/compat/windows/mslink index 07b2b3e378..9b6b83c4ed 100755 --- a/compat/windows/mslink +++ b/compat/windows/mslink @@ -1,9 +1,9 @@ #!/bin/sh -LINK_EXE_PATH=$(dirname "$(command -v cl)")/link +LINK_EXE_PATH=$(dirname "$(command -v cl.exe)")/link.exe if [ -x "$LINK_EXE_PATH" ]; then "$LINK_EXE_PATH" $@ else I will apply the makedef part that I just tested successfully.