From patchwork Mon Dec 17 01:47:29 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Carl Eugen Hoyos X-Patchwork-Id: 11445 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id 2DA9344E358 for ; Mon, 17 Dec 2018 03:47:37 +0200 (EET) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 5189A68AA86; Mon, 17 Dec 2018 03:47:37 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-it1-f193.google.com (mail-it1-f193.google.com [209.85.166.193]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id B632168A9C0 for ; Mon, 17 Dec 2018 03:47:30 +0200 (EET) Received: by mail-it1-f193.google.com with SMTP id g85so16684420ita.3 for ; Sun, 16 Dec 2018 17:47:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=KvIqPDfOwXBJXyEuQKbNS51hR3dQHGKwU034nNCaEHw=; b=Lm1En28XNpepSpsTRenoVVBIJC5TK5yZKnW44xXBdvHCwWFPstOjSjNweJLRKkiCyH euMhBIs8OKwKy8skWCAQB2eNLr0CwaIKCiBhOwMhGKpBrs/IpAonuuIxO9KrBVb0gzXN EixNz/GqonWOW3uaIx+DC3gM2lVMBkf4kIAVdiEkRDF8mB6Ws5huLVfwIpSDOeSfdmbw TinrBikkY6syWSFKX2uLKf3VL9f1BkJVXZGZlpFz3dCGgtPy7Hu1Zp9IPkqvrHcUocWW 2LE9LVShtonYS/SX7F4Aep+4Q2zpD0uVNhOAZjtFHF6Ubd+ZS2oJhrmvg1t32diLD9fL KOeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=KvIqPDfOwXBJXyEuQKbNS51hR3dQHGKwU034nNCaEHw=; b=qi8J7/6viBziZdlZAcP9Yv6EINwVt7s/oafPEcJY2lFhuX6V9jGGxIkJFwGcZ/24JA Rzt+QobsQWiNuT6EuagMX3Gbm4SwlMQePbrnatvIiR99Tjd4WjqXdaGF1ejRIAicmPnu l2J5rACLLx9ewcggFIjIT+bKbp9ef+s/xL7VNRo1ZG5jtWCdKwwAUgdiSaqMNxRR2VE6 ZdAayNSYHMckjZid7iJv4jBblvP7CuN6oO2PvBm/GNrh00rSaXXWkyaGVJZsVvK2MHJn aqHE5vmXoERb3/P0zOiXnbRz9aqrHMwi1MqNZ2CnBKxpuITutstjnncFaIh0PiyAd3/z Yv7Q== X-Gm-Message-State: AA+aEWb1I8DmMFN8jGwEmQKi6+gJqThiPRRXtZFdAZqD5/mLR0UH+zUO 7wqMHEniSzZ+znD/KIKg2fZJvH46rohl1ERQ20X87w== X-Google-Smtp-Source: AFSGD/WZyQ3D/LODUcHSxyBVYGNGgEggX8cD1hNf/l8Ct7E72X+BWkPETGRj+VAhxCNA/KIMUom7O7axYrDwLgpFkx8= X-Received: by 2002:a24:b64a:: with SMTP id d10mr10741889itj.149.1545011250399; Sun, 16 Dec 2018 17:47:30 -0800 (PST) MIME-Version: 1.0 Received: by 2002:a02:5f11:0:0:0:0:0 with HTTP; Sun, 16 Dec 2018 17:47:29 -0800 (PST) From: Carl Eugen Hoyos Date: Mon, 17 Dec 2018 02:47:29 +0100 Message-ID: To: FFmpeg development discussions and patches Subject: [FFmpeg-devel] [PATCH]lavc/opus_rc: Case a const pointer to uint8_t * X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Hi! The Opus struct RawBitsContext is used in both the decoder and the encoder. The fact that *position is const avoids warnings in the decoder where it points into the bitstream. The encoder writes into the same pointer, attached cast silences the warning on targets where AV_WB32() does not internally cast the qualifier away. It is also possible to use a union if anybody prefers this: and use rbe in ff_opus_rc_put_raw(). Please comment, Carl Eugen From 2fe5044a4532f061ef4090fd46f1ec1a3af067b0 Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Mon, 17 Dec 2018 02:36:26 +0100 Subject: [PATCH] lavc/opus_rc: Cast a const pointer to uint8_t *. Silences a warning with clang on arm: libavcodec/opus_rc.c:170:17: warning: passing 'const uint8_t *' (aka 'const unsigned char *') to parameter of type 'void *' discards qualifiers --- libavcodec/opus_rc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/opus_rc.c b/libavcodec/opus_rc.c index 3972bb0..c432eb9 100644 --- a/libavcodec/opus_rc.c +++ b/libavcodec/opus_rc.c @@ -167,7 +167,7 @@ void ff_opus_rc_put_raw(OpusRangeCoder *rc, uint32_t val, uint32_t count) rc->rb.cachelen = (rc->rb.cachelen + to_write) % 32; if (!rc->rb.cachelen && count) { - AV_WB32(rc->rb.position, rc->rb.cacheval); + AV_WB32((uint8_t *)rc->rb.position, rc->rb.cacheval); rc->rb.bytes += 4; rc->rb.position -= 4; rc->rb.cachelen = count - to_write; -- 1.7.10.4