From patchwork Sat Oct 13 11:12:05 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Carl Eugen Hoyos X-Patchwork-Id: 10665 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id A5B0D446DC4 for ; Sat, 13 Oct 2018 14:12:08 +0300 (EEST) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 05F4268A2FA; Sat, 13 Oct 2018 14:11:50 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-io1-f43.google.com (mail-io1-f43.google.com [209.85.166.43]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 5D4BA6899F7 for ; Sat, 13 Oct 2018 14:11:44 +0300 (EEST) Received: by mail-io1-f43.google.com with SMTP id w2-v6so11064758ioc.1 for ; Sat, 13 Oct 2018 04:12:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=3pbw1cndi+zbQNsdci3VpGkU+a3+JQjEnw7JBwqM2cQ=; b=DGlYx18752J+uHsoGSkFS4TZo5gH6bVkP5LTzwT68ewMg7MEzqQ0YiBEs/a9RwxCrD BjTw8vvBMeLcm5o6tRMEteuDGXqmrVr/L7XA93RchcgfKzjutDjU0JkxpjkBNi20dgGW 3+4Pg+jWJebt/UvLh/2bYrDqk+LkMQQpiR1sDh7ntVFz3Ds30mCNaZG9RYKAa1SRV2Fg gbTHPDL6hDyYNsUrJu9HZW3C9KBkFlywZaHx0Wte3+vIC1RzfRiGJ2EoZOQ5BvlH+JQI 70ng7jrHpOMPyg6b1iNyjPWu7mFin4ha/iXYSukCi4GSW99zBD8emHzoigCI9iAIW8Fz TtaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=3pbw1cndi+zbQNsdci3VpGkU+a3+JQjEnw7JBwqM2cQ=; b=d+SvU+eKBFEUiv0dbndVLhMu5Fev8TSEhlTjz5MJv8OVckXr6TnV9jYeZb4PD5QnaX 0fNQa+NeYU4oD7eXA2L5EsGpV5T3ptQwnFqtL+9LXSpaXqQ95BYA3NxCJsoBaNOyMvSG J9ar5ZAAdSxkdjcW4sZWMKmo8KD3ezuErzXDyK9/gtprTaCVfDwbOtbL9K+sQAL4tmr5 cFLixj9D+FJl5CKmTzupkZs0qHJwngg+G+LbBlM0UBsWju/Fn3hUTcZg8voPibIGI3VW 3gZzccSGdNh3yV3OWlv6m9+vFtp7gFLZGtUp5dBpTdvHNz8hbjy/kfxRwVYR/uVKCmQ3 j/MA== X-Gm-Message-State: ABuFfogUiiDvJ4ppdZHdoIfUMmbOV1Gb+i2E6jEz71swmW6L5NgTvNX1 YY7EKkyQM4qXv3vCwnJSLReqWNcAw/SE3LMZBT5A4g== X-Google-Smtp-Source: ACcGV63k0Bjc0v/KoLlLjCUuw3j/F2H/ozlBQ+vz3SB1UX8cIwE40NPuHAZvxdHhJ7Cig490ZlfUgmALBHOjmguk8tE= X-Received: by 2002:a6b:310d:: with SMTP id j13-v6mr6927550ioa.250.1539429126239; Sat, 13 Oct 2018 04:12:06 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a02:c489:0:0:0:0:0 with HTTP; Sat, 13 Oct 2018 04:12:05 -0700 (PDT) From: Carl Eugen Hoyos Date: Sat, 13 Oct 2018 13:12:05 +0200 Message-ID: To: FFmpeg development discussions and patches Subject: [FFmpeg-devel] [PATCH]lavf/mxfenc: Remove a write-only variable X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Hi! Attached patch fixes a warning, I wonder if the value is actually supposed to use somewhere... Please comment, Carl Eugen From ee679d874aeacc027edcd370464bd7ea7fd7ae7d Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Sat, 13 Oct 2018 13:10:29 +0200 Subject: [PATCH] lavf/mxfenc: Remove a write-only variable. Fixes the following warning: libavformat/mxfenc.c:2125:22: warning: variable 'frame_size' set but not used --- libavformat/mxfenc.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/libavformat/mxfenc.c b/libavformat/mxfenc.c index f6acf80..a2f68dd 100644 --- a/libavformat/mxfenc.c +++ b/libavformat/mxfenc.c @@ -2122,7 +2122,7 @@ static int mxf_parse_dv_frame(AVFormatContext *s, AVStream *st, AVPacket *pkt) MXFContext *mxf = s->priv_data; MXFStreamContext *sc = st->priv_data; uint8_t *vs_pack, *vsc_pack; - int ul_index, frame_size, stype, pal; + int ul_index, stype, pal; const AVDVProfile *profile; if (mxf->header_written) @@ -2153,7 +2153,6 @@ static int mxf_parse_dv_frame(AVFormatContext *s, AVStream *st, AVPacket *pkt) switch (stype) { case 0x18: // DV100 720p ul_index = INDEX_DV100_720_50 + pal; - frame_size = pal ? 288000 : 240000; if (sc->interlaced) { av_log(s, AV_LOG_ERROR, "source marked as interlaced but codec profile is progressive\n"); sc->interlaced = 0; @@ -2161,20 +2160,16 @@ static int mxf_parse_dv_frame(AVFormatContext *s, AVStream *st, AVPacket *pkt) break; case 0x14: // DV100 1080i ul_index = INDEX_DV100_1080_50 + pal; - frame_size = pal ? 576000 : 480000; break; case 0x04: // DV50 ul_index = INDEX_DV50_525_60 + pal; - frame_size = pal ? 288000 : 240000; break; default: // DV25 if (profile && profile->pix_fmt == AV_PIX_FMT_YUV420P && pal) { ul_index = INDEX_DV25_525_60_IEC + pal; - frame_size = pal ? 144000 : 120000; break; } ul_index = INDEX_DV25_525_60 + pal; - frame_size = pal ? 144000 : 120000; } sc->index = ul_index; -- 1.7.10.4