From patchwork Sat Aug 10 15:12:50 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Carl Eugen Hoyos X-Patchwork-Id: 14375 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id 73F034483A3 for ; Sat, 10 Aug 2019 18:13:09 +0300 (EEST) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3A03E68AB80; Sat, 10 Aug 2019 18:13:09 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-ot1-f43.google.com (mail-ot1-f43.google.com [209.85.210.43]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7429F689D1F for ; Sat, 10 Aug 2019 18:13:02 +0300 (EEST) Received: by mail-ot1-f43.google.com with SMTP id m97so10601483otm.12 for ; Sat, 10 Aug 2019 08:13:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=bV7AweDD4GFem1zmKsGwNxEnCgD7YXpY599Uau1lCIs=; b=ivEIvCe5aYLMPZAJZSX2+vO/ft6dGNhJOWk1svwKnjRrZYgLd2C/i8zMACG6HKjwDV fuv6CmpsHpLSfWYDp6SamMsANpQcFFIqh3Sym+wdi2RCCvEgmek085fMz8RyuC0YBOVG XYT8fhBrpE/Yf9BWTcjJGDCEyXqCdufAI22HSRtOK/dzmFMoJjU6hxlkOtQKMkN4GmxH +JUtE64I9Wjrjn4q+4GjipgCaJ8YRQ/KEmjAG7IBdQsRuzygE2ehfdqH5zMLV2E1VyuC JEB9rc+AZcmxeNVv5P5vrD6udLvUu6QaAqXXonTX8LdzmmVZkZXB3wvb9LjyUQjyRmgN U8EQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=bV7AweDD4GFem1zmKsGwNxEnCgD7YXpY599Uau1lCIs=; b=Z1/12v9s9g17kchwjL1GixbQAYMWe4YjejCe2MovPyio46eHqdEULjLIa/np92Rh9Q /A2BrxBt3TPdmuZpHZvuHCH+e2vXGMSOxDpHcBP6TRA/6bwHXdXl1htUItNXYAgxJJt9 pd0HtJbc7PPO5jGu4ccgpQIjZiQvlyAs7HgX04g75biQDu+UQ6ULa96wXKSOlEIlUxBL ytpt/bCf7j5qGf3SsM7hH8d0g2wdharkR+V4+A5pbYmAjqbmRWJtFU43Z/iPNEpqiK3Q q+84A3gHqr4jZNy/ruBVqvD6KKG7dQug7Qaic+v3HtD+R7SQc+qu6OqKeLe9qefL/Y61 sAvw== X-Gm-Message-State: APjAAAXn+AH4DPTjZKz5ci/FTUrNZbkrU8k9vF/GiczJoyz579s7ilFn dvU01W8SXzWZeqoK3373/jLqzEJnI1fYaaOxDYQANQ== X-Google-Smtp-Source: APXvYqydB+Hfrgj2k08Ox5IEEJeMoD/vuEaYokBkPpeLl8hXdy2zlAToiGqUadsdU/WxL7IHqXg8TREEEUR6eX8Cdqk= X-Received: by 2002:a05:6638:348:: with SMTP id x8mr20504336jap.31.1565449980975; Sat, 10 Aug 2019 08:13:00 -0700 (PDT) MIME-Version: 1.0 From: Carl Eugen Hoyos Date: Sat, 10 Aug 2019 17:12:50 +0200 Message-ID: To: FFmpeg development discussions and patches Subject: [FFmpeg-devel] [PATCH]lavc/libx264: Cast bit_rate to int64_t to avoid an integer overflow X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Hi! Attached patch really fixes ticket #8071 for me. Please comment, Carl Eugen From e94234fb683b30518d96b1a36aba9e27c4cf9f1b Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Sat, 10 Aug 2019 17:10:58 +0200 Subject: [PATCH] lavc/libx264: Cast bit_rate to int64_t to avoid an integer overflow. Fixes ticket #8071. --- libavcodec/libx264.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/libx264.c b/libavcodec/libx264.c index dc4b4b100d..772fc614ac 100644 --- a/libavcodec/libx264.c +++ b/libavcodec/libx264.c @@ -898,7 +898,7 @@ FF_ENABLE_DEPRECATION_WARNINGS if (avctx->max_b_frames < 0) avctx->max_b_frames = 0; - avctx->bit_rate = x4->params.rc.i_bitrate*1000; + avctx->bit_rate = (int64_t)x4->params.rc.i_bitrate*1000; x4->enc = x264_encoder_open(&x4->params); if (!x4->enc) -- 2.22.0