From patchwork Mon Oct 3 12:46:04 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Carl Eugen Hoyos X-Patchwork-Id: 843 Delivered-To: ffmpegpatchwork@gmail.com Received: by 10.103.140.66 with SMTP id o63csp1569633vsd; Mon, 3 Oct 2016 05:46:16 -0700 (PDT) X-Received: by 10.194.7.68 with SMTP id h4mr5997877wja.156.1475498776089; Mon, 03 Oct 2016 05:46:16 -0700 (PDT) Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id f197si18591808wme.133.2016.10.03.05.46.14; Mon, 03 Oct 2016 05:46:16 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE dis=NONE) header.from=gmail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 794F4689CB1; Mon, 3 Oct 2016 15:45:58 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-ua0-f169.google.com (mail-ua0-f169.google.com [209.85.217.169]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 888AC6898D9 for ; Mon, 3 Oct 2016 15:45:51 +0300 (EEST) Received: by mail-ua0-f169.google.com with SMTP id n13so148806194uaa.3 for ; Mon, 03 Oct 2016 05:46:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=CgLaBh6Vt0iy/j76INAKfZwdn3i7GLMcL5ACJULMyUM=; b=zR1uFysrxFNfZrtx7RSuaVMPzxh9FK+oBKjjp1x9Iqb8ZbqFERpXK+DXRsYk+D+na8 rnevLxrvk3PgE0BXBRqzunp7JYRklSbsHP6h+1d8CtQURUrNH8BvkN4NQBnMYgTRHvV1 KsEuYV67hvwehWU9ohnK0dpy6KAW2J/LEA/wl73fJiykVjx5fb3KKdCuCeS9aPwUJszC EdyJtqxgXCtCNb+bvyBtfACBfY/XexIVHaeJZjVH+A0bJdQUuzCj2V7f+mQFrih1VsHV C1YoUf79koLFFLlDzwXmLDEYiSSVJh3VfOIhfQ63Do1OeZNNtJD2cx+9wt6Js3cx6tss RlHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=CgLaBh6Vt0iy/j76INAKfZwdn3i7GLMcL5ACJULMyUM=; b=euhCYg2OtKmzoU17Wr4HnHx4e5/qmxvU+X8NmUpdQWQjCjcgtVewcgP8lZtcUqAmUh 61Ih5ICdC4L5b44E/P6MwXhY2Yac4b7/rLCax+jl5LthaCEJsexwYZmtbliw5pYdFcxY 7W/ftUT8woSjP2sVx8BfngO4MMWpQDu9cUHHYG2w+u2t8FG+TOecvc8Sz/r35sjxpCMy yB88MrMmg9gMqBazWHJBAhhrMVZ9DHsD9dONrmemwPqf/9FbmmqCfpTF2CgzDMdG6g6z rS3PtiGit0qDPBhLAJeejW198FKfqYLkmJN4EaicacOxkUtlFJV9hTFUXorVJjrZHSZ2 mpDw== X-Gm-Message-State: AA6/9RlSNZpVenOLI/+U+Gb4bv3SoPAO2cQKVjOMrFB+x67Ahri16HXch/RTNSIiOWLsk2TVOVmTrT5IZ4b3ow== X-Received: by 10.176.3.135 with SMTP id 7mr9395475uau.78.1475498764587; Mon, 03 Oct 2016 05:46:04 -0700 (PDT) MIME-Version: 1.0 Received: by 10.103.46.67 with HTTP; Mon, 3 Oct 2016 05:46:04 -0700 (PDT) In-Reply-To: References: <201610030151.25089.cehoyos@ag.or.at> <20161003025758.7a494750@debian> From: Carl Eugen Hoyos Date: Mon, 3 Oct 2016 14:46:04 +0200 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH]doc/platform: Mention musl where x86_32 is not supported X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" 2016-10-03 13:57 GMT+02:00 Hendrik Leppkes : > The underlying problem is that mmx code is mixed with allocations, Definitely. > which seems like an unusual case to begin with I am not sure if I understand this but one instance is calling radix_sort() in the dnxhd encoder. Below is what is needed to run the dnxhd fate tests here (the hr hq test crashes), the second hunk is needed to fix thread joining and avoid an endless loop. There are also issues with h26x. You may be interested in this post that contains a link to a work-around in musl: http://www.openwall.com/lists/musl/2016/09/14/8 No more comments from me, Carl Eugen int mb = ctx->mb_cmp[x].mb; @@ -1214,6 +1215,7 @@ FF_ENABLE_DEPRECATION_WARNINGS ff_side_data_set_encoder_stats(pkt, ctx->qscale * FF_QP2LAMBDA, NULL, 0, AV_PICTURE_TYPE_I); + emms_c(); pkt->flags |= AV_PKT_FLAG_KEY; *got_packet = 1; return 0; diff --git a/libavcodec/dnxhdenc.c b/libavcodec/dnxhdenc.c index 88edd6b..5b4a36a 100644 --- a/libavcodec/dnxhdenc.c +++ b/libavcodec/dnxhdenc.c @@ -1117,6 +1117,7 @@ static int dnxhd_encode_fast(AVCodecContext *avctx, DNXHDEncContext *ctx) if (RC_VARIANCE) avctx->execute2(avctx, dnxhd_mb_var_thread, NULL, NULL, ctx->m.mb_height); + emms_c(); radix_sort(ctx->mb_cmp, ctx->m.mb_num); for (x = 0; x < ctx->m.mb_num && max_bits > ctx->frame_bits; x++) {