From patchwork Thu Dec 6 22:26:55 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Carl Eugen Hoyos X-Patchwork-Id: 11317 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id 362EB44D5E3 for ; Fri, 7 Dec 2018 00:27:05 +0200 (EET) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 6F23568A6B1; Fri, 7 Dec 2018 00:26:55 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-it1-f195.google.com (mail-it1-f195.google.com [209.85.166.195]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 5EBC168A617 for ; Fri, 7 Dec 2018 00:26:48 +0200 (EET) Received: by mail-it1-f195.google.com with SMTP id m8so12899itk.0 for ; Thu, 06 Dec 2018 14:26:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=IU1cTKv3wda5N2hGszM4k9R1Nkhgap4sL0WvQQRyeX8=; b=eQ3ZQROMx6CtXMEydgqad6WVzvKo61uNyJtDQU70mqLjpL6exGbF8Qcgg/+4dRj6Ll /KmAAWUooGTU2jldogGoMjHl+et1xlPxApdMEwCbIRAYYjSbKVG2gzZbEYlpBTYoC/z8 uNsffv+QZdptM8nA9R1/GXgIX4yJscsPEgyaIKN0okhLHd/kQrkca8+jYmt5ypo7u5Cc RBROGmnOLsVGAeUgSjw0SK/eU/qRKl/8phNUGKoi+9vGgZGhXDZvrEn8Oh7Pztruwuot MR4d7/qkD5/USxb7wHIZTTD9wWaAzVgO0oB2NSuoiDkjAPq7PsTJ9Pr7ixfZ3CACVf08 aB7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=IU1cTKv3wda5N2hGszM4k9R1Nkhgap4sL0WvQQRyeX8=; b=KbsI5RAqDYMMmTV2NKb3JcNckYFdTyzYvVkheI4Ciy2i9zyPHhGeABHOsPaOzIULtI Oi4G3YD2loVqeF3oHyqL4dzCmNpRomOaHgOUsfNZADudlTNUw9gNUVn9hLSNAnxUUOe8 FMmT6aXrPFAWDYztIWoZOC0ilan53NdtwlPyyfB9FxH5thP3iqDPojTGd64cAHGTD3IQ s1nJ0MJ6peDp9/vPjO6LBkQbs8PDk2PowH/3j1nETnTzKKYzHAhzqWm+RXFtp41wGyZ0 5yPtovPcyHIw6H3h6s/w8CbkeUWtOX218eld4dNEnYThPQI+CQoqDNtbleF58Hiva4GT OwYg== X-Gm-Message-State: AA+aEWZiBqkznylXhYW7nTUXfuVSuPysZvLd6Q2D+CNscPsVnsx0zyCX vPG2u3ec45FsoknGelezg4rRHXcZMxYJC12fh5xhvw== X-Google-Smtp-Source: AFSGD/VQm/U58J0aKZsQvENHKXTYF1/C4iRCDjjSHk9dq3d5rP1UuY0CevriUZSQPk6wkcS8Dm2oxoB7XutpwMp+7E0= X-Received: by 2002:a02:9c53:: with SMTP id h19mr28420013jal.31.1544135216620; Thu, 06 Dec 2018 14:26:56 -0800 (PST) MIME-Version: 1.0 Received: by 2002:a02:5f11:0:0:0:0:0 with HTTP; Thu, 6 Dec 2018 14:26:55 -0800 (PST) From: Carl Eugen Hoyos Date: Thu, 6 Dec 2018 23:26:55 +0100 Message-ID: To: FFmpeg development discussions and patches Subject: [FFmpeg-devel] [PATCH]lavf/matroskadec: Do not use strncat() to limit copying a one-char constant X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Hi! Attached patch silences a new gcc warning, alternative would be to disable the warning. Please comment, Carl Eugen From dd49cddc6fad136222d4a168301059d55fea4a4c Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Thu, 6 Dec 2018 23:23:12 +0100 Subject: [PATCH] lavf/matroskadec: Do not use strncat() to limit copying a one-char constant. Silences a warning: libavformat/matroskadec.c: In function 'webm_dash_manifest_cues': libavformat/matroskadec.c:3947:13: warning: 'strncat' specified bound 1 equals source length [-Wstringop-overflow=] strncat(buf, ",", 1); ^~~~~~~~~~~~~~~~~~~~ --- libavformat/matroskadec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c index 2daa1db..df820b4 100644 --- a/libavformat/matroskadec.c +++ b/libavformat/matroskadec.c @@ -3944,7 +3944,7 @@ static int webm_dash_manifest_cues(AVFormatContext *s, int64_t init_range) } end += ret; if (i != s->streams[0]->nb_index_entries - 1) { - strncat(buf, ",", 1); + strcat(buf, ","); end++; } } -- 1.7.10.4