From patchwork Thu Mar 14 23:56:05 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Carl Eugen Hoyos X-Patchwork-Id: 12311 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id EB7474493DF for ; Fri, 15 Mar 2019 01:56:14 +0200 (EET) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C924668A915; Fri, 15 Mar 2019 01:56:14 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-io1-f42.google.com (mail-io1-f42.google.com [209.85.166.42]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 1253868A807 for ; Fri, 15 Mar 2019 01:56:08 +0200 (EET) Received: by mail-io1-f42.google.com with SMTP id p17so6730767iol.7 for ; Thu, 14 Mar 2019 16:56:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=PjCJBXxIcacihTgGeaAaGsZDn8icKsPXfGQEN2ownEo=; b=ggKOX4sTybhh0EJSZz1BRz0dokupou/71f8jaR4umVnIpcdeCyy6XN1eBECIdIISZS N0R8MJdGM3Um7dhNCyOgGNIQjqr5Ehg5cCbcDO3W2NU8k1aG3toLB9bnfEi1GePdDz+C C+S324A0OMgh/v1/8DMBJtzk9Rpf7vMfMbYIPkxd2F/D6PZkv9TwCOiHgSYeDVschand J7tl5OLthYoRI5uJ7mjbYYZs3NY0AZo5bXhxqW5JdIDA6qhQoWT/21fobrlsqQg36ldo ZA+XL7883ob1he0hJKGaOitH/EVnsv2KqCR3jOzhmyGoqDfKBIvrAulEEvDNO0IAiXpw oKiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=PjCJBXxIcacihTgGeaAaGsZDn8icKsPXfGQEN2ownEo=; b=gUt9lLcXDrB4LJ3BplwNqoyjzOOsMuwKRl4s5ZTUUxRG6aJsEGzysCHlapy4TajFJ4 fakFU/EmRP6ZhMcd057Kl9UZRFkL6xVxMTEHGQDUSs4eGmlbXSDbqy+G0O930RZbI5Sz vzICpOMwmdGAcLW40qrpDM1E1Gx1UxkJQej8RG/TCYUpXm3vsYJi0YlNT3RB7RsUAz/A gTKuOVE4GlnZcKoerbwNpfxMyiUDXB0dhwInkLtXL4sim8pIco9tYcO9WQGp+Ztn3K+p uu88shAzFJSUMp4yvfiNzMFIKDY+TfyDHjdBpvBb+6q0efl9BMJXDRYPUQa+xb5c6wTp AA3Q== X-Gm-Message-State: APjAAAVPNDCSakx95bSEDkKWGe+GQwg/grn3LeQJwDDuZDjsvMMHtUVU tmCLEtvGodUOT52iIeAxgyb4MM/lBx5cjIICW/mHaw== X-Google-Smtp-Source: APXvYqyqvaRWvpIf0JoNot5rPKnHtW+H3EMhEQQeqAmfwRshDDR+sKMrkv3zuQePrh0Yx+/+x4wVWjCS1EPrGRVj3S4= X-Received: by 2002:a5d:9455:: with SMTP id x21mr480882ior.250.1552607766545; Thu, 14 Mar 2019 16:56:06 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a02:fca:0:0:0:0:0 with HTTP; Thu, 14 Mar 2019 16:56:05 -0700 (PDT) From: Carl Eugen Hoyos Date: Fri, 15 Mar 2019 00:56:05 +0100 Message-ID: To: FFmpeg development discussions and patches Subject: [FFmpeg-devel] [PATCH]lavf/sdp: Change configuration pointer from char* to uint8_t*. X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Hi! Attached patch silences three warnings with clang and makes the pointer type equal to what the function called with the pointer expects. Please comment, Carl Eugen From cf06b8cc09acd676ac6fb713168c23342d26e1b8 Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Fri, 15 Mar 2019 00:52:50 +0100 Subject: [PATCH] lavf/sdp: Change pointer to configuration from char* to uint8_t*. This is also what av_base64_encode() expects. Fixes the following warnings with clang: libavformat/sdp.c:394:40: warning: implicit conversion from 'int' to 'char' changes value from 254 to -2 libavformat/sdp.c:395:40: warning: implicit conversion from 'int' to 'char' changes value from 205 to -51 libavformat/sdp.c:396:40: warning: implicit conversion from 'int' to 'char' changes value from 186 to -70 --- libavformat/sdp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavformat/sdp.c b/libavformat/sdp.c index a5d202e..34e9839 100644 --- a/libavformat/sdp.c +++ b/libavformat/sdp.c @@ -347,7 +347,8 @@ static char *extradata2config(AVFormatContext *s, AVCodecParameters *par) static char *xiph_extradata2config(AVFormatContext *s, AVCodecParameters *par) { - char *config, *encoded_config; + uint8_t *config; + char *encoded_config; const uint8_t *header_start[3]; int headers_len, header_len[3], config_len; int first_header_size; -- 1.7.10.4