From patchwork Mon Dec 17 19:43:13 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Carl Eugen Hoyos X-Patchwork-Id: 11451 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id 431B644DAC4 for ; Mon, 17 Dec 2018 21:43:21 +0200 (EET) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 6281768A958; Mon, 17 Dec 2018 21:43:21 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-it1-f195.google.com (mail-it1-f195.google.com [209.85.166.195]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 1107068A815 for ; Mon, 17 Dec 2018 21:43:15 +0200 (EET) Received: by mail-it1-f195.google.com with SMTP id h65so715490ith.3 for ; Mon, 17 Dec 2018 11:43:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=sj5cZSOGf6PVnFBQnEl8dEn0r9FCo6fM3K0rJsYtlqg=; b=SjPyT9zbIVVE8HPW9VvCM4c638aa+i6nY0LNtAY/Wk/KGY8eU/aEMtXZ5y4zXb3lyS 7URYkVOYdvRtVE6yktwcmTxIcbkn9CPSPb1yw837O6y5PSM3f2mgHuxodH/VQ/QJ4olY Qu+snpLPQjMds3IAZNoHmgOZgPbBB1EmUhZu6pAYI7e8GL7Lg+U0X4100NM0KJhm5o5J rmxIDqioeBEbpxGKus1i2ujgmV8RDdDiSenthD4qsPXKVk+KLkWCvpiK3fZL24sjgdHb nA36TfqF3ick1q21VpYYOgkz53qFasqcBDvwy58QlumWgr1mH0FmbG3F2XLZaUMXpaZ2 PbJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=sj5cZSOGf6PVnFBQnEl8dEn0r9FCo6fM3K0rJsYtlqg=; b=oSVxNvF8QFDE1zEGgnXZs9kHQXHW5oG7dnHfBtctWOZiSAQP9+EzoZxJ8u6YL0ptc8 3xQJFVczeeBN/y8elOsEgO65FBVMYVWgtJd9l9oHaCOfcm1vsVgMyODTw5Y+oRAjWVYV lEx599UXGTPMWflZ06szTSemBy5sz2TyCMe5g5nSmjYXqsrMP/Vdqno78EWvooFRJrWT 7IB0QtjWtUH/KR5rsrlqjBEyBAKYFBCPYtB1A4hKj7MH1eE9PBzkkXSH49VmPEusVtRC a+MWCmxquz9liaG17Ofh7dCgcxRHeryXrbTAH8n6ryC0b2CCgGsupLQuUIMDkIvQy8r2 veng== X-Gm-Message-State: AA+aEWahhQpLWaQrB1Y4BiTAqOXkP75TOR0TCOm46CbS4knBhIF6kMA4 wSX7t9+s2sD8aEjjl3/omfInqZaDqZ0xeHWWjxoYyg== X-Google-Smtp-Source: AFSGD/XNfbUnNdCE3yOxhKmv1dBOj4o6bu779XZxZLYu4d5bt9LAFyw9tEvVdfSagTSq0bmdotyIxXjp22G+HQ1eaGE= X-Received: by 2002:a02:9c53:: with SMTP id h19mr13575927jal.31.1545075794820; Mon, 17 Dec 2018 11:43:14 -0800 (PST) MIME-Version: 1.0 Received: by 2002:a02:5f11:0:0:0:0:0 with HTTP; Mon, 17 Dec 2018 11:43:13 -0800 (PST) In-Reply-To: <20181217154521.GA3947691@phare.normalesup.org> References: <20181217122400.GB3501@michaelspb> <20181217154521.GA3947691@phare.normalesup.org> From: Carl Eugen Hoyos Date: Mon, 17 Dec 2018 20:43:13 +0100 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH]lsws/utils: Split "emms_c(); " call in two lines X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" 2018-12-17 16:45 GMT+01:00, Nicolas George : > Carl Eugen Hoyos (2018-12-17): >> #ifndef emms_c >> -# define emms_c() while(0) >> +# define emms_c() while(0){} >> #endif > > That feels really wrong, or at least completely unusual. But not the > change you made, the original code: the usual statement is: > "do { statement } while (0)" > > And if you make that change, you will get a warning about a semicolon > after a braced block. > > I suggest to change the definition to > > #define emms_c() do { } while (0) New patch attached. Thank you, Carl Eugen From 651baa2d7ec1a163dc00adf1885146b0938745e3 Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Mon, 17 Dec 2018 20:33:24 +0100 Subject: [PATCH] lavu/internal: Replace an empty loop with "do {}". Silences a clang warning when not compiling for x86: libswscale/utils.c:345:13: warning: while loop has empty body Suggested-by: Nicolas George --- libavutil/internal.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavutil/internal.h b/libavutil/internal.h index 06bd561..4acbcf5 100644 --- a/libavutil/internal.h +++ b/libavutil/internal.h @@ -52,7 +52,7 @@ #endif #ifndef emms_c -# define emms_c() while(0) +# define emms_c() do {} while(0) #endif #ifndef attribute_align_arg -- 1.7.10.4