From patchwork Sat Aug 10 15:10:41 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Carl Eugen Hoyos X-Patchwork-Id: 14374 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id 43B6B44839E for ; Sat, 10 Aug 2019 18:11:00 +0300 (EEST) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1B43F68AB80; Sat, 10 Aug 2019 18:11:00 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-ot1-f67.google.com (mail-ot1-f67.google.com [209.85.210.67]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 0710E689D1F for ; Sat, 10 Aug 2019 18:10:54 +0300 (EEST) Received: by mail-ot1-f67.google.com with SMTP id j11so43540236otp.10 for ; Sat, 10 Aug 2019 08:10:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=YJ/ijP4GWrzjwTPkUCWSZjRP7LR3ynjDsGjUnHbXlEo=; b=diUEXwoCZeYWBThITAkGKw3a5fj/RF4K1bxpOenUKQCmxeAS9IEwkg4GhuqVFrDoEX Cq7NscrqbBJB3zGh8MhI3rYTeV41169O6aSE05P9q8IGGaJmaOI3coOzf3N3ICP5PgkR eZ7R3KgeHcN2O3jdADU7JVn4Ll8E6joUevLXt9lO4NLqUHWDgUSAHQC+IC7JCE3H80e0 FJpZjt0KDLZOtfd0/acwzwPL4xXsoPScmSpCDzyvKoXsgQVJAJvs+mFa4muJsbJ3e9gf 8/nxwAMer24l7phTfWw2UY8DCLCHgq54va4Kw/oosSnAwAXKZpko9qOUGHNN9KQporWt voOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=YJ/ijP4GWrzjwTPkUCWSZjRP7LR3ynjDsGjUnHbXlEo=; b=axBID5LPiuUo6+UIFGjJzjcEFhnEeDQoHnloCG/hck+8pWheenAPVcZ3WJQeeWkS/n RxlwTEbx8LW3noHqA9hUNQh+mQFdx3Ol35HK8/8ZabMokd/zwNpZXAwrLIZ1Ir7hRbIJ rZBtfjiY+CNGkIzohVeArViTiYzwllwGkCgf6nzldq3uXQNcrcuHbOD772BCn+pB3WcS UemwkGhDYFRQ0cMPYeqNqa3zg6Ks8tC+vAHVPZSBt+f+Ef11JZzTNJGiW6FQHpAfCkU6 G/rh4gmBM/NKzJJ5yeI9E+P2l55Cd4sQY7WQCvtQvdfNs+n6P84LRAJJLeubMvQKn/45 Rpig== X-Gm-Message-State: APjAAAUtHh6Zf/d980rtRcbz9M/q27tuJtQTl2y5c2+qQyXzIe7VkSil ZL7x+Uca8moegnkYgV67Xzcnuu4W3l5AFYfiFQAUIw== X-Google-Smtp-Source: APXvYqxhxMMEXKNAMMUhMDflReGMyHPSGPj3qvxejwvo+i4iFXV+kQEvrjdKs07FjWgXqE/WEMLgs3Kb3AX2Qsnyrr0= X-Received: by 2002:a02:8481:: with SMTP id f1mr9328595jai.112.1565449852423; Sat, 10 Aug 2019 08:10:52 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Carl Eugen Hoyos Date: Sat, 10 Aug 2019 17:10:41 +0200 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH]lavc/libx264: bit_rates > INT_MAX are not supported X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Am Sa., 10. Aug. 2019 um 16:54 Uhr schrieb Hendrik Leppkes : > > On Sat, Aug 10, 2019 at 2:43 PM Carl Eugen Hoyos wrote: > > > > Hi! > > > > Attached patch fixes ticket #8071. > > > > You could allow the full range of bit_rate since its immediately > divided by 1000, couldn't you? New patch attached, unrelated to ticket #8071. Thank you, Carl Eugen From 8fd6cc5727b824572ba2147dfeec6f00520c9f69 Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Sat, 10 Aug 2019 14:40:23 +0200 Subject: [PATCH] lavc/libx264: bit_rates > INT_MAX are not supported. --- libavcodec/libx264.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/libavcodec/libx264.c b/libavcodec/libx264.c index dc4b4b100d..ea44cc38c6 100644 --- a/libavcodec/libx264.c +++ b/libavcodec/libx264.c @@ -594,6 +594,10 @@ static av_cold int X264_init(AVCodecContext *avctx) PARSE_X264_OPT("weightp", wpredp); if (avctx->bit_rate) { + if (avctx->bit_rate / 1000 > INT_MAX || avctx->rc_max_rate / 1000 > INT_MAX) { + av_log(avctx, AV_LOG_ERROR, "bit_rate and rc_max_rate > %d000 not supported by libx264\n", INT_MAX); + return AVERROR(EINVAL); + } x4->params.rc.i_bitrate = avctx->bit_rate / 1000; x4->params.rc.i_rc_method = X264_RC_ABR; } -- 2.22.0